public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-devel][edk2-platforms][PATCH V1 1/1] Platform/Intel/Readme : Fix platform list
@ 2021-12-14 21:57 Oram, Isaac W
  2021-12-15 21:40 ` Nate DeSimone
  2021-12-15 22:15 ` Nate DeSimone
  0 siblings, 2 replies; 3+ messages in thread
From: Oram, Isaac W @ 2021-12-14 21:57 UTC (permalink / raw)
  To: devel
  Cc: manickavasakam karpagavinayagam via groups.io, Nate DeSimone,
	Sai Chaganty, Chasel Chiu, Isaac Oram

From: "manickavasakam karpagavinayagam via groups.io" <manickavasakamk=ami.com@groups.io>

The list of WhiskeyLake and Whitley boards got confused at some
earlier merge.  Also untabified.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
---
 Platform/Intel/Readme.md | 35 ++++++++++----------
 1 file changed, 17 insertions(+), 18 deletions(-)

diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md
index 6fe8e076f3..b92d8a0c24 100644
--- a/Platform/Intel/Readme.md
+++ b/Platform/Intel/Readme.md
@@ -273,7 +273,7 @@ return back to the minimum platform caller.
           |       |        |               |---build_config.cfg: BoardTiogaPass specific
           |       |        |               |                     build settings, environment variables.
           |       |        |               |---build_board.py: Optional board-specific pre-build,
-          |       |        |                                   build, post-build and clean functions.          
+          |       |        |                                   build, post-build and clean functions.
           |       |        |
           |       |        |------SimicsOpenBoardPkg
           |       |        |       |------BoardX58Ich10
@@ -281,24 +281,23 @@ return back to the minimum platform caller.
           |       |        |                                     build settings, environment variables.
           |       |        |
           |       |        |------WhiskeylakeOpenBoardPkg
+          |       |        |       |------UpXtreme
+          |       |        |               |---build_config.cfg: UpXtreme specific build
+          |       |        |       |                             settings environment variables.
+          |       |        |       |------WhiskeylakeURvp
+          |       |        |               |---build_config.cfg: WhiskeylakeURvp specific build
+          |       |        |                                     settings environment variables.
+          |       |        |
+          |       |        |------WhitleyOpenBoardPkg
           |       |        |       |------CooperCityRvp
           |       |        |       |       |---build_config.cfg: CooperCityRvp specific build
           |       |        |       |                             settings environment variables.
           |       |        |       |------WilsonCityRvp
-          |       |        |               |---build_config.cfg: WilsonCityRvp specific build
-          |       |        |                                     settings environment variables.
-          |       |        |
-          |       |        |------WhitleyOpenBoardPkg
-          |       |        |       |------UpXtreme
-          |       |        |               |---build_config.cfg: UpXtreme specific build
-          |       |        |                                     settings environment variables.
-		  |       |        |------WhitleyOpenBoardPkg
+          |       |        |       |       |---build_config.cfg: WilsonCityRvp specific build
+          |       |        |       |                             settings environment variables.
           |       |        |       |------JunctionCity
           |       |        |               |---build_config.cfg: JunctionCity specific build
           |       |        |                                     settings environment variables.
-          |       |        |       |------WhiskeylakeURvp
-          |       |        |               |---build_config.cfg: WhiskeylakeURvp specific build
-          |       |        |                                     settings environment variables.
           |       |        |
           |       |        |------CometlakeOpenBoardPkg
           |       |        |       |------CometlakeURvp
@@ -335,10 +334,10 @@ For PurleyOpenBoardPkg (TiogaPass)
 4. Type "bld" to build Purley BoardTiogaPass board UEFI firmware image, "bld release" for release build, "bld clean" to
    remove intermediate files."bld cache-produce" Generate a cache of binary files in the specified directory,
    "bld cache-consume" Consume a cache of binary files from the specified directory, BINARY_CACHE_PATH is empty,
-   used "BinCache" as default path.  
-5. Final BIOS image will be Build\PurleyOpenBoardPkg\BoardTiagoPass\DEBUG_VS2015x86\FV\PLATFORM.fd or    
+   used "BinCache" as default path.
+5. Final BIOS image will be Build\PurleyOpenBoardPkg\BoardTiagoPass\DEBUG_VS2015x86\FV\PLATFORM.fd or
    Build\PurleyOpenBoardPkg\BoardTiagoPass\RELEASE_VS2015x86\FV\PLATFORM.fd, depending on bld batch script input.
-6. This BIOS image needs to be merged with SPS FW    
+6. This BIOS image needs to be merged with SPS FW
 
 ### **Known limitations**
 
@@ -367,9 +366,9 @@ For PurleyOpenBoardPkg (TiogaPass)
 9. Verified Mellanox card detection during POST and OS
 10. LINUX Boot Support (PcdLinuxBootEnable needs to be enabled)
 
-1.	Follow directions on http://osresearch.net/Building/ to compile the heads kernel and initrd for qemu-system_x86_64 
-2.	Copy the following built files 
-(1) initrd.cpio.xz  to LinuxBootPkg/LinuxBinaries/initrd.cpio.xz 
+1. Follow directions on http://osresearch.net/Building/ to compile the heads kernel and initrd for qemu-system_x86_64
+2. Copy the following built files
+(1) initrd.cpio.xz  to LinuxBootPkg/LinuxBinaries/initrd.cpio.xz
 (2) bzimage to LinuxBootPkg/LinuxBinaries/linux.efi
 
 
-- 
2.27.0.windows.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] Platform/Intel/Readme : Fix platform list
  2021-12-14 21:57 [edk2-devel][edk2-platforms][PATCH V1 1/1] Platform/Intel/Readme : Fix platform list Oram, Isaac W
@ 2021-12-15 21:40 ` Nate DeSimone
  2021-12-15 22:15 ` Nate DeSimone
  1 sibling, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2021-12-15 21:40 UTC (permalink / raw)
  To: Oram, Isaac W, devel@edk2.groups.io
  Cc: manickavasakam karpagavinayagam via groups.io,
	Chaganty, Rangasai V, Chiu, Chasel

Hi Isaac,

Please correct the From: field. With that change...

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Oram, Isaac W <isaac.w.oram@intel.com> 
Sent: Tuesday, December 14, 2021 1:57 PM
To: devel@edk2.groups.io
Cc: manickavasakam karpagavinayagam via groups.io <manickavasakamk=ami.com@groups.io>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>
Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] Platform/Intel/Readme : Fix platform list

From: "manickavasakam karpagavinayagam via groups.io" <manickavasakamk=ami.com@groups.io>

The list of WhiskeyLake and Whitley boards got confused at some earlier merge.  Also untabified.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
---
 Platform/Intel/Readme.md | 35 ++++++++++----------
 1 file changed, 17 insertions(+), 18 deletions(-)

diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md index 6fe8e076f3..b92d8a0c24 100644
--- a/Platform/Intel/Readme.md
+++ b/Platform/Intel/Readme.md
@@ -273,7 +273,7 @@ return back to the minimum platform caller.
           |       |        |               |---build_config.cfg: BoardTiogaPass specific
           |       |        |               |                     build settings, environment variables.
           |       |        |               |---build_board.py: Optional board-specific pre-build,
-          |       |        |                                   build, post-build and clean functions.          
+          |       |        |                                   build, post-build and clean functions.
           |       |        |
           |       |        |------SimicsOpenBoardPkg
           |       |        |       |------BoardX58Ich10
@@ -281,24 +281,23 @@ return back to the minimum platform caller.
           |       |        |                                     build settings, environment variables.
           |       |        |
           |       |        |------WhiskeylakeOpenBoardPkg
+          |       |        |       |------UpXtreme
+          |       |        |               |---build_config.cfg: UpXtreme specific build
+          |       |        |       |                             settings environment variables.
+          |       |        |       |------WhiskeylakeURvp
+          |       |        |               |---build_config.cfg: WhiskeylakeURvp specific build
+          |       |        |                                     settings environment variables.
+          |       |        |
+          |       |        |------WhitleyOpenBoardPkg
           |       |        |       |------CooperCityRvp
           |       |        |       |       |---build_config.cfg: CooperCityRvp specific build
           |       |        |       |                             settings environment variables.
           |       |        |       |------WilsonCityRvp
-          |       |        |               |---build_config.cfg: WilsonCityRvp specific build
-          |       |        |                                     settings environment variables.
-          |       |        |
-          |       |        |------WhitleyOpenBoardPkg
-          |       |        |       |------UpXtreme
-          |       |        |               |---build_config.cfg: UpXtreme specific build
-          |       |        |                                     settings environment variables.
-		  |       |        |------WhitleyOpenBoardPkg
+          |       |        |       |       |---build_config.cfg: WilsonCityRvp specific build
+          |       |        |       |                             settings environment variables.
           |       |        |       |------JunctionCity
           |       |        |               |---build_config.cfg: JunctionCity specific build
           |       |        |                                     settings environment variables.
-          |       |        |       |------WhiskeylakeURvp
-          |       |        |               |---build_config.cfg: WhiskeylakeURvp specific build
-          |       |        |                                     settings environment variables.
           |       |        |
           |       |        |------CometlakeOpenBoardPkg
           |       |        |       |------CometlakeURvp
@@ -335,10 +334,10 @@ For PurleyOpenBoardPkg (TiogaPass)  4. Type "bld" to build Purley BoardTiogaPass board UEFI firmware image, "bld release" for release build, "bld clean" to
    remove intermediate files."bld cache-produce" Generate a cache of binary files in the specified directory,
    "bld cache-consume" Consume a cache of binary files from the specified directory, BINARY_CACHE_PATH is empty,
-   used "BinCache" as default path.  
-5. Final BIOS image will be Build\PurleyOpenBoardPkg\BoardTiagoPass\DEBUG_VS2015x86\FV\PLATFORM.fd or    
+   used "BinCache" as default path.
+5. Final BIOS image will be 
+Build\PurleyOpenBoardPkg\BoardTiagoPass\DEBUG_VS2015x86\FV\PLATFORM.fd 
+or
    Build\PurleyOpenBoardPkg\BoardTiagoPass\RELEASE_VS2015x86\FV\PLATFORM.fd, depending on bld batch script input.
-6. This BIOS image needs to be merged with SPS FW    
+6. This BIOS image needs to be merged with SPS FW
 
 ### **Known limitations**
 
@@ -367,9 +366,9 @@ For PurleyOpenBoardPkg (TiogaPass)  9. Verified Mellanox card detection during POST and OS  10. LINUX Boot Support (PcdLinuxBootEnable needs to be enabled)
 
-1.	Follow directions on http://osresearch.net/Building/ to compile the heads kernel and initrd for qemu-system_x86_64 
-2.	Copy the following built files 
-(1) initrd.cpio.xz  to LinuxBootPkg/LinuxBinaries/initrd.cpio.xz 
+1. Follow directions on http://osresearch.net/Building/ to compile the 
+heads kernel and initrd for qemu-system_x86_64 2. Copy the following 
+built files
+(1) initrd.cpio.xz  to LinuxBootPkg/LinuxBinaries/initrd.cpio.xz
 (2) bzimage to LinuxBootPkg/LinuxBinaries/linux.efi
 
 
--
2.27.0.windows.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] Platform/Intel/Readme : Fix platform list
  2021-12-14 21:57 [edk2-devel][edk2-platforms][PATCH V1 1/1] Platform/Intel/Readme : Fix platform list Oram, Isaac W
  2021-12-15 21:40 ` Nate DeSimone
@ 2021-12-15 22:15 ` Nate DeSimone
  1 sibling, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2021-12-15 22:15 UTC (permalink / raw)
  To: Oram, Isaac W, devel@edk2.groups.io
  Cc: manickavasakam karpagavinayagam via groups.io,
	Chaganty, Rangasai V, Chiu, Chasel

Actually... there are still a few things messed up.

1. There are two copies of PurleyOpenBoardPkg in the tree now
2. The table of platforms contains Markdown syntax errors now
3. There is no manufacturer listed for Junction City

For these reasons, I rescind my previous reviewed-by.

Thanks,
Nate

-----Original Message-----
From: Oram, Isaac W <isaac.w.oram@intel.com> 
Sent: Tuesday, December 14, 2021 1:57 PM
To: devel@edk2.groups.io
Cc: manickavasakam karpagavinayagam via groups.io <manickavasakamk=ami.com@groups.io>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>
Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] Platform/Intel/Readme : Fix platform list

From: "manickavasakam karpagavinayagam via groups.io" <manickavasakamk=ami.com@groups.io>

The list of WhiskeyLake and Whitley boards got confused at some earlier merge.  Also untabified.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
---
 Platform/Intel/Readme.md | 35 ++++++++++----------
 1 file changed, 17 insertions(+), 18 deletions(-)

diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md index 6fe8e076f3..b92d8a0c24 100644
--- a/Platform/Intel/Readme.md
+++ b/Platform/Intel/Readme.md
@@ -273,7 +273,7 @@ return back to the minimum platform caller.
           |       |        |               |---build_config.cfg: BoardTiogaPass specific
           |       |        |               |                     build settings, environment variables.
           |       |        |               |---build_board.py: Optional board-specific pre-build,
-          |       |        |                                   build, post-build and clean functions.          
+          |       |        |                                   build, post-build and clean functions.
           |       |        |
           |       |        |------SimicsOpenBoardPkg
           |       |        |       |------BoardX58Ich10
@@ -281,24 +281,23 @@ return back to the minimum platform caller.
           |       |        |                                     build settings, environment variables.
           |       |        |
           |       |        |------WhiskeylakeOpenBoardPkg
+          |       |        |       |------UpXtreme
+          |       |        |               |---build_config.cfg: UpXtreme specific build
+          |       |        |       |                             settings environment variables.
+          |       |        |       |------WhiskeylakeURvp
+          |       |        |               |---build_config.cfg: WhiskeylakeURvp specific build
+          |       |        |                                     settings environment variables.
+          |       |        |
+          |       |        |------WhitleyOpenBoardPkg
           |       |        |       |------CooperCityRvp
           |       |        |       |       |---build_config.cfg: CooperCityRvp specific build
           |       |        |       |                             settings environment variables.
           |       |        |       |------WilsonCityRvp
-          |       |        |               |---build_config.cfg: WilsonCityRvp specific build
-          |       |        |                                     settings environment variables.
-          |       |        |
-          |       |        |------WhitleyOpenBoardPkg
-          |       |        |       |------UpXtreme
-          |       |        |               |---build_config.cfg: UpXtreme specific build
-          |       |        |                                     settings environment variables.
-		  |       |        |------WhitleyOpenBoardPkg
+          |       |        |       |       |---build_config.cfg: WilsonCityRvp specific build
+          |       |        |       |                             settings environment variables.
           |       |        |       |------JunctionCity
           |       |        |               |---build_config.cfg: JunctionCity specific build
           |       |        |                                     settings environment variables.
-          |       |        |       |------WhiskeylakeURvp
-          |       |        |               |---build_config.cfg: WhiskeylakeURvp specific build
-          |       |        |                                     settings environment variables.
           |       |        |
           |       |        |------CometlakeOpenBoardPkg
           |       |        |       |------CometlakeURvp
@@ -335,10 +334,10 @@ For PurleyOpenBoardPkg (TiogaPass)  4. Type "bld" to build Purley BoardTiogaPass board UEFI firmware image, "bld release" for release build, "bld clean" to
    remove intermediate files."bld cache-produce" Generate a cache of binary files in the specified directory,
    "bld cache-consume" Consume a cache of binary files from the specified directory, BINARY_CACHE_PATH is empty,
-   used "BinCache" as default path.  
-5. Final BIOS image will be Build\PurleyOpenBoardPkg\BoardTiagoPass\DEBUG_VS2015x86\FV\PLATFORM.fd or    
+   used "BinCache" as default path.
+5. Final BIOS image will be 
+Build\PurleyOpenBoardPkg\BoardTiagoPass\DEBUG_VS2015x86\FV\PLATFORM.fd 
+or
    Build\PurleyOpenBoardPkg\BoardTiagoPass\RELEASE_VS2015x86\FV\PLATFORM.fd, depending on bld batch script input.
-6. This BIOS image needs to be merged with SPS FW    
+6. This BIOS image needs to be merged with SPS FW
 
 ### **Known limitations**
 
@@ -367,9 +366,9 @@ For PurleyOpenBoardPkg (TiogaPass)  9. Verified Mellanox card detection during POST and OS  10. LINUX Boot Support (PcdLinuxBootEnable needs to be enabled)
 
-1.	Follow directions on http://osresearch.net/Building/ to compile the heads kernel and initrd for qemu-system_x86_64 
-2.	Copy the following built files 
-(1) initrd.cpio.xz  to LinuxBootPkg/LinuxBinaries/initrd.cpio.xz 
+1. Follow directions on http://osresearch.net/Building/ to compile the 
+heads kernel and initrd for qemu-system_x86_64 2. Copy the following 
+built files
+(1) initrd.cpio.xz  to LinuxBootPkg/LinuxBinaries/initrd.cpio.xz
 (2) bzimage to LinuxBootPkg/LinuxBinaries/linux.efi
 
 
--
2.27.0.windows.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-15 22:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-14 21:57 [edk2-devel][edk2-platforms][PATCH V1 1/1] Platform/Intel/Readme : Fix platform list Oram, Isaac W
2021-12-15 21:40 ` Nate DeSimone
2021-12-15 22:15 ` Nate DeSimone

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox