From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id E2F919418A2 for ; Wed, 1 May 2024 18:12:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=PA2uoU/Bh5KR2rzKAQ5L3l0yfnmYoP11wT/poGCB3tk=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1714587166; v=1; b=OGQQ34KfnZaQ2/E9VaWmjvsXHC6TT1TTVcYp2sbwZIKkd2npHg0/FA9trbUJq0GeisJAzanJ REcsk2BDTQXPOLl5l1uqEkr6fxo7kOmBxKcGy/Ws9BYteoD0F9oXIJBSge1gZ1/OEAn/XDerOr8 tQMrw+FoNUdqHgdIwdZxz93xeV6CzJeHt6ICKCzySM0cvrFImA2upvVm4RM2nDYYKwpY7baF/vy 2/paAadW6oWgzrd32ZmDGYXOUrqHvvyNN01Oa/CUpv/sQ2wUAKMEfPHKAJPZ8ErwF+PDnEDQaSV TiPBR2dCH969gdlSJiV465vkSNFUAEe1aVnsfFL9eYV1g== X-Received: by 127.0.0.2 with SMTP id vZUtYY7687511xVlJnH7IOhc; Wed, 01 May 2024 11:12:46 -0700 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web11.3701.1714587165500587121 for ; Wed, 01 May 2024 11:12:45 -0700 X-Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 441EF9Eh016868; Wed, 1 May 2024 18:12:40 GMT X-Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3xupfmgnct-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 01 May 2024 18:12:40 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 441ICdWI016337 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 1 May 2024 18:12:39 GMT X-Received: from [10.111.142.244] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 1 May 2024 11:12:38 -0700 Message-ID: <076697e5-a594-40a7-8100-767d6a2f7520@quicinc.com> Date: Wed, 1 May 2024 19:12:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024 To: , , "rfc@edk2.groups.io" CC: "Andrew Fish (afish@apple.com)" References: From: "Leif Lindholm" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: X4CbtULZcIDbHKyNdMBDrWdoBVYPYQ72 X-Proofpoint-ORIG-GUID: X4CbtULZcIDbHKyNdMBDrWdoBVYPYQ72 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 01 May 2024 11:12:45 -0700 Resent-From: quic_llindhol@quicinc.com Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 1mTe6FtEPY1yMzwvszhbd1tix7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=OGQQ34Kf; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On 2024-05-01 18:43, Michael D Kinney wrote: > Hello, >=20 > I would like to propose that TianoCore move all code review from email > based code reviews to GitHub Pull Requests based code reviews. >=20 > The proposed date to switch would be immediately after the next stable > tag which is currently scheduled for May 24, 2024. Thanks Mike. I'm in favour of this change, and the date. I still want us to try to figure out how to retain review history beyond=20 what github decides we need, but I don't think it justifies indefinitely=20 delaying the switchover. And frankly, it will be easier to experiment=20 with what works and not after the switch. / Leif > Updates to the following Wiki page would be required to describe the > required process when using GitHub Pull Requests for all code review > related activity. >=20 > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Develop= ment-Process >=20 > A couple examples of the changes that would need to be documented are: >=20 > * All contributors, maintainers, and reviewers must have GitHub IDs. > * The commit message would no longer require Cc:, Reviewed-by:, Acked-by: > or Tested-by: tags. The only required tag would be Signed-off-by. > * The Pull Request submitter is required to invite the required > maintainers and reviewers to the pull request. This is the same > set of maintainers and reviewers that are required to be listed in > Cc: tags in today's process. > * Maintainers are responsible for verifying that all conversations in > the code review are resolved and that all review approvals from the > required set of maintainers are present before setting the 'push' labe= l. >=20 >=20 > Please provide feedback > 1) If you are not in favor of this change. > 2) If you are not in favor of the proposed date of this change. > 3) On the process changes you would like to see documented in the Wiki > pages related to using GitHub Pull Request based code reviews. >=20 > There is some prototype work to automate/simplify some of the PR based > code review process steps. Those could be added over time as resources > are available to finish and support them. >=20 > Best regards, >=20 > Mike >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118469): https://edk2.groups.io/g/devel/message/118469 Mute This Topic: https://groups.io/mt/105847510/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-