* Re: [edk2-devel] [edk2-non-osi] [PATCH] ElkhartlakeSiliconBinPkg: Add ElkhartlakeSiliconPkg
2020-10-23 8:50 [edk2-devel] [edk2-non-osi] [PATCH] ElkhartlakeSiliconBinPkg: Add ElkhartlakeSiliconPkg jinjhuli
@ 2020-10-26 21:45 ` Nate DeSimone
2020-12-19 1:47 ` Nate DeSimone
2020-12-19 1:54 ` Nate DeSimone
2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2020-10-26 21:45 UTC (permalink / raw)
To: devel@edk2.groups.io, Lim, Jin Jhu; +Cc: Kinney, Michael D, Chiu, Chasel
Hi Jin Jhu,
This patch itself seems reasonable, however please make sure to send an additional patch to add maintainers for this new package to maintainers.txt
Thanks,
Nate
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of jinjhuli
> Sent: Friday, October 23, 2020 1:50 AM
> To: devel@edk2.groups.io
> Cc: Lim, Jin Jhu <jin.jhu.lim@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [edk2-devel] [edk2-non-osi] [PATCH] ElkhartlakeSiliconBinPkg: Add
> ElkhartlakeSiliconPkg
>
> Add binary package for Elkhart Lake.
>
> Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Signed-off-by: jinjhuli <jin.jhu.lim@intel.com>
> ---
> .../ElkhartlakeSiliconBinPkg/License.txt | 30 +++++++++++++++
> .../Microcode/IntelMicrocodeLicense.txt | 37 +++++++++++++++++++
> 2 files changed, 67 insertions(+)
> create mode 100644 Silicon/Intel/ElkhartlakeSiliconBinPkg/License.txt
> create mode 100644
> Silicon/Intel/ElkhartlakeSiliconBinPkg/Microcode/IntelMicrocodeLicense.txt
>
> diff --git a/Silicon/Intel/ElkhartlakeSiliconBinPkg/License.txt
> b/Silicon/Intel/ElkhartlakeSiliconBinPkg/License.txt
> new file mode 100644
> index 0000000..f5527e1
> --- /dev/null
> +++ b/Silicon/Intel/ElkhartlakeSiliconBinPkg/License.txt
> @@ -0,0 +1,30 @@
> +Copyright (c) 2020 Intel Corporation. All rights reserved.
> +
> +Redistribution and use in source and binary forms, with or without
> +modification, are permitted provided that the following conditions are
> +met:
> +
> +* Redistributions of source code must retain the above copyright
> + notice, this list of conditions and the following disclaimer.
> +* Redistributions in binary form must reproduce the above copyright
> + notice, this list of conditions and the following disclaimer in
> + the documentation and/or other materials provided with the
> + distribution.
> +
> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
> CONTRIBUTORS "AS
> +IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> LIMITED
> +TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
> +PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> COPYRIGHT
> +HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> INCIDENTAL,
> +SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
> NOT
> +LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
> USE,
> +DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
> ON ANY
> +THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
> THE USE
> +OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
> DAMAGE.
> +
> +Some files are subject to a license documented in the
> +IntelProprietaryLicense.txt file. These files are in the same directory
> +as IntelProprietaryLicense.txt, and they do not have a license
> +specified within the file.
> diff --git
> a/Silicon/Intel/ElkhartlakeSiliconBinPkg/Microcode/IntelMicrocodeLicense.tx
> t
> b/Silicon/Intel/ElkhartlakeSiliconBinPkg/Microcode/IntelMicrocodeLicense.tx
> t
> new file mode 100644
> index 0000000..ea33b61
> --- /dev/null
> +++ b/Silicon/Intel/ElkhartlakeSiliconBinPkg/Microcode/IntelMicrocodeLic
> +++ ense.txt
> @@ -0,0 +1,37 @@
> +Copyright (c) 2018 - 2020 Intel Corporation.
> +All rights reserved.
> +
> +Redistribution.
> +
> +Redistribution and use in binary form, without modification, are
> +permitted, provided that the following conditions are met:
> +
> +1. Redistributions must reproduce the above copyright notice and the
> + following disclaimer in the documentation and/or other materials
> provided
> + with the distribution.
> +
> +2. Neither the name of Intel Corporation nor the names of its suppliers may
> + be used to endorse or promote products derived from this software
> without
> + specific prior written permission.
> +
> +3. No reverse engineering, decompilation, or disassembly of this software
> + is permitted.
> +
> +
> +"Binary form" includes any format that is commonly used for electronic
> +conveyance that is a reversible, bit-exact translation of binary
> +representation to ASCII or ISO text, for example "uuencode".
> +
> +DISCLAIMER.
> +
> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
> CONTRIBUTORS "AS IS"
> +AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> LIMITED TO,
> +THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
> PARTICULAR
> +PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER
> OR
> +CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> SPECIAL,
> +EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> LIMITED TO,
> +PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA,
> OR
> +PROFITS; OR BUSINESS
> +INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
> WHETHER IN
> +CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
> OTHERWISE)
> +ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
> ADVISED OF
> +THE POSSIBILITY OF SUCH DAMAGE.
> --
> 2.28.0.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [edk2-non-osi] [PATCH] ElkhartlakeSiliconBinPkg: Add ElkhartlakeSiliconPkg
2020-10-23 8:50 [edk2-devel] [edk2-non-osi] [PATCH] ElkhartlakeSiliconBinPkg: Add ElkhartlakeSiliconPkg jinjhuli
2020-10-26 21:45 ` Nate DeSimone
@ 2020-12-19 1:47 ` Nate DeSimone
2020-12-19 1:54 ` Nate DeSimone
2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2020-12-19 1:47 UTC (permalink / raw)
To: devel@edk2.groups.io, Lim, Jin Jhu; +Cc: Kinney, Michael D, Chiu, Chasel
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of jinjhuli
> Sent: Friday, October 23, 2020 1:50 AM
> To: devel@edk2.groups.io
> Cc: Lim, Jin Jhu <jin.jhu.lim@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [edk2-devel] [edk2-non-osi] [PATCH] ElkhartlakeSiliconBinPkg: Add
> ElkhartlakeSiliconPkg
>
> Add binary package for Elkhart Lake.
>
> Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Signed-off-by: jinjhuli <jin.jhu.lim@intel.com>
> ---
> .../ElkhartlakeSiliconBinPkg/License.txt | 30 +++++++++++++++
> .../Microcode/IntelMicrocodeLicense.txt | 37 +++++++++++++++++++
> 2 files changed, 67 insertions(+)
> create mode 100644 Silicon/Intel/ElkhartlakeSiliconBinPkg/License.txt
> create mode 100644
> Silicon/Intel/ElkhartlakeSiliconBinPkg/Microcode/IntelMicrocodeLicense.txt
>
> diff --git a/Silicon/Intel/ElkhartlakeSiliconBinPkg/License.txt
> b/Silicon/Intel/ElkhartlakeSiliconBinPkg/License.txt
> new file mode 100644
> index 0000000..f5527e1
> --- /dev/null
> +++ b/Silicon/Intel/ElkhartlakeSiliconBinPkg/License.txt
> @@ -0,0 +1,30 @@
> +Copyright (c) 2020 Intel Corporation. All rights reserved.
> +
> +Redistribution and use in source and binary forms, with or without
> +modification, are permitted provided that the following conditions are
> +met:
> +
> +* Redistributions of source code must retain the above copyright
> + notice, this list of conditions and the following disclaimer.
> +* Redistributions in binary form must reproduce the above copyright
> + notice, this list of conditions and the following disclaimer in
> + the documentation and/or other materials provided with the
> + distribution.
> +
> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
> CONTRIBUTORS "AS
> +IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> LIMITED
> +TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
> +PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> COPYRIGHT
> +HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> INCIDENTAL,
> +SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
> NOT
> +LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
> USE,
> +DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
> ON ANY
> +THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
> THE USE
> +OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
> DAMAGE.
> +
> +Some files are subject to a license documented in the
> +IntelProprietaryLicense.txt file. These files are in the same directory
> +as IntelProprietaryLicense.txt, and they do not have a license
> +specified within the file.
> diff --git
> a/Silicon/Intel/ElkhartlakeSiliconBinPkg/Microcode/IntelMicrocodeLicense.tx
> t
> b/Silicon/Intel/ElkhartlakeSiliconBinPkg/Microcode/IntelMicrocodeLicense.tx
> t
> new file mode 100644
> index 0000000..ea33b61
> --- /dev/null
> +++ b/Silicon/Intel/ElkhartlakeSiliconBinPkg/Microcode/IntelMicrocodeLic
> +++ ense.txt
> @@ -0,0 +1,37 @@
> +Copyright (c) 2018 - 2020 Intel Corporation.
> +All rights reserved.
> +
> +Redistribution.
> +
> +Redistribution and use in binary form, without modification, are
> +permitted, provided that the following conditions are met:
> +
> +1. Redistributions must reproduce the above copyright notice and the
> + following disclaimer in the documentation and/or other materials
> provided
> + with the distribution.
> +
> +2. Neither the name of Intel Corporation nor the names of its suppliers may
> + be used to endorse or promote products derived from this software
> without
> + specific prior written permission.
> +
> +3. No reverse engineering, decompilation, or disassembly of this software
> + is permitted.
> +
> +
> +"Binary form" includes any format that is commonly used for electronic
> +conveyance that is a reversible, bit-exact translation of binary
> +representation to ASCII or ISO text, for example "uuencode".
> +
> +DISCLAIMER.
> +
> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
> CONTRIBUTORS "AS IS"
> +AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> LIMITED TO,
> +THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
> PARTICULAR
> +PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER
> OR
> +CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> SPECIAL,
> +EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> LIMITED TO,
> +PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA,
> OR
> +PROFITS; OR BUSINESS
> +INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
> WHETHER IN
> +CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
> OTHERWISE)
> +ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
> ADVISED OF
> +THE POSSIBILITY OF SUCH DAMAGE.
> --
> 2.28.0.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [edk2-non-osi] [PATCH] ElkhartlakeSiliconBinPkg: Add ElkhartlakeSiliconPkg
2020-10-23 8:50 [edk2-devel] [edk2-non-osi] [PATCH] ElkhartlakeSiliconBinPkg: Add ElkhartlakeSiliconPkg jinjhuli
2020-10-26 21:45 ` Nate DeSimone
2020-12-19 1:47 ` Nate DeSimone
@ 2020-12-19 1:54 ` Nate DeSimone
2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2020-12-19 1:54 UTC (permalink / raw)
To: devel@edk2.groups.io, Lim, Jin Jhu; +Cc: Kinney, Michael D, Chiu, Chasel
Pushed: https://github.com/tianocore/edk2-non-osi/commit/2148159
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of jinjhuli
> Sent: Friday, October 23, 2020 1:50 AM
> To: devel@edk2.groups.io
> Cc: Lim, Jin Jhu <jin.jhu.lim@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [edk2-devel] [edk2-non-osi] [PATCH] ElkhartlakeSiliconBinPkg: Add
> ElkhartlakeSiliconPkg
>
> Add binary package for Elkhart Lake.
>
> Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Signed-off-by: jinjhuli <jin.jhu.lim@intel.com>
> ---
> .../ElkhartlakeSiliconBinPkg/License.txt | 30 +++++++++++++++
> .../Microcode/IntelMicrocodeLicense.txt | 37 +++++++++++++++++++
> 2 files changed, 67 insertions(+)
> create mode 100644 Silicon/Intel/ElkhartlakeSiliconBinPkg/License.txt
> create mode 100644
> Silicon/Intel/ElkhartlakeSiliconBinPkg/Microcode/IntelMicrocodeLicense.txt
>
> diff --git a/Silicon/Intel/ElkhartlakeSiliconBinPkg/License.txt
> b/Silicon/Intel/ElkhartlakeSiliconBinPkg/License.txt
> new file mode 100644
> index 0000000..f5527e1
> --- /dev/null
> +++ b/Silicon/Intel/ElkhartlakeSiliconBinPkg/License.txt
> @@ -0,0 +1,30 @@
> +Copyright (c) 2020 Intel Corporation. All rights reserved.
> +
> +Redistribution and use in source and binary forms, with or without
> +modification, are permitted provided that the following conditions are
> +met:
> +
> +* Redistributions of source code must retain the above copyright
> + notice, this list of conditions and the following disclaimer.
> +* Redistributions in binary form must reproduce the above copyright
> + notice, this list of conditions and the following disclaimer in
> + the documentation and/or other materials provided with the
> + distribution.
> +
> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
> CONTRIBUTORS "AS
> +IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> LIMITED
> +TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
> +PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> COPYRIGHT
> +HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> INCIDENTAL,
> +SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
> NOT
> +LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
> USE,
> +DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
> ON ANY
> +THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
> THE USE
> +OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
> DAMAGE.
> +
> +Some files are subject to a license documented in the
> +IntelProprietaryLicense.txt file. These files are in the same directory
> +as IntelProprietaryLicense.txt, and they do not have a license
> +specified within the file.
> diff --git
> a/Silicon/Intel/ElkhartlakeSiliconBinPkg/Microcode/IntelMicrocodeLicense.tx
> t
> b/Silicon/Intel/ElkhartlakeSiliconBinPkg/Microcode/IntelMicrocodeLicense.tx
> t
> new file mode 100644
> index 0000000..ea33b61
> --- /dev/null
> +++ b/Silicon/Intel/ElkhartlakeSiliconBinPkg/Microcode/IntelMicrocodeLic
> +++ ense.txt
> @@ -0,0 +1,37 @@
> +Copyright (c) 2018 - 2020 Intel Corporation.
> +All rights reserved.
> +
> +Redistribution.
> +
> +Redistribution and use in binary form, without modification, are
> +permitted, provided that the following conditions are met:
> +
> +1. Redistributions must reproduce the above copyright notice and the
> + following disclaimer in the documentation and/or other materials
> provided
> + with the distribution.
> +
> +2. Neither the name of Intel Corporation nor the names of its suppliers may
> + be used to endorse or promote products derived from this software
> without
> + specific prior written permission.
> +
> +3. No reverse engineering, decompilation, or disassembly of this software
> + is permitted.
> +
> +
> +"Binary form" includes any format that is commonly used for electronic
> +conveyance that is a reversible, bit-exact translation of binary
> +representation to ASCII or ISO text, for example "uuencode".
> +
> +DISCLAIMER.
> +
> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
> CONTRIBUTORS "AS IS"
> +AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> LIMITED TO,
> +THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
> PARTICULAR
> +PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER
> OR
> +CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> SPECIAL,
> +EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> LIMITED TO,
> +PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA,
> OR
> +PROFITS; OR BUSINESS
> +INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
> WHETHER IN
> +CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
> OTHERWISE)
> +ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
> ADVISED OF
> +THE POSSIBILITY OF SUCH DAMAGE.
> --
> 2.28.0.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread