From: "Dov Murik" <dovmurik@linux.ibm.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: devel@edk2.groups.io, Brijesh Singh <brijesh.singh@amd.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jordan Justen <jordan.l.justen@intel.com>,
Erdem Aktas <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
Jiewen Yao <jiewen.yao@intel.com>, Min Xu <min.m.xu@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Dov Murik <dovmurik@linux.ibm.com>
Subject: Re: [PATCH 1/2] OvmfPkg/OvmfPkgX64: Add SEV launch secret and hashes table areas to MEMFD
Date: Tue, 2 Nov 2021 13:46:19 +0200 [thread overview]
Message-ID: <07819666-8465-6e46-7e07-a99b1b793073@linux.ibm.com> (raw)
In-Reply-To: <20211102100347.ulf4mt4fwjrsbaud@sirius.home.kraxel.org>
Hi Gerd,
(I assume your comments are for patch 2/2)
On 02/11/2021 12:03, Gerd Hoffmann wrote:
> On Tue, Nov 02, 2021 at 07:34:21AM +0000, Dov Murik wrote:
>> The SEV launch secret area and the QEMU hashes table area were specified
>> in the OvmfPkg/AmdSev/AmdSevX64 MEMFD but not in OvmfPkg/OvmfPkgX64.
>>
>> Add them in OvmfPkgX64.fdf.
>>
>> After this change the two MEMFD descriptions are identical:
>>
>> $ sed -n -e '/FD.MEMFD/,/FV.SECFV/p' OvmfPkg/OvmfPkgX64.fdf | sha1sum
>> 6ff89173952413fbdb7ffbbf42f8bc389c928500 -
>> $ sed -n -e '/FD.MEMFD/,/FV.SECFV/p' OvmfPkg/AmdSev/AmdSevX64.fdf | sha1sum
>> 6ff89173952413fbdb7ffbbf42f8bc389c928500 -
>
> I'm wondering whenever you actually tried to boot a sev guest
> in microvm?
>
No I haven't tried. Do you want Microvm to be able to boot SEV guests,
or do you intentionally want to keep functionality out so it stays small?
> I suspect it'll need more changes to actually work.
>
I saw MicrovmX64.fdf already has some SEV-related entries (like
PcdOvmfSecGhcbBackupBase), so I just added these so that its MEMFD will
be identical to AmdSevX64 and OvmfPkgX64.
-Dov
next prev parent reply other threads:[~2021-11-02 11:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 7:34 [PATCH 0/2] OvmgPkg: Add SEV launch secret and hashes table areas Dov Murik
2021-11-02 7:34 ` [PATCH 1/2] OvmfPkg/OvmfPkgX64: Add SEV launch secret and hashes table areas to MEMFD Dov Murik
2021-11-02 10:03 ` Gerd Hoffmann
2021-11-02 11:46 ` Dov Murik [this message]
2021-11-02 13:29 ` Gerd Hoffmann
2021-11-02 13:53 ` Dov Murik
2021-11-02 14:11 ` Lendacky, Thomas
2021-11-03 6:07 ` Gerd Hoffmann
2021-11-03 8:13 ` Dov Murik
2021-11-02 7:34 ` [PATCH 2/2] OvmfPkg/Microvm: " Dov Murik
2021-11-02 10:04 ` [PATCH 0/2] OvmgPkg: Add SEV launch secret and hashes table areas Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07819666-8465-6e46-7e07-a99b1b793073@linux.ibm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox