From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: michael.kubacki@outlook.com, devel@edk2.groups.io
Cc: Leif Lindholm <leif@nuviainc.com>
Subject: Re: [PATCH v2 1/1] ArmPkg/ArmMmuLib: Explicitly cast function pointer argument
Date: Thu, 22 Oct 2020 17:02:16 +0200 [thread overview]
Message-ID: <07aa0b94-c5c7-7e6b-2f2d-ccd85fc499bb@arm.com> (raw)
In-Reply-To: <MWHPR07MB344024796B23C985D1ED6ACBE91E0@MWHPR07MB3440.namprd07.prod.outlook.com>
On 10/20/20 12:12 AM, michael.kubacki@outlook.com wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> The function ArmReplaceLiveTranslationEntry () is passed as a VOID
> pointer to WriteBackDataCacheRange (). This produces the following
> warning on VS2019:
>
> warning C4152: nonstandard extension, function/data pointer
> conversion in expression
>
> This change explicitly casts the argument to the formal parameter
> type VOID*.
>
> This can be reproduced with the following build command:
> build -b DEBUG -a AARCH64 -t VS2019 -p ArmPkg/ArmPkg.dsc
> -m ArmPkg/Library/ArmMmuLib/ArmMmuPeiLib.inf
>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Thanks Michael
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
But please, in the future, don't put spaces after () casts.
I have pushed this patch and '[PATCH v1 1/1] ArmPkg/ArmMmuLib:
Explicitly cast UINT32 data conversions' as #1042.
Thanks,
> ---
>
> Notes:
> V2 changes:
>
> 1. Added a cast to UINTN prior to casting to VOID*.
>
> This also makes the change consistent with a very similar change
> in commit 654dc3ed852a.
>
> ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuPeiLibConstructor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuPeiLibConstructor.c b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuPeiLibConstructor.c
> index 80317923cfa4..5f259d216420 100644
> --- a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuPeiLibConstructor.c
> +++ b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuPeiLibConstructor.c
> @@ -47,7 +47,7 @@ ArmMmuPeiLibConstructor (
> // The ArmReplaceLiveTranslationEntry () helper function may be invoked
> // with the MMU off so we have to ensure that it gets cleaned to the PoC
> //
> - WriteBackDataCacheRange (ArmReplaceLiveTranslationEntry,
> + WriteBackDataCacheRange ((VOID *) (UINTN) ArmReplaceLiveTranslationEntry,
> ArmReplaceLiveTranslationEntrySize);
> }
>
>
prev parent reply other threads:[~2020-10-22 15:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 22:12 [PATCH v2 1/1] ArmPkg/ArmMmuLib: Explicitly cast function pointer argument Michael Kubacki
2020-10-22 15:02 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07aa0b94-c5c7-7e6b-2f2d-ccd85fc499bb@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox