Re: [edk2-devel] [PATCH v6 26/36] OvmfPkg/LoongArchVirt: Add a NULL library named CollectApResouceLibNull

["maobibo" <maobibo@loongson.cn>]

On 2024/1/5 下午5:45, Chao Li wrote:
> This Library is used to collect APs resources, but is currently NULL
> for OvmfPkg, because it is not used by the LoongArch virtual machine.
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Bibo Mao <maobibo@loongson.cn>
> Cc: Dongyan Qian <qiandongyan@loongson.cn>
> Signed-off-by: Chao Li <lichao@loongson.cn>
> ---
>   .../CollectApResourceLibNull.c                | 38 +++++++++++++++++++
>   .../CollectApResourceLibNull.inf              | 31 +++++++++++++++
>   .../CollectApResourceLibNull.uni              |  9 +++++
>   3 files changed, 78 insertions(+)
>   create mode 100644 OvmfPkg/LoongArchVirt/Library/CollectApResouceLibNull/CollectApResourceLibNull.c
>   create mode 100644 OvmfPkg/LoongArchVirt/Library/CollectApResouceLibNull/CollectApResourceLibNull.inf
>   create mode 100644 OvmfPkg/LoongArchVirt/Library/CollectApResouceLibNull/CollectApResourceLibNull.uni
> 
> diff --git a/OvmfPkg/LoongArchVirt/Library/CollectApResouceLibNull/CollectApResourceLibNull.c b/OvmfPkg/LoongArchVirt/Library/CollectApResouceLibNull/CollectApResourceLibNull.c
> new file mode 100644
> index 0000000000..19995c1193
> --- /dev/null
> +++ b/OvmfPkg/LoongArchVirt/Library/CollectApResouceLibNull/CollectApResourceLibNull.c
> @@ -0,0 +1,38 @@
> +/** @file
> +  LoongArch64 CPU Collect AP resource NULL Library functions.
> +
> +  Copyright (c) 2024, Loongson Technology Corporation Limited. All rights reserved.<BR>
> +
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#include <PiPei.h>
> +#include <Library/BaseLib.h>
> +#include <Library/HobLib.h>
> +#include <Library/MemoryAllocationLib.h>
> +#include <Register/LoongArch64/Csr.h>
> +#include "../../../UefiCpuPkg/Library/LoongArch64MpInitLib/MpLib.h"
The included path is a little strange, should we put 
CollectApResouceLibNull library in ovmf package or 
UefiCpuPkg/Library/LoongArch64MpInitLib package?

Regards
Bibo Mao

> +
> +VOID
> +SaveProcessorResourceData (
> +  IN PROCESSOR_RESOURCE_DATA *
> +  );
> +
> +VOID
> +EFIAPI
> +SaveProcessorResource (
> +  PROCESSOR_RESOURCE_DATA  *mProcessorResource
> +  )
> +{
> +  SaveProcessorResourceData (mProcessorResource);
> +}
> +
> +VOID
> +EFIAPI
> +CollectAllProcessorResource (
> +  VOID
> +  )
> +{
> +  return;
> +}
> diff --git a/OvmfPkg/LoongArchVirt/Library/CollectApResouceLibNull/CollectApResourceLibNull.inf b/OvmfPkg/LoongArchVirt/Library/CollectApResouceLibNull/CollectApResourceLibNull.inf
> new file mode 100644
> index 0000000000..c166df6bbd
> --- /dev/null
> +++ b/OvmfPkg/LoongArchVirt/Library/CollectApResouceLibNull/CollectApResourceLibNull.inf
> @@ -0,0 +1,31 @@
> +## @file
> +#  LoongArch64 CPU Collect AP resource NULL Library.
> +#
> +#  Copyright (c) 2024, Loongson Technology Corporation Limited. All rights reserved.<BR>
> +#  SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +##
> +
> +[Defines]
> +  INF_VERSION                    = 1.29
> +  BASE_NAME                      = CollectApResourceLibNull
> +  MODULE_UNI_FILE                = CollectApResourceLibNull.uni
> +  FILE_GUID                      = 8C3B54BF-6A9F-E8B4-4D57-67B3AB578DD6
> +  MODULE_TYPE                    = PEIM
> +  VERSION_STRING                 = 1.1
> +  LIBRARY_CLASS                  = PEIM
> +
> +[Sources.common]
> +  CollectApResourceLibNull.c
> +
> +[Packages]
> +  MdePkg/MdePkg.dec
> +  UefiCpuPkg/UefiCpuPkg.dec
> +
> +[LibraryClasses]
> +  BaseLib
> +  HobLib
> +  MemoryAllocationLib
> +
> +[Pcd]
> +  gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber
> diff --git a/OvmfPkg/LoongArchVirt/Library/CollectApResouceLibNull/CollectApResourceLibNull.uni b/OvmfPkg/LoongArchVirt/Library/CollectApResouceLibNull/CollectApResourceLibNull.uni
> new file mode 100644
> index 0000000000..d1638ab11e
> --- /dev/null
> +++ b/OvmfPkg/LoongArchVirt/Library/CollectApResouceLibNull/CollectApResourceLibNull.uni
> @@ -0,0 +1,9 @@
> +// @file
> +//  LoongArch64 CPU Collect AP resource NULL Library.
> +//
> +//  Copyright (c) 2024, Loongson Technology Corporation Limited. All rights reserved.<BR>
> +//  SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +#string STR_MODULE_ABSTRACT             #language en-US "CPU Collect AP resource NULL Library."
> +
> +#string STR_MODULE_DESCRIPTION          #language en-US "CPU Collect AP resource NULL Library."
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113499): https://edk2.groups.io/g/devel/message/113499
Mute This Topic: https://groups.io/mt/103540125/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-