From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=210.71.195.44; helo=out01.hibox.biz; envelope-from=tim.lewis@insyde.com; receiver=edk2-devel@lists.01.org Received: from out01.hibox.biz (out04.hibox.biz [210.71.195.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 32B1E2194D3AE for ; Fri, 5 Oct 2018 05:20:04 -0700 (PDT) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2AIAACSU7db/ws0GKxkGgEBAQEBAgEBA?= =?us-ascii?q?QEHAgEBAQGBUQUBAQEBCwGCBWZtEiiMCY4wgy+KFYkagXoNGAsIAYRAAoQqITQ?= =?us-ascii?q?NDQEDAQECAQECbRwMhTkBAQEBAwEBBgIwJBALDAEDAgYDDQEDBAEBAS4ZDgEnC?= =?us-ascii?q?AIEARILBQSDDoIEDKUoGgKJcwWCe4oOP4QkgxsBBIcUIgKOXTKOUwcCAoIMAYQ?= =?us-ascii?q?9hXGECReBTIdgAw+GNoweiUiBQjiBVXBQgmw/iliFXh8wgQ4IDAGNKQEB?= X-IronPort-AV: E=Sophos;i="5.54,344,1534780800"; d="scan'208";a="27189030" Received: from unknown (HELO hb3-BKT201.hibox.biz) ([172.24.52.11]) by out01.hibox.biz with ESMTP; 05 Oct 2018 20:20:01 +0800 Received: from unknown (HELO hb3-BKT101.hibox.biz) ([172.24.51.11]) by hb3-BKT201.hibox.biz with ESMTP; 05 Oct 2018 20:20:00 +0800 Received: from unknown (HELO hb3-IN03.hibox.biz) ([172.24.12.13]) by hb3-BKT101.hibox.biz with ESMTP; 05 Oct 2018 20:20:01 +0800 X-Remote-IP: 12.203.200.220 X-Remote-Host: No hostname X-SBRS: None X-MID: 17087326 X-Auth-ID: tim.lewis@insyde.com X-EnvelopeFrom: tim.lewis@insyde.com hiBox-Sender: 1 Received: from unknown (HELO TIMSLAPTOP) ([12.203.200.220]) by hb3-IN03.hibox.biz with ESMTP/TLS/AES256-SHA; 05 Oct 2018 20:19:59 +0800 From: "Tim Lewis" To: "'Laszlo Ersek'" , "'Carsey, Jaben'" , "'Andrew Fish'" Cc: References: In-Reply-To: Date: Fri, 5 Oct 2018 05:19:53 -0700 Message-ID: <07e201d45ca5$bb0456d0$310d0470$@insyde.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-index: AQG+ifsKWSO1i6tmgd/R1xxKSMJpmQJximT7AUu9df8CejZ2OwMAe7QLAaxcUDek5RSP8A== Subject: Re: [PATCH] ShellPkg: Create a homefilesystem environment variable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2018 12:20:06 -0000 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-language: en-us Jaben -- Following on this: shouldn't this be a spec issue? If you are asking people to depend on the behavior. Thanks, Tim -----Original Message----- From: edk2-devel On Behalf Of Laszlo Ersek Sent: Friday, October 5, 2018 4:33 AM To: Carsey, Jaben ; Andrew Fish Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable On 10/04/18 22:54, Carsey, Jaben wrote: > Laszlo, > > The leading "_" was required for out of spec, but built in, commands. The spec has no restrictions on environment variables except some have special meaning and may be read only. > > I can certainly work on slowing down the process. I have been complaining about that same thing and should have been more aware. I would like to have a community minimum amount of time before commits are done that we all agree to. Something like 1 full day would be nice I think. Good idea! I believe 24 hours should be tolerable on all ends. It also gives a chance to people in other time zones to comment. I think there should be one exception: grave regressions -- build failures, or total boot failures -- should be possible to revert (or fix) as soon as there's one review. Thanks! Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel