public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>,
	edk2-devel-01 <edk2-devel@lists.01.org>
Cc: "Dong, Eric" <eric.dong@intel.com>, "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error
Date: Tue, 12 Dec 2017 14:10:23 +0100	[thread overview]
Message-ID: <07e8b107-57b2-e5ba-5a79-50a4d0b6c354@redhat.com> (raw)
In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503AA43F8D@shsmsx102.ccr.corp.intel.com>

On 12/12/17 13:54, Yao, Jiewen wrote:
> Thanks ,Laszlo.
> Reviewed-by: Jiewen.yao@intel.com

Thanks!

> Since it breaks the build, can we check in as soon as possible?

Sure; commit dfc5a4dec602.

Thanks!
Laszlo

>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo
>> Ersek
>> Sent: Tuesday, December 12, 2017 8:47 PM
>> To: edk2-devel-01 <edk2-devel@lists.01.org>
>> Cc: Dong, Eric <eric.dong@intel.com>; Zeng, Star <star.zeng@intel.com>
>> Subject: [edk2] [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error
>>
>>> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c: In function
>>> 'SmmReadyToBootHandler':
>>> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c:323:14: error: passing
>> argument
>>> 3 of 'SmmLocateProtocol' from incompatible pointer type [-Werror]
>>>               );
>>>               ^
>>> In file included from MdeModulePkg/Core/PiSmmCore/PiSmmCore.c:15:0:
>>> MdeModulePkg/Core/PiSmmCore/PiSmmCore.h:586:1: note: expected 'void
>> **'
>>> but argument is of type 'struct EFI_SMM_SX_DISPATCH2_PROTOCOL **'
>>>  SmmLocateProtocol (
>>>  ^
>>> cc1: all warnings being treated as errors
>>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Cc: Star Zeng <star.zeng@intel.com>
>> Fixes: 7b9b55b2ef7be13608605dc58a54b9ca04be4e40
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>  MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
>> b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
>> index dbb89932e75b..1ccb9c7787ad 100644
>> --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
>> +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
>> @@ -319,7 +319,7 @@ SmmReadyToBootHandler (
>>    Status = SmmLocateProtocol (
>>               &gEfiSmmSxDispatch2ProtocolGuid,
>>               NULL,
>> -             &SxDispatch
>> +             (VOID **)&SxDispatch
>>               );
>>    if (!EFI_ERROR (Status)) {
>>      //
>> --
>> 2.14.1.3.gb7cf6e02401b
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel



  reply	other threads:[~2017-12-12 13:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-12 12:46 [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error Laszlo Ersek
2017-12-12 12:54 ` Yao, Jiewen
2017-12-12 13:10   ` Laszlo Ersek [this message]
2017-12-13  0:35     ` Zeng, Star

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07e8b107-57b2-e5ba-5a79-50a4d0b6c354@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox