From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6C55321A1099A for ; Tue, 12 Dec 2017 05:05:47 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B2BF325C20; Tue, 12 Dec 2017 13:10:25 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-105.rdu2.redhat.com [10.10.120.105]) by smtp.corp.redhat.com (Postfix) with ESMTP id A39A16266F; Tue, 12 Dec 2017 13:10:24 +0000 (UTC) To: "Yao, Jiewen" , edk2-devel-01 Cc: "Dong, Eric" , "Zeng, Star" References: <20171212124630.7637-1-lersek@redhat.com> <74D8A39837DF1E4DA445A8C0B3885C503AA43F8D@shsmsx102.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <07e8b107-57b2-e5ba-5a79-50a4d0b6c354@redhat.com> Date: Tue, 12 Dec 2017 14:10:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503AA43F8D@shsmsx102.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 12 Dec 2017 13:10:25 +0000 (UTC) Subject: Re: [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 13:05:47 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/12/17 13:54, Yao, Jiewen wrote: > Thanks ,Laszlo. > Reviewed-by: Jiewen.yao@intel.com Thanks! > Since it breaks the build, can we check in as soon as possible? Sure; commit dfc5a4dec602. Thanks! Laszlo >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo >> Ersek >> Sent: Tuesday, December 12, 2017 8:47 PM >> To: edk2-devel-01 >> Cc: Dong, Eric ; Zeng, Star >> Subject: [edk2] [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error >> >>> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c: In function >>> 'SmmReadyToBootHandler': >>> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c:323:14: error: passing >> argument >>> 3 of 'SmmLocateProtocol' from incompatible pointer type [-Werror] >>> ); >>> ^ >>> In file included from MdeModulePkg/Core/PiSmmCore/PiSmmCore.c:15:0: >>> MdeModulePkg/Core/PiSmmCore/PiSmmCore.h:586:1: note: expected 'void >> **' >>> but argument is of type 'struct EFI_SMM_SX_DISPATCH2_PROTOCOL **' >>> SmmLocateProtocol ( >>> ^ >>> cc1: all warnings being treated as errors >> >> Cc: Eric Dong >> Cc: Star Zeng >> Fixes: 7b9b55b2ef7be13608605dc58a54b9ca04be4e40 >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Laszlo Ersek >> --- >> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> index dbb89932e75b..1ccb9c7787ad 100644 >> --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> @@ -319,7 +319,7 @@ SmmReadyToBootHandler ( >> Status = SmmLocateProtocol ( >> &gEfiSmmSxDispatch2ProtocolGuid, >> NULL, >> - &SxDispatch >> + (VOID **)&SxDispatch >> ); >> if (!EFI_ERROR (Status)) { >> // >> -- >> 2.14.1.3.gb7cf6e02401b >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel