From: "Liming Gao" <liming.gao@intel.com>
To: "Liu, Zhiguang" <zhiguang.liu@intel.com>,
"Zurcher, Christopher J" <christopher.j.zurcher@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [PATCH v2 1/1] MdePkg/UefiScsiLib: Set FUA bit for synchronous SCSI Write operations
Date: Mon, 30 Mar 2020 13:51:14 +0000 [thread overview]
Message-ID: <07f70d5a0ea8442eb776b37aed9f359b@intel.com> (raw)
In-Reply-To: <a2518c6f8355408b98e63521711a1e61@intel.com>
Zurcher:
What functionality test has been done for this test?
Thanks
Liming
> -----Original Message-----
> From: Liu, Zhiguang <zhiguang.liu@intel.com>
> Sent: Monday, March 30, 2020 9:52 AM
> To: Zurcher, Christopher J <christopher.j.zurcher@intel.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: RE: [PATCH v2 1/1] MdePkg/UefiScsiLib: Set FUA bit for synchronous SCSI Write operations
>
> Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
>
> > -----Original Message-----
> > From: Zurcher, Christopher J
> > Sent: Thursday, March 26, 2020 3:34 PM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Wang, Jian J
> > <jian.j.wang@intel.com>; Gao, Liming <liming.gao@intel.com>; Liu, Zhiguang
> > <zhiguang.liu@intel.com>
> > Subject: [PATCH v2 1/1] MdePkg/UefiScsiLib: Set FUA bit for synchronous
> > SCSI Write operations
> >
> > The FUA (Force Unit Access) bit forces data to be written directly to
> > disk instead of the write cache. This prevents data from being lost if a
> > shutdown or reset is requested immediately after a SCSI write operation.
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Signed-off-by: Christopher J Zurcher <christopher.j.zurcher@intel.com>
> > ---
> > MdePkg/Include/IndustryStandard/Scsi.h | 8 +++++++-
> > MdePkg/Library/UefiScsiLib/UefiScsiLib.c | 14 ++++++++------
> > 2 files changed, 15 insertions(+), 7 deletions(-)
> >
> > diff --git a/MdePkg/Include/IndustryStandard/Scsi.h
> > b/MdePkg/Include/IndustryStandard/Scsi.h
> > index 3e966520a1..64b9918b82 100644
> > --- a/MdePkg/Include/IndustryStandard/Scsi.h
> > +++ b/MdePkg/Include/IndustryStandard/Scsi.h
> > @@ -1,7 +1,7 @@
> > /** @file
> > Support for SCSI-2 standard
> >
> > - Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
> > + Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.<BR>
> > SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > **/
> > @@ -175,6 +175,12 @@
> > #define EFI_SCSI_DATA_IN 0
> > #define EFI_SCSI_DATA_OUT 1
> >
> > +//
> > +// SCSI Block Command Cache Control Parameters
> > +//
> > +#define EFI_SCSI_BLOCK_FUA BIT3 ///< Force Unit Access
> > +#define EFI_SCSI_BLOCK_DPO BIT4 ///< Disable Page Out
> > +
> > //
> > // Peripheral Device Type Definitions
> > //
> > diff --git a/MdePkg/Library/UefiScsiLib/UefiScsiLib.c
> > b/MdePkg/Library/UefiScsiLib/UefiScsiLib.c
> > index 13a2a1912c..512bec500c 100644
> > --- a/MdePkg/Library/UefiScsiLib/UefiScsiLib.c
> > +++ b/MdePkg/Library/UefiScsiLib/UefiScsiLib.c
> > @@ -1,7 +1,7 @@
> > /** @file
> > UEFI SCSI Library implementation
> >
> > - Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
> > + Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.<BR>
> > SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > **/
> > @@ -1055,15 +1055,16 @@ ScsiWrite10Command (
> > ZeroMem (&CommandPacket, sizeof
> > (EFI_SCSI_IO_SCSI_REQUEST_PACKET));
> > ZeroMem (Cdb, EFI_SCSI_OP_LENGTH_TEN);
> >
> > - CommandPacket.Timeout = Timeout;
> > - CommandPacket.OutDataBuffer = DataBuffer;
> > - CommandPacket.SenseData = SenseData;
> > - CommandPacket.OutTransferLength= *DataLength;
> > - CommandPacket.Cdb = Cdb;
> > + CommandPacket.Timeout = Timeout;
> > + CommandPacket.OutDataBuffer = DataBuffer;
> > + CommandPacket.SenseData = SenseData;
> > + CommandPacket.OutTransferLength = *DataLength;
> > + CommandPacket.Cdb = Cdb;
> > //
> > // Fill Cdb for Write (10) Command
> > //
> > Cdb[0] = EFI_SCSI_OP_WRITE10;
> > + Cdb[1] = EFI_SCSI_BLOCK_FUA;
> > WriteUnaligned32 ((UINT32 *)&Cdb[2], SwapBytes32 (StartLba));
> > WriteUnaligned16 ((UINT16 *)&Cdb[7], SwapBytes16 ((UINT16)
> > SectorSize));
> >
> > @@ -1263,6 +1264,7 @@ ScsiWrite16Command (
> > // Fill Cdb for Write (16) Command
> > //
> > Cdb[0] = EFI_SCSI_OP_WRITE16;
> > + Cdb[1] = EFI_SCSI_BLOCK_FUA;
> > WriteUnaligned64 ((UINT64 *)&Cdb[2], SwapBytes64 (StartLba));
> > WriteUnaligned32 ((UINT32 *)&Cdb[10], SwapBytes32 (SectorSize));
> >
> > --
> > 2.16.2.windows.1
next prev parent reply other threads:[~2020-03-30 13:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 7:34 [PATCH v2 0/1] UefiScsiLib: Set FUA bit for synchronous SCSI Write operations Zurcher, Christopher J
2020-03-26 7:34 ` [PATCH v2 1/1] MdePkg/UefiScsiLib: " Zurcher, Christopher J
2020-03-30 1:52 ` Zhiguang Liu
2020-03-30 13:51 ` Liming Gao [this message]
2020-03-30 20:34 ` Zurcher, Christopher J
2020-04-14 15:53 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07f70d5a0ea8442eb776b37aed9f359b@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox