From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web12.9161.1606998394965403405
 for <devel@edk2.groups.io>;
 Thu, 03 Dec 2020 04:26:35 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ddv1z0EQ;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1606998394;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=GZ0kUadkcAA6V6Ojl/XNrrxKkZaX+MFyoLSspRl8Y7c=;
	b=ddv1z0EQkYKKtUwlsuuHfP1vniefZ9r66U1J4UKVaK5Cf6e+z/p38Nbf5ORtqSxfCE59mu
	ECad2errqUe6mj7WCPjoQPsCOz2gqZ3rZhFTe5i/ZI3Wv9khVVXRy1hYplRC+FF37amKgi
	ftJ/AOLMeqtXTVAHnpFluLTU9n6mkjQ=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-223-TKiEf3TnN2O7nqi-iq5mIg-1; Thu, 03 Dec 2020 07:26:30 -0500
X-MC-Unique: TKiEf3TnN2O7nqi-iq5mIg-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D7F4C1074645;
	Thu,  3 Dec 2020 12:26:28 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-182.ams2.redhat.com [10.36.113.182])
	by smtp.corp.redhat.com (Postfix) with ESMTP id A9FDB19C46;
	Thu,  3 Dec 2020 12:26:25 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH v3 0/6] SEV Encrypted Boot for Ovmf
To: devel@edk2.groups.io, jejb@linux.ibm.com
Cc: dovmurik@linux.vnet.ibm.com, Dov.Murik1@il.ibm.com, ashish.kalra@amd.com,
 brijesh.singh@amd.com, tobin@ibm.com, david.kaplan@amd.com,
 jon.grimm@amd.com, thomas.lendacky@amd.com, frankeh@us.ibm.com,
 "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
 Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@arm.com>
References: <20201130202819.3910-1-jejb@linux.ibm.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <0805f171-b5c2-a556-3e64-c700aaf06d85@redhat.com>
Date: Thu, 3 Dec 2020 13:26:24 +0100
MIME-Version: 1.0
In-Reply-To: <20201130202819.3910-1-jejb@linux.ibm.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi James,

On 11/30/20 21:28, James Bottomley wrote:
> v3:
> 
> - More grub and boot stripping (I think I got everything out, but
>   there may be something that strayed in the boot panic resolution).
> - grub.sh tidy up with tabs->spaces.
> - Move the reset vector GUIDisation patch to the front so it can be
>   applied independently
> - Update the .dsc and .fdf files for variable policy

In preparation for submitting the github PR for merging this series, I
first ran PatchCheck.py locally.

It doesn't like that I converted "OvmfPkg/AmdSev/Grub/grub.cfg" to LF,
in addition to "OvmfPkg/AmdSev/Grub/grub.sh".

PatchCheck.py recognizes the ".sh" suffix, so it's not complaining about
"OvmfPkg/AmdSev/Grub/grub.sh". But, the config file is a problem.

Can you please confirm that grub works fine if the config file has CRLF
line terminators? Because then I'll just convert the config file back to
CRLF, and merge the series.

Otherwise, we'll need a patch for "BaseTools/Scripts/PatchCheck.py", to
treat "grub.cfg" as another exception.

Thanks!
Laszlo