public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, edk2-devel@lists.01.org
Subject: Re: [PATCH 0/2] Clear frame pointer in startup code on AARCH64 systems
Date: Mon, 19 Nov 2018 19:53:34 +0100	[thread overview]
Message-ID: <0814ad34-c45e-4990-1529-fb6a293440c5@redhat.com> (raw)
In-Reply-To: <20181116225558.27720-1-ard.biesheuvel@linaro.org>

On 11/16/18 23:55, Ard Biesheuvel wrote:
> The backtrace code on AARCH64 does not sanitize the frame pointer values
> it pulls of the stack when attempting to do a backtrace, and so junk left
> in the frame pointer register may result in a recursive exception and a
> truncated backtrace.
> 
> Ard Biesheuvel (2):
>   ArmPlatformPkg: clear frame pointer in startup code
>   ArmVirtPkg/PrePi: clear frame pointer in startup code
> 
>  ArmPlatformPkg/PrePeiCore/AArch64/PrePeiCoreEntryPoint.S | 3 +++
>  ArmPlatformPkg/PrePi/AArch64/ModuleEntryPoint.S          | 3 +++
>  ArmVirtPkg/PrePi/AArch64/ModuleEntryPoint.S              | 3 +++
>  3 files changed, 9 insertions(+)
> 

Acked-by: Laszlo Ersek <lersek@redhat.com>



  parent reply	other threads:[~2018-11-19 18:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-16 22:55 [PATCH 0/2] Clear frame pointer in startup code on AARCH64 systems Ard Biesheuvel
2018-11-16 22:55 ` [PATCH 1/2] ArmPlatformPkg: clear frame pointer in startup code Ard Biesheuvel
2018-11-16 22:55 ` [PATCH 2/2] ArmVirtPkg/PrePi: " Ard Biesheuvel
2018-11-19 18:53 ` Laszlo Ersek [this message]
2018-11-19 18:56 ` [PATCH 0/2] Clear frame pointer in startup code on AARCH64 systems Leif Lindholm
2018-11-19 19:28   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0814ad34-c45e-4990-1529-fb6a293440c5@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox