From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A43E021193068 for ; Mon, 19 Nov 2018 10:53:48 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 258272D80F; Mon, 19 Nov 2018 18:53:48 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-188.rdu2.redhat.com [10.10.120.188]) by smtp.corp.redhat.com (Postfix) with ESMTP id 112E3648A9; Mon, 19 Nov 2018 18:53:43 +0000 (UTC) To: Ard Biesheuvel , edk2-devel@lists.01.org References: <20181116225558.27720-1-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: <0814ad34-c45e-4990-1529-fb6a293440c5@redhat.com> Date: Mon, 19 Nov 2018 19:53:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181116225558.27720-1-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 19 Nov 2018 18:53:48 +0000 (UTC) Subject: Re: [PATCH 0/2] Clear frame pointer in startup code on AARCH64 systems X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Nov 2018 18:53:49 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/16/18 23:55, Ard Biesheuvel wrote: > The backtrace code on AARCH64 does not sanitize the frame pointer values > it pulls of the stack when attempting to do a backtrace, and so junk left > in the frame pointer register may result in a recursive exception and a > truncated backtrace. > > Ard Biesheuvel (2): > ArmPlatformPkg: clear frame pointer in startup code > ArmVirtPkg/PrePi: clear frame pointer in startup code > > ArmPlatformPkg/PrePeiCore/AArch64/PrePeiCoreEntryPoint.S | 3 +++ > ArmPlatformPkg/PrePi/AArch64/ModuleEntryPoint.S | 3 +++ > ArmVirtPkg/PrePi/AArch64/ModuleEntryPoint.S | 3 +++ > 3 files changed, 9 insertions(+) > Acked-by: Laszlo Ersek