From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web08.8321.1611318754520471321 for ; Fri, 22 Jan 2021 04:32:34 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gOCt1cTh; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611318753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U6j7wxHwIfpniQQj8L/4JKGBTH1JSKSP8UnRumVem80=; b=gOCt1cTh7EEZBfcYyjmb+ysEqgXRd1FYiQEh5OGoPKF9pcPZGbIK7aNBwiEib0BTQOzQBu weYrvpPGdQXtGU3PlFcPdjj6QyGSngoijyp1mM9t6pibeZ1I1RMebZFI1/3fNkcpRP5Ioz U8d1v4RzFMbRZB1Bwqw1q1qApmLbdAY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-586-_8wKxZvPN4SsouUwG1ZZ_w-1; Fri, 22 Jan 2021 07:32:30 -0500 X-MC-Unique: _8wKxZvPN4SsouUwG1ZZ_w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 34120801817; Fri, 22 Jan 2021 12:32:29 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-163.ams2.redhat.com [10.36.113.163]) by smtp.corp.redhat.com (Postfix) with ESMTP id 03F4D646DC; Fri, 22 Jan 2021 12:32:27 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm To: Kun Qin , "Ni, Ray" , "devel@edk2.groups.io" Cc: "Dong, Eric" , "Kumar, Rahul1" References: <20210114223637.2737-1-kun.q@outlook.com> From: "Laszlo Ersek" Message-ID: <08182c99-4b20-1ccb-aa1c-20d49ef899e2@redhat.com> Date: Fri, 22 Jan 2021 13:32:27 +0100 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi On 01/22/21 05:40, Kun Qin wrote: > Hi Ray, > > I was suggested not to rename the file for review easiness and git history concern during v2 patch. Thread here: Re: [PATCH v2 15/16] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm (groups.io) I think you misunderstood my v2 comments. I requested that we please separate the renaming of *variables* to dediacted patches. And, this referred primarily to the gSmst --> gMmst replacement. I didn't even *intend* to comment on the renaming of *files*, as far as I can tell. Renaming the *files*, as Ray suggests, seems reasonable. And if you can split those actions to yet another patch, that's best. Thanks Laszlo > > Please let me know if you still recommend renaming the files. If so, would you suggest ```CpuIo2Smm.c/h --> CpuIo2Mm.c/h # remove the "S"``` to be a separate patch between gSmst change and adding Standalone MM instance? > > Thanks in advance. > > Regards, > Kun > > From: Ni, Ray > Sent: Thursday, January 21, 2021 20:17 > To: devel@edk2.groups.io; kun.q@outlook.com > Cc: Dong, Eric; Laszlo Ersek; Kumar, Rahul1 > Subject: RE: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm > >> >> UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.c | 9 ++---- >> UefiCpuPkg/CpuIo2Smm/CpuIo2StandaloneMm.c | 32 ++++++++++++++++++++ >> UefiCpuPkg/CpuIo2Smm/CpuIo2TraditionalMm.c | 32 ++++++++++++++++++++ >> UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.h | 12 ++++++++ >> UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf | 3 +- >> UefiCpuPkg/CpuIo2Smm/{CpuIo2Smm.inf => CpuIo2StandaloneMm.inf} | 18 +++++------ >> UefiCpuPkg/UefiCpuPkg.dsc | 5 +++ > > > How about do the file name change as below? > CpuIo2Smm.c/h --> CpuIo2Mm.c/h # remove the "S" > CpuIo2TraditionalMm.c -> CpuIo2Smm.c # Traditional MM equals to SMM. It also matches to CpuIo2Smm.inf. > CpuIo2StandaloneMm.c/inf # looks good to me. > > >