From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in22.apple.com (mail-out22.apple.com [17.171.2.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 11C8F21AE30CC for ; Mon, 12 Jun 2017 09:02:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1497283399; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-transfer-encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5QHSnX3W+SYzHLvDIsUuzh/qhllhqvCWdXxW7/Qsh1I=; b=xWstjl19JWjt2rm0QUGD7LNMB+b0D/ghunxX8XbHgQTI0Yl5Q0Bg2oSe6W+rgLr7 qz/fPVllyA+l2ETRt368MpTGAuCB0l7l1WUM9FDYTiE/ycg8xilFrZjRGIh9mjL6 nNNnrkTJAfLPa7OlJL/kN8FcHERi9QPBjSx83xdT7Sl3MVAruvKRUF5crJaEVVfY Hq41c1+ZvC2OdNlhVDRxniy9ycLEuBUREZo2fXiH8JjSNW7J7ZXYlQ14vhN6V/hi bvajhqnnQuY3tPdXfbB67vwuh/Mzh0peAUuXVSlMjxIaEVg4Zkt/Gzcno/pSs/IV M0o6rK134dGG1C19y8azDQ==; Received: from relay5.apple.com (relay5.apple.com [17.128.113.88]) (using TLS with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail-in22.apple.com (Apple Secure Mail Relay) with SMTP id 6A.4F.02740.64BBE395; Mon, 12 Jun 2017 09:03:19 -0700 (PDT) X-AuditID: 11ab0216-c25ff70000000ab4-a7-593ebb464a3d Received: from nwk-mmpp-sz12.apple.com (nwk-mmpp-sz12.apple.com [17.128.115.204]) by relay5.apple.com (Apple SCV relay) with SMTP id 03.FC.02326.54BBE395; Mon, 12 Jun 2017 09:03:18 -0700 (PDT) MIME-version: 1.0 Received: from [17.153.44.113] (unknown [17.153.44.113]) by nwk-mmpp-sz12.apple.com (Oracle Communications Messaging Server 8.0.1.2.20170210 64bit (built Feb 10 2017)) with ESMTPSA id <0ORF00JEGZ8O3L60@nwk-mmpp-sz12.apple.com>; Mon, 12 Jun 2017 09:03:17 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish In-reply-to: <20170612155315.GK26676@bivouac.eciton.net> Date: Mon, 12 Jun 2017 09:03:18 -0700 Cc: Jun Nie , jason.liu@linaro.org, edk2-devel@lists.01.org, shawn.guo@linaro.org, haojian.zhuang@linaro.org, ard.biesheuvel@linaro.org Message-id: <082EA522-E46C-43AB-90F3-F9B1DB936C34@apple.com> References: <1497232768-8993-1-git-send-email-jun.nie@linaro.org> <20170612155315.GK26676@bivouac.eciton.net> To: Leif Lindholm X-Mailer: Apple Mail (2.3273) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrILMWRmVeSWpSXmKPExsUi2FAYoeu+2y7SYN8jDYv/H3YzWuw5dJTZ 4vK5w4wW749eYbRY8uQhu8Wn3XtYLJ6uW8LswO5x59oeNo/u2f9YApiiuGxSUnMyy1KL9O0S uDLmLjAvmMBd8XPNVOYGxj0cXYycHBICJhJzN69g62Lk4hASWMMksej/DhaYxKyG7UwQiUOM EnNXNjGCJHgFBCV+TL4HVMTBwSwgL3HwvCxImFlAS+L7o1YWiPqJTBIb5jWDDRIWEJd4d2YT M4TtJ3G6/y4biM0moCyxYv4H9i5Gdg5OAQuJH+kgURYBVYk5S5YxQ4yczygx52cmxFYbiRvf 7oJNFBLIl/j8dRrYNSICOhKnv/5jhjhZVuLW7EtQ9hk2iXUnUyYwCs9CcvQshKNnITl6ASPz Kkbh3MTMHN3MPCMjvcSCgpxUveT83E2MoDhYzSS2g/Hea8NDjAIcjEo8vAxT7SKFWBPLiitz DzFKc7AoifMW21pHCgmkJ5akZqemFqQWxReV5qQWH2Jk4uCUamB0LJP7qyn4c5aSy605ebvY Fn5/NoOp652p5tyM8CkXhPZq2r666v6Rrdj6pP+1rO4pK4rOsxc52YbJCVjYGDo8v1xuFGSh L/l2rzrDvEpR4fs66t0TE12ZK2sux531UOrnk5JlyLv4TXgVs1Dowa1NB/rrnrj9Va66lVpo dMn94BXJ2xn9nkosxRmJhlrMRcWJAACI1BVkAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMIsWRmVeSWpSXmKPExsUi2FB8Rtdtt12kwY0Ofov/H3YzWuw5dJTZ 4vK5w4wW749eYbRY8uQhu8Wn3XtYLJ6uW8LswO5x59oeNo/u2f9YApiiuGxSUnMyy1KL9O0S uDLmLjAvmMBd8XPNVOYGxj0cXYycHBICJhKzGrYzdTFycQgJHGKUmLuyiREkwSsgKPFj8j2W LkYODmYBeYmD52VBwswCWhLfH7WyQNRPZJLYMK+ZBSQhLCAu8e7MJmYI20/idP9dNhCbTUBZ YsX8D+xdjOwcnAIWEj/SQaIsAqoSc5YsY4YYOZ9RYs7PTIitNhI3vt0FmygkkC/x+es0sGtE BHQkTn/9xwxxsqzErdmXmCcwCsxCcugshENnITl0ASPzKkaBotScxEpTvcSCgpxUveT83E2M 4LAtjNjB+H+Z1SFGAQ5GJR7eFZPsIoVYE8uKK3OBIcHBrCTC+2kCUIg3JbGyKrUoP76oNCe1 +BBjFdD9E5mlRJPzgTGVVxJvaGJiYGJsbGZsbG5iThVhJXHeRC+LSCGB9MSS1OzU1ILUIpjl TBycUg2MOp9/ietcvbwhxG1yypfn13vkPzy+1+yXvNAjUn/PnCOXLTwXLbpYfDnb5vJu+z/q ixavuCay46vQve2/FykoHDod0FGrMvm1dqSChpmcgPDrb3OU3VuCWGx2bL9THaX9dbJsv+qk l7HK73WnPdK7ePto/sGkSNaUkitrHiSnJJ7XUJ200+3PASWW4oxEQy3mouJEABjJ5u62AgAA Subject: Re: [PATCH v2] EmbeddedPkg/MmcDxe: Add alignment for ECSD data X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jun 2017 16:02:07 -0000 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII > On Jun 12, 2017, at 8:53 AM, Leif Lindholm wrote: > > On Mon, Jun 12, 2017 at 09:59:28AM +0800, Jun Nie wrote: >> Add alignment for ECSD data for DMA access. Otherwise >> the data is corrupted on Sanechips platform. > > I never did see a reply to my proposed solution, and the below is not > it. Can you explain why you prefer this one? > And it is still exposed to enum optimization changing the alignment of the structure. Thanks, Andrew Fish > / > Leif > >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Jun Nie >> --- >> EmbeddedPkg/Universal/MmcDxe/Mmc.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/EmbeddedPkg/Universal/MmcDxe/Mmc.h b/EmbeddedPkg/Universal/MmcDxe/Mmc.h >> index 8a7d5a3..6e3ab17 100644 >> --- a/EmbeddedPkg/Universal/MmcDxe/Mmc.h >> +++ b/EmbeddedPkg/Universal/MmcDxe/Mmc.h >> @@ -319,6 +319,7 @@ typedef struct { >> OCR OCRData; >> CID CIDData; >> CSD CSDData; >> + UINT64 Pad; // For 8 bytes alignment of ECSDData >> ECSD ECSDData; // MMC V4 extended card specific >> } CARD_INFO; >> >> -- >> 1.9.1 >> > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel