From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 16 Jul 2019 03:38:03 -0700 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 67FC3300CB0A; Tue, 16 Jul 2019 10:38:03 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-224.ams2.redhat.com [10.36.116.224]) by smtp.corp.redhat.com (Postfix) with ESMTP id B98C41001B0C; Tue, 16 Jul 2019 10:38:01 +0000 (UTC) Subject: Re: [PATCH 5/6] edksetup.sh: Simplify SetupPython3 and SetupPython functions. To: Rebecca Cran , devel@edk2.groups.io, bob.c.feng@intel.com, liming.gao@intel.com, leif.lindholm@linaro.org, michael.d.kinney@intel.com, afish@apple.com References: <20190715222516.53254-1-rebecca@bsdio.com> <20190715222516.53254-5-rebecca@bsdio.com> <191b2bc0-62c5-e31b-a62a-ca92fa3253cf@redhat.com> From: "Laszlo Ersek" Message-ID: <0840d1c0-c3fa-1d15-88b8-1951e1469f60@redhat.com> Date: Tue, 16 Jul 2019 12:38:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 16 Jul 2019 10:38:03 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/16/19 04:27, Rebecca Cran wrote: > On 2019-07-15 20:16, Laszlo Ersek wrote: >> That said, if you wouldn't like to rework the patch, I can give my R-b >> as-is (please confirm). > > > Thanks, I like your suggested changes. And I just ran shellcheck and was > told "SC2230: which is non-standard. Use builtin 'command -v' instead.". Great, and thank you for teaching me about "shellcheck". (I generally use the POSIX spec, and "dash", when I try to write portable shell scripts.) Laszlo