From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D98C078003C for ; Sun, 25 Feb 2024 14:38:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ylO6OfJBnEJl0FRu7Y1VPDM5H4+0XIZQKAa+gCiJ5KM=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708871906; v=1; b=QS8IS4KHKIOaBg75P/jXCubLw2y5mv7K5PGnwtCkT5oSsTW+KAOk0k6BUHA50BeMZ01xOUqP Pp5DLn78flKq2FHVfGE9PhetPIA2UV/7PY2w8tLPzI/1nSTXYkJez9RgSZs/LF/Y22A9acEporz HarKKvPlUhfLj1YnoAlr8neM= X-Received: by 127.0.0.2 with SMTP id 6s8KYY7687511x4qQEaWMeuf; Sun, 25 Feb 2024 06:38:26 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.40296.1708871905944772039 for ; Sun, 25 Feb 2024 06:38:26 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-152-tLTGmIe1PVCUqRrZn42Dxg-1; Sun, 25 Feb 2024 09:38:23 -0500 X-MC-Unique: tLTGmIe1PVCUqRrZn42Dxg-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 45FAD1C0514B; Sun, 25 Feb 2024 14:38:23 +0000 (UTC) X-Received: from [10.39.192.57] (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 34B381C06532; Sun, 25 Feb 2024 14:38:22 +0000 (UTC) Message-ID: <08486765-519c-0cb6-46d6-8e7eaaaaac39@redhat.com> Date: Sun, 25 Feb 2024 15:38:21 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg/CpuPageTableLib: Fix IN OUT parameters marked as IN To: Zhou Jianfeng , devel@edk2.groups.io Cc: Ray Ni , Rahul Kumar , Gerd Hoffmann References: <20240222023922.29275-1-jianfeng.zhou@intel.com> From: "Laszlo Ersek" In-Reply-To: <20240222023922.29275-1-jianfeng.zhou@intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ywm02uIVBbSUiHRXENavEY0kx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=QS8IS4KH; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2/22/24 03:39, Zhou Jianfeng wrote: > Some IN OUT parameters in CpuPageTableMap.c were mistakenly marked as IN. > "IN" replaced with "IN OUT" in the following interfaces: >=20 > PageTableLibSetPte4K(): Pte4K > PageTableLibSetPleB(): PleB > PageTableLibSetPle(): Ple > PageTableLibSetPnle(): Pnle >=20 > Reviewed-by: Ray Ni > Signed-off-by: Zhou Jianfeng > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Cc: Gerd Hoffmann > --- > .../Library/CpuPageTableLib/CpuPageTableMap.c | 32 +++++++++---------- > 1 file changed, 16 insertions(+), 16 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c b/UefiC= puPkg/Library/CpuPageTableLib/CpuPageTableMap.c > index ae4caf8dfe..2ea40666cc 100644 > --- a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > +++ b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > @@ -20,10 +20,10 @@ > **/ > VOID > PageTableLibSetPte4K ( > - IN IA32_PTE_4K *Pte4K, > - IN UINT64 Offset, > - IN IA32_MAP_ATTRIBUTE *Attribute, > - IN IA32_MAP_ATTRIBUTE *Mask > + IN OUT IA32_PTE_4K *Pte4K, > + IN UINT64 Offset, > + IN IA32_MAP_ATTRIBUTE *Attribute, > + IN IA32_MAP_ATTRIBUTE *Mask > ) > { > IA32_PTE_4K LocalPte4K; > @@ -94,10 +94,10 @@ PageTableLibSetPte4K ( > **/ > VOID > PageTableLibSetPleB ( > - IN IA32_PAGE_LEAF_ENTRY_BIG_PAGESIZE *PleB, > - IN UINT64 Offset, > - IN IA32_MAP_ATTRIBUTE *Attribute, > - IN IA32_MAP_ATTRIBUTE *Mask > + IN OUT IA32_PAGE_LEAF_ENTRY_BIG_PAGESIZE *PleB, > + IN UINT64 Offset, > + IN IA32_MAP_ATTRIBUTE *Attribute, > + IN IA32_MAP_ATTRIBUTE *Mask > ) > { > IA32_PAGE_LEAF_ENTRY_BIG_PAGESIZE LocalPleB; > @@ -171,11 +171,11 @@ PageTableLibSetPleB ( > **/ > VOID > PageTableLibSetPle ( > - IN UINTN Level, > - IN IA32_PAGING_ENTRY *Ple, > - IN UINT64 Offset, > - IN IA32_MAP_ATTRIBUTE *Attribute, > - IN IA32_MAP_ATTRIBUTE *Mask > + IN UINTN Level, > + IN OUT IA32_PAGING_ENTRY *Ple, > + IN UINT64 Offset, > + IN IA32_MAP_ATTRIBUTE *Attribute, > + IN IA32_MAP_ATTRIBUTE *Mask > ) > { > if (Level =3D=3D 1) { > @@ -195,9 +195,9 @@ PageTableLibSetPle ( > **/ > VOID > PageTableLibSetPnle ( > - IN IA32_PAGE_NON_LEAF_ENTRY *Pnle, > - IN IA32_MAP_ATTRIBUTE *Attribute, > - IN IA32_MAP_ATTRIBUTE *Mask > + IN OUT IA32_PAGE_NON_LEAF_ENTRY *Pnle, > + IN IA32_MAP_ATTRIBUTE *Attribute, > + IN IA32_MAP_ATTRIBUTE *Mask > ) > { > IA32_PAGE_NON_LEAF_ENTRY LocalPnle; > -- > 2.31.1.windows.1 >=20 Reviewed-by: Laszlo Ersek I can't start merging this immediately; we probably have a long list of patches that can and should now be merged, after the stable tag. It would be nice if patch submitters could ping the maintainers on their patch sets that are now ready for merging; we should wait for such pings for a few days, then mass-merge the bunch. Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115927): https://edk2.groups.io/g/devel/message/115927 Mute This Topic: https://groups.io/mt/104524856/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-