Re: [edk2-devel] EDK2 CI build error "Uncrustify Coding Standard"

["Rebecca Cran" <quic_rcran@quicinc.com>]

I have the following script for running Uncrustify locally on Linux:

../edk2/.pytool/Plugin/UncrustifyCheck/mu-uncrustify-release_extdep/Linux-x86/uncrustify 
-c ../edk2/.pytool/Plugin/UncrustifyCheck/uncrustify.cfg -F files 
--replace --no-backup --if-changed

Then I just echo the paths of files I want to check/fix:

echo Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > files
echo Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c >> 
files


-- 
Rebecca Cran

On 4/5/22 00:09, Ashish Kalra via groups.io wrote:
> Hi Mike,
>
> I am following up on Brijesh's email, i am running the CI tests 
> related to my SEV live migration patches,
> which i am in process of posting.
>
> I am running the CI tests locally and getting errors while building 
> OvmfPkg, my patches include two new
> header files, error log is copied below.
>
> Do you have updated instructions on how to run through uncrustify 
> locally and
> get my patch updated with those formatting changes, especially for 
> Linux ? (your above instructions seem specific to Windows).
>
> Thanks,
> Ashish
>
> Error log:
>
> ../.local/bin/stuart_ci_build -c .pytool/CISettings.py 
> TOOL_CHAIN_TAG=GCC5 -p OvmfPkg SECTION - Init SDE WARNING - Using Pip 
> Tools based BaseTools SECTION - Loading Plugins SECTION - Start 
> Invocable Tool SECTION - Getting Environment SECTION - Loading plugins 
> SECTION - Building OvmfPkg Package PROGRESS - --Running OvmfPkg: 
> Uncrustify Coding Standard Test NO-TARGET -- WARNING - A file header 
> template is not specified in the config file. WARNING - A function 
> header template is not specified in the config file. ERROR - 
> /home/amd/edk2-upstream/OvmfPkg/Library/BaseMemEncryptSevLib/PeiMemEncryptSevLibInternal.c 
> ERROR - 
> /home/amd/edk2-upstream/OvmfPkg/Library/BaseMemEncryptSevLib/DxeMemEncryptSevLibInternal.c 
> ERROR - --->Test Failed: Uncrustify Coding Standard Test NO-TARGET 
> returned 2 PROGRESS - --Running OvmfPkg: Guid Check Test NO-TARGET -- 
> PROGRESS - --->Test Success: Guid Check Test NO-TARGET PROGRESS - 
> --Running OvmfPkg: Char Encoding Check Test NO-TARGET -- PROGRESS - 
> --->Test Success: Char Encoding Check Test NO-TARGET PROGRESS - 
> --Running OvmfPkg: Spell Check Test NO-TARGET -- WARNING - NodeJs not 
> installed. Test can't run WARNING - --->Test Skipped: in plugin! Spell 
> Check Test NO-TARGET PROGRESS - --Running OvmfPkg: Dsc Complete Check 
> Test NO-TARGET -- PROGRESS - --->Test Success: Dsc Complete Check Test 
> NO-TARGET PROGRESS - --Running OvmfPkg: Host Unit Test Dsc Complete 
> Check Test NO-TARGET -- PROGRESS - --->Test Success: Host Unit Test 
> Dsc Complete Check Test NO-TARGET PROGRESS - --Running OvmfPkg: Host 
> Unit Test Compiler Plugin NOOPT -- WARNING - --->Test Skipped: in 
> plugin! Host Unit Test Compiler Plugin NOOPT PROGRESS - --Running 
> OvmfPkg: Library Class Check Test NO-TARGET -- PROGRESS - --->Test 
> Success: Library Class Check Test NO-TARGET PROGRESS - --Running 
> OvmfPkg: EccCheck Test NO-TARGET -- PROGRESS - --->Test Skipped by 
> package! EccCheck Test PROGRESS - --Running OvmfPkg: Compiler Plugin 
> DEBUG -- WARNING - --->Test Skipped: in plugin! Compiler Plugin DEBUG 
> PROGRESS - --Running OvmfPkg: Compiler Plugin RELEASE -- WARNING - 
> --->Test Skipped: in plugin! Compiler Plugin RELEASE PROGRESS - 
> --Running OvmfPkg: Dependency Check Test NO-TARGET -- PROGRESS - 
> --->Test Success: Dependency Check Test NO-TARGET PROGRESS - --Running 
> OvmfPkg: License Check Test NO-TARGET -- PROGRESS - --->Test Success: 
> License Check Test NO-TARGET ERROR - Overall Build Status: Error 
> PROGRESS - There were 1 failures out of 13 attempts SECTION - Summary 
> ERROR - Error
>