From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by mx.groups.io with SMTP id smtpd.web09.7369.1649170863468281032 for ; Tue, 05 Apr 2022 08:01:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=lO/IVy99; spf=pass (domain: quicinc.com, ip: 199.106.114.39, mailfrom: quic_rcran@quicinc.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1649170863; x=1680706863; h=message-id:date:mime-version:subject:to:references:cc: from:in-reply-to:content-transfer-encoding; bh=tVbfYFrMCk0ALbXHtsqaBoO1p9ThLpZWKMpurYzBjLg=; b=lO/IVy99Vur5TfnVaX/ADAHtBMBSHr0wQ3Y3119gRrlpBtSAZTvaGOll uswUrUPUqAliO5hIEkiz/U2SddzH8PuQBnqOzO0bFe2OeJXqr9lJ6gKVc O/V18h3taA1M4XDYiVqyE/Grdh9fzmqyJPeiAZDvrBNkaXzysS2jqLKmN 4=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-02.qualcomm.com with ESMTP; 05 Apr 2022 08:01:03 -0700 X-QCInternal: smtphost Received: from nasanex01b.na.qualcomm.com ([10.46.141.250]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2022 08:00:47 -0700 Received: from [10.110.39.192] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 5 Apr 2022 08:00:47 -0700 Message-ID: <08552626-5517-0091-f7ba-a7c2db5ceff9@quicinc.com> Date: Tue, 5 Apr 2022 09:00:46 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [edk2-devel] EDK2 CI build error "Uncrustify Coding Standard" To: , References: <14608.1649138274027224886@groups.io> <18598.1649138980553258823@groups.io> CC: Michael Kubacki From: "Rebecca Cran" In-Reply-To: <18598.1649138980553258823@groups.io> Return-Path: quic_rcran@quicinc.com X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit I have the following script for running Uncrustify locally on Linux: ../edk2/.pytool/Plugin/UncrustifyCheck/mu-uncrustify-release_extdep/Linux-x86/uncrustify -c ../edk2/.pytool/Plugin/UncrustifyCheck/uncrustify.cfg -F files --replace --no-backup --if-changed Then I just echo the paths of files I want to check/fix: echo Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > files echo Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c >> files -- Rebecca Cran On 4/5/22 00:09, Ashish Kalra via groups.io wrote: > Hi Mike, > > I am following up on Brijesh's email, i am running the CI tests > related to my SEV live migration patches, > which i am in process of posting. > > I am running the CI tests locally and getting errors while building > OvmfPkg, my patches include two new > header files, error log is copied below. > > Do you have updated instructions on how to run through uncrustify > locally and > get my patch updated with those formatting changes, especially for > Linux ? (your above instructions seem specific to Windows). > > Thanks, > Ashish > > Error log: > > ../.local/bin/stuart_ci_build -c .pytool/CISettings.py > TOOL_CHAIN_TAG=GCC5 -p OvmfPkg SECTION - Init SDE WARNING - Using Pip > Tools based BaseTools SECTION - Loading Plugins SECTION - Start > Invocable Tool SECTION - Getting Environment SECTION - Loading plugins > SECTION - Building OvmfPkg Package PROGRESS - --Running OvmfPkg: > Uncrustify Coding Standard Test NO-TARGET -- WARNING - A file header > template is not specified in the config file. WARNING - A function > header template is not specified in the config file. ERROR - > /home/amd/edk2-upstream/OvmfPkg/Library/BaseMemEncryptSevLib/PeiMemEncryptSevLibInternal.c > ERROR - > /home/amd/edk2-upstream/OvmfPkg/Library/BaseMemEncryptSevLib/DxeMemEncryptSevLibInternal.c > ERROR - --->Test Failed: Uncrustify Coding Standard Test NO-TARGET > returned 2 PROGRESS - --Running OvmfPkg: Guid Check Test NO-TARGET -- > PROGRESS - --->Test Success: Guid Check Test NO-TARGET PROGRESS - > --Running OvmfPkg: Char Encoding Check Test NO-TARGET -- PROGRESS - > --->Test Success: Char Encoding Check Test NO-TARGET PROGRESS - > --Running OvmfPkg: Spell Check Test NO-TARGET -- WARNING - NodeJs not > installed. Test can't run WARNING - --->Test Skipped: in plugin! Spell > Check Test NO-TARGET PROGRESS - --Running OvmfPkg: Dsc Complete Check > Test NO-TARGET -- PROGRESS - --->Test Success: Dsc Complete Check Test > NO-TARGET PROGRESS - --Running OvmfPkg: Host Unit Test Dsc Complete > Check Test NO-TARGET -- PROGRESS - --->Test Success: Host Unit Test > Dsc Complete Check Test NO-TARGET PROGRESS - --Running OvmfPkg: Host > Unit Test Compiler Plugin NOOPT -- WARNING - --->Test Skipped: in > plugin! Host Unit Test Compiler Plugin NOOPT PROGRESS - --Running > OvmfPkg: Library Class Check Test NO-TARGET -- PROGRESS - --->Test > Success: Library Class Check Test NO-TARGET PROGRESS - --Running > OvmfPkg: EccCheck Test NO-TARGET -- PROGRESS - --->Test Skipped by > package! EccCheck Test PROGRESS - --Running OvmfPkg: Compiler Plugin > DEBUG -- WARNING - --->Test Skipped: in plugin! Compiler Plugin DEBUG > PROGRESS - --Running OvmfPkg: Compiler Plugin RELEASE -- WARNING - > --->Test Skipped: in plugin! Compiler Plugin RELEASE PROGRESS - > --Running OvmfPkg: Dependency Check Test NO-TARGET -- PROGRESS - > --->Test Success: Dependency Check Test NO-TARGET PROGRESS - --Running > OvmfPkg: License Check Test NO-TARGET -- PROGRESS - --->Test Success: > License Check Test NO-TARGET ERROR - Overall Build Status: Error > PROGRESS - There were 1 failures out of 13 attempts SECTION - Summary > ERROR - Error >