From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=bob.c.feng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 352FA207DF298 for ; Sun, 1 Jul 2018 20:13:18 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jul 2018 20:13:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,297,1526367600"; d="scan'208";a="63687819" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 01 Jul 2018 20:13:12 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 1 Jul 2018 20:13:12 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 1 Jul 2018 20:13:12 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.82]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.87]) with mapi id 14.03.0319.002; Mon, 2 Jul 2018 11:13:11 +0800 From: "Feng, Bob C" To: "Gao, Liming" , "edk2-devel@lists.01.org" Thread-Topic: [Patch] BaseTool: Add cache for the result of SkipAutogen. Thread-Index: AQHUEaI8ovmZZjD/HEGCvhmkyLmZBqR6th0AgACJSlA= Date: Mon, 2 Jul 2018 03:13:10 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D15548921A@SHSMSX101.ccr.corp.intel.com> References: <20180702011547.314908-1-bob.c.feng@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E2A0919@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2A0919@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTool: Add cache for the result of SkipAutogen. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jul 2018 03:13:19 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming, Based on my testing, a module will enter the CanSkip() multiple times even = after CanSkip() return True.=20 In this patch, I cache the module after CanSkip() return True to save the c= ost of later CanSkip() evaluation. I think the CanSkip() will always return True after it return True at first= time in one build process. Thanks, Bob -----Original Message----- From: Gao, Liming=20 Sent: Monday, July 02, 2018 10:53 AM To: Feng, Bob C ; edk2-devel@lists.01.org Subject: RE: [Patch] BaseTool: Add cache for the result of SkipAutogen. Bob: When will this cache take effective?=20 Thanks Liming >-----Original Message----- >From: Feng, Bob C >Sent: Monday, July 02, 2018 9:16 AM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming=20 > >Subject: [Patch] BaseTool: Add cache for the result of SkipAutogen. > >Add a cache for the value of skip ModuleAutoGen process flag. This=20 >cache can improve build performance. > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Bob Feng >Cc: Liming Gao >--- > BaseTools/Source/Python/AutoGen/AutoGen.py | 4 ++++ > BaseTools/Source/Python/Common/GlobalData.py | 1 + > 2 files changed, 5 insertions(+) > >diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py >b/BaseTools/Source/Python/AutoGen/AutoGen.py >index 381dbc0a71..fc242992b7 100644 >--- a/BaseTools/Source/Python/AutoGen/AutoGen.py >+++ b/BaseTools/Source/Python/AutoGen/AutoGen.py >@@ -4305,15 +4305,18 @@ class ModuleAutoGen(AutoGen): > > ## Decide whether we can skip the ModuleAutoGen process > def CanSkipbyHash(self): > if GlobalData.gUseHashCache: > return not self.GenModuleHash() >+ return False > > ## Decide whether we can skip the ModuleAutoGen process > # If any source file is newer than the module than we cannot skip > # > def CanSkip(self): >+ if self.MetaFile in GlobalData.gSikpAutoGenCache: >+ return True > if not os.path.exists(self.GetTimeStampPath()): > return False > #last creation time of the module > DstTimeStamp =3D os.stat(self.GetTimeStampPath())[8] > >@@ -4328,10 +4331,11 @@ class ModuleAutoGen(AutoGen): > return False > if source not in ModuleAutoGen.TimeDict : > ModuleAutoGen.TimeDict[source] =3D os.stat(source)[8] > if ModuleAutoGen.TimeDict[source] > DstTimeStamp: > return False >+ GlobalData.gSikpAutoGenCache.add(self.MetaFile) > return True > > def GetTimeStampPath(self): > if self._TimeStampPath is None: > self._TimeStampPath =3D os.path.join(self.MakeFileDir, >'AutoGenTimeStamp') >diff --git a/BaseTools/Source/Python/Common/GlobalData.py >b/BaseTools/Source/Python/Common/GlobalData.py >index afb3d8f020..fac7cde708 100644 >--- a/BaseTools/Source/Python/Common/GlobalData.py >+++ b/BaseTools/Source/Python/Common/GlobalData.py >@@ -111,5 +111,6 @@ gBinCacheDest =3D None gBinCacheSource =3D None =20 >gPlatformHash =3D None gPackageHash =3D {} gModuleHash =3D {} =20 >gEnableGenfdsMultiThread =3D False >+gSikpAutoGenCache =3D set() >-- >2.16.2.windows.1