From: "Feng, Bob C" <bob.c.feng@intel.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH v1 6/7] BaseTools/GenFds: Remove duplicate function calls
Date: Tue, 25 Sep 2018 13:45:31 +0000 [thread overview]
Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D155514BBF@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <0596a9e88a6b962b9944a2b16d598bc7d54674e8.1537799017.git.jaben.carsey@intel.com>
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: Carsey, Jaben
Sent: Monday, September 24, 2018 10:28 PM
To: edk2-devel@lists.01.org
Cc: Feng, Bob C <bob.c.feng@intel.com>; Zhu, Yonghong <yonghong.zhu@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [PATCH v1 6/7] BaseTools/GenFds: Remove duplicate function calls
every call to GetAprioriSection() is duplicated on the line below.
remove one of the calls.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
---
BaseTools/Source/Python/GenFds/FdfParser.py | 2 --
1 file changed, 2 deletions(-)
diff --git a/BaseTools/Source/Python/GenFds/FdfParser.py b/BaseTools/Source/Python/GenFds/FdfParser.py
index 821b3edb7592..f6b79764b2a0 100644
--- a/BaseTools/Source/Python/GenFds/FdfParser.py
+++ b/BaseTools/Source/Python/GenFds/FdfParser.py
@@ -2121,7 +2121,6 @@ class FdfParser:
raise Warning("FvNameString found but FvNameGuid was not found", self.FileName, self.CurrentLineNumber)
self._GetAprioriSection(FvObj)
- self._GetAprioriSection(FvObj)
while True:
isInf = self._GetInfStatement(FvObj) @@ -3780,7 +3779,6 @@ class FdfParser:
self._GetFvAlignment(FvObj)
self._GetFvAttributes(FvObj)
self._GetAprioriSection(FvObj)
- self._GetAprioriSection(FvObj)
while True:
IsInf = self._GetInfStatement(FvObj)
--
2.16.2.windows.1
next prev parent reply other threads:[~2018-09-25 13:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 14:28 [PATCH v1 0/7] BaseTools/GenFds: cleanup GenFds Jaben Carsey
2018-09-24 14:28 ` [PATCH v1 1/7] " Jaben Carsey
2018-09-24 14:28 ` [PATCH v1 2/7] BaseTools/GenFds: change objects to sets Jaben Carsey
2018-09-24 14:28 ` [PATCH v1 3/7] Basetools/GenFds: refactor class FV Jaben Carsey
2018-09-24 14:28 ` [PATCH v1 4/7] BaseTools/GenFds: remove MacroDict parameter Jaben Carsey
2018-09-24 14:28 ` [PATCH v1 5/7] BaseTools/GenFds: refactor FdfParser warnings Jaben Carsey
2018-09-24 14:28 ` [PATCH v1 6/7] BaseTools/GenFds: Remove duplicate function calls Jaben Carsey
2018-09-25 13:45 ` Feng, Bob C [this message]
2018-09-24 14:28 ` [PATCH v1 7/7] BaseTools/GenFds: create and use new variable in FdfParser Jaben Carsey
2018-09-25 13:45 ` Feng, Bob C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08650203BA1BD64D8AD9B6D5D74A85D155514BBF@SHSMSX101.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox