From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=bob.c.feng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 995B021962301 for ; Tue, 25 Sep 2018 06:49:46 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2018 06:49:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,302,1534834800"; d="scan'208";a="91749463" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 25 Sep 2018 06:45:35 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 25 Sep 2018 06:45:35 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 25 Sep 2018 06:45:34 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.220]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.27]) with mapi id 14.03.0319.002; Tue, 25 Sep 2018 21:45:32 +0800 From: "Feng, Bob C" To: "Carsey, Jaben" , "edk2-devel@lists.01.org" CC: "Zhu, Yonghong" , "Gao, Liming" Thread-Topic: [PATCH v1 6/7] BaseTools/GenFds: Remove duplicate function calls Thread-Index: AQHUVBMlJoRIluOGiU2yMLmI6jtxdaUBA9EA Date: Tue, 25 Sep 2018 13:45:31 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D155514BBF@SHSMSX101.ccr.corp.intel.com> References: <0596a9e88a6b962b9944a2b16d598bc7d54674e8.1537799017.git.jaben.carsey@intel.com> In-Reply-To: <0596a9e88a6b962b9944a2b16d598bc7d54674e8.1537799017.git.jaben.carsey@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzljMzAzNjMtZDZkNC00NTNlLTg3ZjAtYTA3NDU1ZjM3NGZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiM21aZGwwaE8wYys3ZTVKclJMQVJvK0E1M0hyVlBHY1lCS2NOXC9tMTQ3bjRcL1hIZkdkamhjQVpWeG9lTnpGcDhQIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v1 6/7] BaseTools/GenFds: Remove duplicate function calls X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 13:49:46 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: Carsey, Jaben=20 Sent: Monday, September 24, 2018 10:28 PM To: edk2-devel@lists.01.org Cc: Feng, Bob C ; Zhu, Yonghong ; Gao, Liming Subject: [PATCH v1 6/7] BaseTools/GenFds: Remove duplicate function calls every call to GetAprioriSection() is duplicated on the line below. remove one of the calls. Cc: Bob Feng Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/GenFds/FdfParser.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/BaseTools/Source/Python/GenFds/FdfParser.py b/BaseTools/Source= /Python/GenFds/FdfParser.py index 821b3edb7592..f6b79764b2a0 100644 --- a/BaseTools/Source/Python/GenFds/FdfParser.py +++ b/BaseTools/Source/Python/GenFds/FdfParser.py @@ -2121,7 +2121,6 @@ class FdfParser: raise Warning("FvNameString found but FvNameGuid was not found= ", self.FileName, self.CurrentLineNumber) =20 self._GetAprioriSection(FvObj) - self._GetAprioriSection(FvObj) =20 while True: isInf =3D self._GetInfStatement(FvObj) @@ -3780,7 +3779,6 @@ c= lass FdfParser: self._GetFvAlignment(FvObj) self._GetFvAttributes(FvObj) self._GetAprioriSection(FvObj) - self._GetAprioriSection(FvObj) =20 while True: IsInf =3D self._GetInfStatement(FvObj) -- 2.16.2.windows.1