From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=bob.c.feng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BE0AD21164EF8 for ; Sun, 21 Oct 2018 04:52:36 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Oct 2018 04:52:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,408,1534834800"; d="scan'208";a="82932063" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga007.jf.intel.com with ESMTP; 21 Oct 2018 04:52:35 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 21 Oct 2018 04:52:35 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 21 Oct 2018 04:52:34 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.46]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.21]) with mapi id 14.03.0319.002; Sun, 21 Oct 2018 19:52:31 +0800 From: "Feng, Bob C" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [edk2] [Patch] BaseTools: Fixed a key error code bug. Thread-Index: AQHUaTMhfniaouGqZ0q1x9CGfSY33aUpD/WAgACGT2A= Date: Sun, 21 Oct 2018 11:52:31 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D15FFC30FB@SHSMSX101.ccr.corp.intel.com> References: <20181021114201.19592-1-bob.c.feng@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWEzYzhiM2MtY2E1ZC00OGZmLThjODItNzg0NWRlNDFkMzZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiblBTOUtSS1pReFNNOGs3TnhFaHI0N21mSHo4VTRIRTh1STlMNytRSmdOZ3liRjZwNTdLNmhlYjlWMXlxMFVPZyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Fixed a key error code bug. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Oct 2018 11:52:37 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cool. -----Original Message----- From: Zhu, Yonghong=20 Sent: Sunday, October 21, 2018 7:50 PM To: Feng, Bob C ; edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: RE: [edk2] [Patch] BaseTools: Fixed a key error code bug. Hi Bob, I fixed this issue by below patch, I will check in the patch soon. https://lists.01.org/pipermail/edk2-devel/2018-October/031161.html=20 Best Regards, Zhu Yonghong -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of BobC= F Sent: Sunday, October 21, 2018 7:42 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [Patch] BaseTools: Fixed a key error code bug. There is a code bug that used a wrong key. This Patch is to correct it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/= Python/AutoGen/AutoGen.py index f2146a7790..87d6107035 100644 --- a/BaseTools/Source/Python/AutoGen/AutoGen.py +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py @@ -567,12 +567,12 @@ class WorkspaceAutoGen(AutoGen): if (Name, Guid) not in DecPcds: EdkLogger.error( 'build', PARSER_ERROR, "PCD (%s.%s) used in FDF is not declared in DEC fi= les." % (Guid, Name), - File =3D self.FdfProfile.PcdFileLineDict[Name, Gui= d][0], - Line =3D self.FdfProfile.PcdFileLineDict[Name, Gui= d][1] + File =3D self.FdfProfile.PcdFileLineDict[Name, Gui= d,Fileds][0], + Line =3D self.FdfProfile.PcdFileLineDict[Name, + Guid,Fileds][1] ) else: # Check whether Dynamic or DynamicEx PCD used in FDF f= ile. If used, build break and give a error message. if (Name, Guid, TAB_PCDS_FIXED_AT_BUILD) in DecPcdsKey= \ or (Name, Guid, TAB_PCDS_PATCHABLE_IN_MODULE) in D= ecPcdsKey \ @@ -581,12 +581,12 @@ class WorkspaceAutoGen(AutoGen): elif (Name, Guid, TAB_PCDS_DYNAMIC) in DecPcdsKey or (= Name, Guid, TAB_PCDS_DYNAMIC_EX) in DecPcdsKey: EdkLogger.error( 'build', PARSER_ERROR, "Using Dynamic or DynamicEx type of PCD [%= s.%s] in FDF file is not allowed." % (Guid, Name), - File =3D self.FdfProfile.PcdFileLineDict[N= ame, Guid][0], - Line =3D self.FdfProfile.PcdFileLineDict[N= ame, Guid][1] + File =3D self.FdfProfile.PcdFileLineDict[N= ame, Guid,Fileds][0], + Line =3D=20 + self.FdfProfile.PcdFileLineDict[Name, Guid,Fileds][1] ) =20 Pa =3D PlatformAutoGen(self, self.MetaFile, Target, Toolchain,= Arch) # # Explicitly collect platform's dynamic PCDs -- 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel