From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=bob.c.feng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 83633211B5A25 for ; Wed, 16 Jan 2019 08:26:58 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jan 2019 08:26:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,486,1539673200"; d="scan'208";a="292054735" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 16 Jan 2019 08:26:57 -0800 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 16 Jan 2019 08:26:57 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 16 Jan 2019 08:26:57 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.196]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.159]) with mapi id 14.03.0415.000; Thu, 17 Jan 2019 00:26:55 +0800 From: "Feng, Bob C" To: "Gao, Liming" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] BaseTools: Fix the build report issue for VPD Thread-Index: AQHUrbCIlx1lmNSUEEeX++5OcpT/FqWxiGeAgACL3bA= Date: Wed, 16 Jan 2019 16:26:54 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D16005B209@SHSMSX101.ccr.corp.intel.com> References: <20190116153021.5964-1-bob.c.feng@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B33B1@SHSMSX152.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B33B1@SHSMSX152.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDM2NTcwNjktODYxZS00M2YxLWI3NjEtNDFkM2ExNjU4ZTk4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK0JTd1BzdHBHRVBFUVB5WjhEZ3NkZkpIY1lBazdmcWE4WXR1VmpwOU0xdmxaaHFaMnZOejVIQ2sxWFlQamZZYyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Fix the build report issue for VPD X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2019 16:26:58 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable OK. I'll submit BZ. The two patches are to fix two issues that have differe= nt root cause, so I think two patches would be better.=20 -----Original Message----- From: Gao, Liming=20 Sent: Thursday, January 17, 2019 12:03 AM To: Feng, Bob C ; edk2-devel@lists.01.org Subject: RE: [edk2] [Patch] BaseTools: Fix the build report issue for VPD Bob: Please submit BZ for this issue. Could we merge these two patches? Seemly= , they are both build report issue.=20 Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Feng, Bob C > Sent: Wednesday, January 16, 2019 11:30 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch] BaseTools: Fix the build report issue for VPD >=20 > From: BobCF >=20 > Make sure the PlatformAutoGen.AllPcdList always be latest, or build=20 > report will fail sometimes. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Bob Feng > Cc: Liming Gao > --- > BaseTools/Source/Python/AutoGen/AutoGen.py | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py=20 > b/BaseTools/Source/Python/AutoGen/AutoGen.py > index cfe2d29099..85d966c62f 100644 > --- a/BaseTools/Source/Python/AutoGen/AutoGen.py > +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py > @@ -1029,11 +1029,10 @@ class PlatformAutoGen(AutoGen): > self.Arch =3D Arch > self.SourceDir =3D PlatformFile.SubDir > self.SourceOverrideDir =3D None > self.FdTargetList =3D self.Workspace.FdTargetList > self.FvTargetList =3D self.Workspace.FvTargetList > - self.AllPcdList =3D [] > # get the original module/package/platform objects > self.BuildDatabase =3D Workspace.BuildDatabase > self.DscBuildDataObj =3D Workspace.Platform >=20 > # flag indicating if the makefile/C-code file has been=20 > created or not @@ -1110,10 +1109,13 @@ class PlatformAutoGen(AutoGen): > self.LibraryBuildDirectoryList =3D Makefile.GetLibraryBuildDirec= toryList() > self.ModuleBuildDirectoryList =3D=20 > Makefile.GetModuleBuildDirectoryList() >=20 > self.IsMakeFileCreated =3D True >=20 > + @property > + def AllPcdList(self): > + return self.DynamicPcdList + self.NonDynamicPcdList > ## Deal with Shared FixedAtBuild Pcds > # > def CollectFixedAtBuildPcds(self): > for LibAuto in self.LibraryAutoGenList: > FixedAtBuildPcds =3D {} > @@ -1624,11 +1626,10 @@ class PlatformAutoGen(AutoGen): > if type(SkuId) in (str, unicode) and eval(SkuId) =3D= =3D 0 or SkuId =3D=3D 0: > continue > pcd.SkuInfoList[SkuName] =3D copy.deepcopy(pcd.SkuIn= foList[TAB_DEFAULT]) > pcd.SkuInfoList[SkuName].SkuId =3D SkuId > pcd.SkuInfoList[SkuName].SkuIdName =3D SkuName > - self.AllPcdList =3D self._NonDynamicPcdList + self._DynamicPcdLi= st >=20 > def FixVpdOffset(self, VpdFile ): > FvPath =3D os.path.join(self.BuildDir, TAB_FV_DIRECTORY) > if not os.path.exists(FvPath): > try: > -- > 2.19.1.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel