From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=bob.c.feng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 484CD211BED7D for ; Tue, 29 Jan 2019 21:25:06 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2019 21:25:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,539,1539673200"; d="scan'208";a="118553725" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga007.fm.intel.com with ESMTP; 29 Jan 2019 21:25:05 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 29 Jan 2019 21:25:04 -0800 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 29 Jan 2019 21:25:04 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.110]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.253]) with mapi id 14.03.0415.000; Wed, 30 Jan 2019 13:25:02 +0800 From: "Feng, Bob C" To: "Gao, Liming" , Laszlo Ersek CC: "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch v2 00/33] BaseTools python3 migration patch set Thread-Index: AQHUt3fK9d84JJ6l40uzWT7OlL0dNaXFshmAgADV04CAAL+rsA== Date: Wed, 30 Jan 2019 05:25:02 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D16007B546@SHSMSX101.ccr.corp.intel.com> References: <20190129020610.14300-1-bob.c.feng@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3D21FD@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3D21FD@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch v2 00/33] BaseTools python3 migration patch set X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 05:25:06 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I agree this proposal.=20 I plan to push python3 patch set to edk2 master in this Friday morning, Feb= .1 PRC time if there is no more comments or no critical issues found. Thanks, Bob -----Original Message----- From: Gao, Liming=20 Sent: Wednesday, January 30, 2019 9:53 AM To: Laszlo Ersek ; Feng, Bob C Cc: edk2-devel@lists.01.org Subject: RE: [edk2] [Patch v2 00/33] BaseTools python3 migration patch set Laszlo: I agree your proposal. Push this patch set first if no other comments, the= n continue to do minor bug fix.=20 =20 Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Laszlo Ersek > Sent: Tuesday, January 29, 2019 9:07 PM > To: Feng, Bob C > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch v2 00/33] BaseTools python3 migration patch=20 > set >=20 > Hi Bob, >=20 > On 01/29/19 03:05, Feng, Bob C wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D55 > > > > V2: > > The python files under CParser4 folder of ECC/Eot tool are generated=20 > > by antlr4 and forpython3 usage. > > They have python3 specific syntax, for example the data type=20 > > declaration for the arguments of a function. That is not compitable=20 > > with python2. this patch is to remove these syntax. > > > > The version2 patch set is commit to=20 > > https://github.com/BobCF/edk2.git branch py3basetools_v2 >=20 > (reusing the "test plan" from my email at > at.com>:) >=20 > I ran the following tests, at commit 6edb6bd9f182 ("BaseTools: Eot=20 > tool > Python3 adaption", 2019-01-29). Each test was performed in a clean=20 > tree (after running "git clean -ffdx") and clean environment (I=20 > re-sourced "edksetup.sh" for each test in separation). In addition,=20 > the base tools were rebuilt (again from a clean tree) for each test,=20 > with the following command [1]: >=20 > nice make -C "$EDK_TOOLS_PATH" -j $(getconf _NPROCESSORS_ONLN) >=20 > (a) On my RHEL7.5 Workstation laptop, I have both the system-level=20 > python packages installed (python-2.7.5-69.el7_5.x86_64), and the=20 > extra > python-3.4 stuff from EPEL-7 (python34-3.4.9-1.el7.x86_64). >=20 > (a1) Didn't set either PYTHON3_ENABLE or PYTHON_COMMAND. The build=20 > utility picked >=20 > PYTHON_COMMAND =3D /usr/bin/python3.4 >=20 > and I successfully built OvmfPkg for IA32, IA32X64, and X64; also=20 > ArmVirtQemu for AARCH64. The built firmware images passed a smoke test=20 > too. >=20 > (a2) I removed all the python34 packages (and the dependent packages)=20 > from my laptop. Didn't set either of PYTHON3_ENABLE and PYTHON_COMMAND. > (This is the configuration what a "normal" RHEL7 environment would > provide.) The "build" utility didn't print any PYTHON_COMMAND setting,=20 > but the same fw platform builds as in (a1) completed fine. The smoke=20 > tests passed again as well. >=20 > (b) RHEL-8 virtual machine, with "/usr/bin/python3.6" from=20 > python36-3.6.6-18.el8.x86_64, and "/usr/libexec/platform-python" from=20 > platform-python-3.6.8-1.el8.x86_64. >=20 > (b1) Didn't set either PYTHON3_ENABLE or PYTHON_COMMAND. The build=20 > utility picked >=20 > PYTHON_COMMAND =3D /usr/bin/python3.6 >=20 > and I successfully built OvmfPkg for IA32, IA32X64, and X64. (I don't=20 > have a cross-compiler installed in this environment yet, nor a RHEL8 > aarch64 KVM guest, so I couldn't test ArmVirtQemu for now). >=20 > (b2) I set PYTHON_COMMAND to "/usr/libexec/platform-python". Didn't=20 > set PYTHON3_ENABLE. The same builds as in (b1) succeeded. >=20 >=20 > For the series: >=20 > Tested-by: Laszlo Ersek >=20 > Given that the testing is quite time consuming, I suggest that we push > v2 (assuming reviewers don't find critical issues), and address small=20 > issues incrementally. >=20 > Thanks! > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel