public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Feng, Bob C" <bob.c.feng@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
	"Gao, Liming" <liming.gao@intel.com>,
	"Bi, Dandan" <dandan.bi@intel.com>,
	"Carsey, Jaben" <jaben.carsey@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch 0/3] BaseTools: Implement splitquoted function
Date: Thu, 14 Feb 2019 02:51:18 +0000	[thread overview]
Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D160085388@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <46f28c37-826a-f0b2-38f5-b04cfe45e389@redhat.com>

Hi Laszlo, Liming, Jaben and Dandan,

I found this is a Ubuntu18 bug. Refer to https://bugs.launchpad.net/ubuntu/+source/fdroidserver/+bug/1762183

And Ubuntu fixed this bug via a Ubuntu18.04.1 update package which was published on 2018-08-09. Refer to https://launchpad.net/ubuntu/+source/fdroidserver/1.0.9-1~18.04.1

While the latest Ubuntu 18.04 release (ubuntu-18.04.1-desktop-amd64.iso)  on http://releases.ubuntu.com/18.04/ was published on 2018-07-25.  So there is no distutils.util library on Ubuntu18.04 default installation. But I think it's clear that distutils.util is not *3rd party* python library. 

I have tried that the command "sudo apt upgrade"  can't fix this bug while the command "sudo apt-get install python3-distutils" works.

Thanks,
Bob

-----Original Message-----
From: Laszlo Ersek [mailto:lersek@redhat.com] 
Sent: Tuesday, February 12, 2019 10:02 PM
To: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Bi, Dandan <dandan.bi@intel.com>
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function

On 02/12/19 14:33, Gao, Liming wrote:
> Laszlo:
>  To install python3-distutils should resolve this issue. I expect BaseTools build functionality doesn't depend on the third party python lib.

I completely agree with your expectation, regarding *3rd party* python packages. We shouldn't expect developers to install packages from repositories that fall outside of their normal distro repos.

However, my understanding was that python3-distutils should be available as a normal (not 3rd party) component on Ubuntu 18. I think we can expect developers to install additional packages if those packages are readily available in their normal (distro-provided) repos.

> So, I suggest to check whether python3-distutils is the native python library. If it is native python library, why Ubuntu18 doesn't include it. I will work with Dandan to collect more information. 

Right, that's exactly what I'm asking for. Thank you very much!
Laszlo

>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Tuesday, February 12, 2019 8:24 PM
>> To: Feng, Bob C <bob.c.feng@intel.com>; Bi, Dandan 
>> <dandan.bi@intel.com>
>> Cc: edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com>
>> Subject: Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted 
>> function
>>
>> On 02/04/19 20:12, Laszlo Ersek wrote:
>>> On 02/03/19 06:55, Feng, Bob C wrote:
>>>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1509
>>>> On some Linux environment, there may be no distutils.util library 
>>>> for python3 that will cause build tool crash.
>>>> This patch implement distutils.util.split_quoted in BaseTools so 
>>>> that the Basetools will be independent with distutils.util library.
>>>>
>>>> Feng, Bob C (3):
>>>>   BaseTools: Implement splitquoted function in Build tool
>>>>   BaseTools: Implement splitquoted function in UPT
>>>>   BaseTools: unit test for splitquoted function
>>>>
>>>>  BaseTools/Source/Python/AutoGen/UniClassObject.py     | 50 ++++++++++++++++++++++++++++++++++++++++++++++----
>>>>  BaseTools/Source/Python/UPT/Library/UniClassObject.py | 47 ++++++++++++++++++++++++++++++++++++++++++++---
>>>>  BaseTools/Tests/TestStringSplit.py                    | 38 ++++++++++++++++++++++++++++++++++++++
>>>>  3 files changed, 128 insertions(+), 7 deletions(-)  create mode 
>>>> 100644 BaseTools/Tests/TestStringSplit.py
>>>>
>>>
>>> Is this really necessary? BZ#1509 references Ubuntu18; however it 
>>> looks like the issue can be resolved by a simple package 
>>> installation on Ubuntu 18:
>>>
>>> https://superuser.com/questions/1319047/cant-install-virtual-interpr
>>> eter-in-pycharm-in-linux
>>>
>>> """
>>> sudo apt-get install python3-distutils """
>>>
>>> I'm not a Ubuntu user myself; so all I can do here (without 
>>> installing a
>>> Ubuntu18 VM) is check the Ubuntu package directory:
>>>
>>> https://packages.ubuntu.com/search?keywords=python3-distutils&search
>>> on=names&suite=all&section=all
>>>
>>> python3-distutils appears available for both "bionic (18.04LTS)" and 
>>> "cosmic (18.10)".
>>>
>>> Dandan, if you install python3-distutils, does that solve the issue for you?
>>
>> I'd still like to get an answer to my question, before the series is pushed.
>>
>> Thanks,
>> Laszlo


  parent reply	other threads:[~2019-02-14  2:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-03  5:55 [Patch 0/3] BaseTools: Implement splitquoted function Feng, Bob C
2019-02-03  5:55 ` [Patch 1/3] BaseTools: Implement splitquoted function in Build tool Feng, Bob C
2019-02-04 15:38   ` Carsey, Jaben
2019-02-03  5:55 ` [Patch 2/3] BaseTools: Implement splitquoted function in UPT Feng, Bob C
2019-02-03  5:55 ` [Patch 3/3] BaseTools: unit test for splitquoted function Feng, Bob C
2019-02-04 19:12 ` [Patch 0/3] BaseTools: Implement " Laszlo Ersek
2019-02-12 12:23   ` Laszlo Ersek
2019-02-12 13:33     ` Gao, Liming
2019-02-12 14:02       ` Laszlo Ersek
2019-02-12 17:16         ` Philippe Mathieu-Daudé
2019-02-12 17:24           ` Laszlo Ersek
2019-02-14  2:51         ` Feng, Bob C [this message]
2019-02-14  3:23           ` Gao, Liming
2019-02-14 15:35             ` Laszlo Ersek
2019-02-15 14:35               ` Gao, Liming
2019-02-15 21:54                 ` Laszlo Ersek
2019-02-14 15:32           ` Laszlo Ersek
2019-02-15  3:19             ` Feng, Bob C
2019-02-12 10:44 ` Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08650203BA1BD64D8AD9B6D5D74A85D160085388@SHSMSX101.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox