public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Feng, Bob C" <bob.c.feng@intel.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Gao, Liming" <liming.gao@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch V3] BaseTools: Add python3-distutils Ubuntu package checking
Date: Thu, 28 Feb 2019 13:29:23 +0000	[thread overview]
Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D1600A0DEE@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20190228131909.2612-1-bob.c.feng@intel.com>

Hi Phil,

Your suggested code is good but it still print the call stack. I changed it a little, it only print the error message now.

Thanks,
Bob 

-----Original Message-----
From: Feng, Bob C 
Sent: Thursday, February 28, 2019 9:19 PM
To: edk2-devel@lists.01.org
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [Patch V3] BaseTools: Add python3-distutils Ubuntu package checking

https://bugzilla.tianocore.org/show_bug.cgi?id=1509

Add python3-distutils Ubuntu package checking.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
 BaseTools/Tests/RunTests.py | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/BaseTools/Tests/RunTests.py b/BaseTools/Tests/RunTests.py index 0dd65632d0..356c1d600c 100644
--- a/BaseTools/Tests/RunTests.py
+++ b/BaseTools/Tests/RunTests.py
@@ -17,10 +17,17 @@
 #
 import os
 import sys
 import unittest
 
+try:
+    import distutils.util
+except ModuleNotFoundError:
+    sys.exit('''
+Python reported: "No module named 'distutils.uitl'"
+''')
+
 import TestTools
 
 def GetCTestSuite():
     import CToolsTests
     return CToolsTests.TheTestSuite()
--
2.20.1.windows.1



  reply	other threads:[~2019-02-28 13:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-28 13:19 [Patch V3] BaseTools: Add python3-distutils Ubuntu package checking Feng, Bob C
2019-02-28 13:29 ` Feng, Bob C [this message]
2019-02-28 13:49   ` Philippe Mathieu-Daudé
2019-02-28 15:49 ` Carsey, Jaben

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08650203BA1BD64D8AD9B6D5D74A85D1600A0DEE@SHSMSX101.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox