From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=bob.c.feng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1C71E211CFFF8 for ; Thu, 28 Feb 2019 18:58:49 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Feb 2019 18:58:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,425,1544515200"; d="scan'208";a="118671288" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga007.jf.intel.com with ESMTP; 28 Feb 2019 18:58:48 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 28 Feb 2019 18:58:48 -0800 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 28 Feb 2019 18:58:48 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.158]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.121]) with mapi id 14.03.0415.000; Fri, 1 Mar 2019 10:58:46 +0800 From: "Feng, Bob C" To: "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [Patch] Document: Update Dsc spec to all empty value for HIIPcd Thread-Index: AQHUzwrxRq1F21KfPEW7S3L7D0tUq6X2F0Ww Date: Fri, 1 Mar 2019 02:58:45 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D1600A44D9@SHSMSX101.ccr.corp.intel.com> References: <20190228021117.21740-1-bob.c.feng@intel.com> In-Reply-To: <20190228021117.21740-1-bob.c.feng@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] Document: Update Dsc spec to all empty value for HIIPcd X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Mar 2019 02:58:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Would you give the reviewed-by? -----Original Message----- From: Feng, Bob C=20 Sent: Thursday, February 28, 2019 10:11 AM To: edk2-devel@lists.01.org Cc: Feng, Bob C ; Gao, Liming Subject: [Patch] Document: Update Dsc spec to all empty value for HIIPcd https://bugzilla.tianocore.org/show_bug.cgi?id=3D1466 Update Dsc spec to all empty value for HIIPcd. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- 2_dsc_overview/29_pcd_sections.md | 4 ++-- 3_edk_ii_dsc_file_format/310_pcd_sections.md | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/2_dsc_overview/29_pcd_sections.md b/2_dsc_overview/29_pcd_sect= ions.md index 791125f..d84d2f4 100644 --- a/2_dsc_overview/29_pcd_sections.md +++ b/2_dsc_overview/29_pcd_sections.md @@ -230,11 +230,11 @@ example: `[PcdsDynamicHii.common.Sku1]` =20 While the format for content of this section is as follows, note that the = backslash character is used here to indicate the continuation of the line: =20 -`PcdTokenSpaceGuidCName.PcdCName|VariableName|VariableGuid|VariableOffset[= |HiiDefaultValue[|HiiAttrubte]]` +`PcdTokenSpaceGuidCName.PcdCName|VariableName|VariableGuid|VariableOffs +et[|[HiiDefaultValue][|HiiAttrubte]]` =20 For VOID* PCDs, the HiiDefaultValue will be a pointer; specifying the opti= onal HiiDefaultValue has no meaning. =20 The optional HII Attribute entry is a comma separated list of attributes a= s @@ -340,11 +340,11 @@ Specifying a `SKUID` for an HII PCD selection is op= tional, for example: `[PcdsDynamicExHii.common.Sku1]` =20 While the format for content of this section is as follows, note that the = backslash character is used here to indicate the continuation of the line: =20 -`PcdTokenSpaceGuidCName.PcdCName|VariableName|VariableGuid|VariableOffset[= |HiiDefaultValue]` +`PcdTokenSpaceGuidCName.PcdCName|VariableName|VariableGuid|VariableOffs +et[|[HiiDefaultValue]]` =20 The optional HII Attribute entry is a comma separated list of attributes a= s described in Table 9 HII Attributes. =20 **Note:** The VariableName field in the HII format PCD entry must not be a= n empty string. diff --git a/3_edk_ii_dsc_file_format/310_pcd_sections.md b/3_edk_ii_dsc_fi= le_format/310_pcd_sections.md index f9f1359..f982d60 100644 --- a/3_edk_ii_dsc_file_format/310_pcd_sections.md +++ b/3_edk_ii_dsc_file_format/310_pcd_sections.md @@ -503,11 +503,11 @@ sections of the DSC file. ::=3D {} {} [ ] ::=3D ::=3D {} {} ::=3D [] ::=3D - ::=3D [ ] + ::=3D [] [ ] ::=3D ::=3D if (pcddatumtype =3D=3D "BOOLEAN"): {} {} elif (pcddatumtype =3D=3D "UINT8"): {} {} @@ -721,11 +721,11 @= @ sections of the DSC file. ::=3D {} {} [ ] ::=3D ::=3D {} {} ::=3D [] ::=3D - ::=3D [ ] + ::=3D [] [ ] ::=3D ::=3D if (pcddatumtype =3D=3D "BOOLEAN"): {} {} elif (pcddatumtype =3D=3D "UINT8"): {} {} -- 2.20.1.windows.1