[Patch 1/2] BaseTools: split long line into multiple short lines.

[Patch 1/2] BaseTools: split long line into multiple short lines.

[Bob Feng]

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1764

To be easy to review in future, split the long line into
multiple shorter lines.

Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
 BaseTools/Source/C/Makefiles/header.makefile | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/BaseTools/Source/C/Makefiles/header.makefile b/BaseTools/Source/C/Makefiles/header.makefile
index 90fb3453ad..c2397b796c 100644
--- a/BaseTools/Source/C/Makefiles/header.makefile
+++ b/BaseTools/Source/C/Makefiles/header.makefile
@@ -66,13 +66,16 @@ BUILD_CPPFLAGS = $(INCLUDE)
 # keep EXTRA_OPTFLAGS last
 BUILD_OPTFLAGS = -O2 $(EXTRA_OPTFLAGS)
 
 ifeq ($(DARWIN),Darwin)
 # assume clang or clang compatible flags on OS X
-BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-self-assign -Wno-unused-result -nostdlib -g
+BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror \
+-Wno-deprecated-declarations -Wno-self-assign -Wno-unused-result -nostdlib -g
 else
-BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-stringop-truncation -Wno-restrict -Wno-unused-result -nostdlib -g
+BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror \
+-Wno-deprecated-declarations -Wno-stringop-truncation -Wno-restrict \
+-Wno-unused-result -nostdlib -g
 endif
 BUILD_LFLAGS =
 BUILD_CXXFLAGS = -Wno-unused-result
 
 ifeq ($(HOST_ARCH), IA32)
-- 
2.20.1.windows.1

Re: [edk2-devel] [Patch 1/2] BaseTools: split long line into multiple short lines.

[Laszlo Ersek]

Hi Bob,

On 04/30/19 13:06, Bob Feng wrote:
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1764
> 
> To be easy to review in future, split the long line into
> multiple shorter lines.
> 
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
>  BaseTools/Source/C/Makefiles/header.makefile | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/BaseTools/Source/C/Makefiles/header.makefile b/BaseTools/Source/C/Makefiles/header.makefile
> index 90fb3453ad..c2397b796c 100644
> --- a/BaseTools/Source/C/Makefiles/header.makefile
> +++ b/BaseTools/Source/C/Makefiles/header.makefile
> @@ -66,13 +66,16 @@ BUILD_CPPFLAGS = $(INCLUDE)
>  # keep EXTRA_OPTFLAGS last
>  BUILD_OPTFLAGS = -O2 $(EXTRA_OPTFLAGS)
>  
>  ifeq ($(DARWIN),Darwin)
>  # assume clang or clang compatible flags on OS X
> -BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-self-assign -Wno-unused-result -nostdlib -g
> +BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror \
> +-Wno-deprecated-declarations -Wno-self-assign -Wno-unused-result -nostdlib -g
>  else
> -BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-stringop-truncation -Wno-restrict -Wno-unused-result -nostdlib -g
> +BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror \
> +-Wno-deprecated-declarations -Wno-stringop-truncation -Wno-restrict \
> +-Wno-unused-result -nostdlib -g
>  endif
>  BUILD_LFLAGS =
>  BUILD_CXXFLAGS = -Wno-unused-result
>  
>  ifeq ($(HOST_ARCH), IA32)
> 

can you please configure your git setup to post the patches in a patch
series with "shallow threading"? (That is, there should be one cover
letter email, and all the patches should be direct "responses" to the
cover letter email.)

For this patch:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


Thanks
Laszlo

Re: [edk2-devel] [Patch 1/2] BaseTools: split long line into multiple short lines.

[Bob Feng]

Yes. I'll create cover letter email for patch series in next time.

-----Original Message-----
From: Laszlo Ersek [mailto:lersek@redhat.com] 
Sent: Wednesday, May 1, 2019 12:05 AM
To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>
Cc: Gao, Liming <liming.gao@intel.com>
Subject: Re: [edk2-devel] [Patch 1/2] BaseTools: split long line into multiple short lines.

Hi Bob,

On 04/30/19 13:06, Bob Feng wrote:
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1764
> 
> To be easy to review in future, split the long line into multiple 
> shorter lines.
> 
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
>  BaseTools/Source/C/Makefiles/header.makefile | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/BaseTools/Source/C/Makefiles/header.makefile 
> b/BaseTools/Source/C/Makefiles/header.makefile
> index 90fb3453ad..c2397b796c 100644
> --- a/BaseTools/Source/C/Makefiles/header.makefile
> +++ b/BaseTools/Source/C/Makefiles/header.makefile
> @@ -66,13 +66,16 @@ BUILD_CPPFLAGS = $(INCLUDE)  # keep EXTRA_OPTFLAGS 
> last  BUILD_OPTFLAGS = -O2 $(EXTRA_OPTFLAGS)
>  
>  ifeq ($(DARWIN),Darwin)
>  # assume clang or clang compatible flags on OS X -BUILD_CFLAGS = -MD 
> -fshort-wchar -fno-strict-aliasing -Wall -Werror 
> -Wno-deprecated-declarations -Wno-self-assign -Wno-unused-result 
> -nostdlib -g
> +BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror \ 
> +-Wno-deprecated-declarations -Wno-self-assign -Wno-unused-result 
> +-nostdlib -g
>  else
> -BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror 
> -Wno-deprecated-declarations -Wno-stringop-truncation -Wno-restrict 
> -Wno-unused-result -nostdlib -g
> +BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror \ 
> +-Wno-deprecated-declarations -Wno-stringop-truncation -Wno-restrict \ 
> +-Wno-unused-result -nostdlib -g
>  endif
>  BUILD_LFLAGS =
>  BUILD_CXXFLAGS = -Wno-unused-result
>  
>  ifeq ($(HOST_ARCH), IA32)
> 

can you please configure your git setup to post the patches in a patch series with "shallow threading"? (That is, there should be one cover letter email, and all the patches should be direct "responses" to the cover letter email.)

For this patch:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


Thanks
Laszlo