From: "Bob Feng" <bob.c.feng@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [Patch] BaseTools: Remove './SecMain' from 'run' target
Date: Fri, 10 May 2019 07:34:15 +0000 [thread overview]
Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D16010A5F3@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4466B8@SHSMSX104.ccr.corp.intel.com>
I think NT32Pkg need a POSTBUILD scripts to execute its run command.
-----Original Message-----
From: Gao, Liming
Sent: Friday, May 10, 2019 3:26 PM
To: Feng, Bob C <bob.c.feng@intel.com>; devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [Patch] BaseTools: Remove './SecMain' from 'run' target
Bob:
Please make sure run command still works on NT32 platform.
>-----Original Message-----
>From: Feng, Bob C
>Sent: Friday, May 10, 2019 2:34 PM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
><liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
>Subject: [Patch] BaseTools: Remove './SecMain' from 'run' target
>
>BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1561
>
>When a target of 'run' is passed into build.py, BaseTools
>unconditionally attempts to execute the application called './SecMain'
>in the build output directory.
>
>This behavior applies to the Nt32Pkg which is being replaced with
>features in the EmulatorPkg.
>
>Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>---
> BaseTools/Source/Python/build/build.py | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/BaseTools/Source/Python/build/build.py
>b/BaseTools/Source/Python/build/build.py
>index 7271570d29..04f266abf5 100644
>--- a/BaseTools/Source/Python/build/build.py
>+++ b/BaseTools/Source/Python/build/build.py
>@@ -1225,14 +1225,10 @@ class Build():
>
> makefile =
>GenMake.BuildFile(AutoGenObject)._FILE_NAME_[GenMake.gMakeType]
>
> # run
> if Target == 'run':
>- RunDir = os.path.normpath(os.path.join(AutoGenObject.BuildDir,
>GlobalData.gGlobalDefines['ARCH']))
>- Command = '.\SecMain'
>- os.chdir(RunDir)
>- LaunchCommand(Command, RunDir)
> return True
>
> # build modules
> if BuildModule:
> BuildCommand = BuildCommand + [Target]
>--
>2.20.1.windows.1
next prev parent reply other threads:[~2019-05-10 7:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 6:33 [Patch] BaseTools: Remove './SecMain' from 'run' target Bob Feng
2019-05-10 7:25 ` Liming Gao
2019-05-10 7:34 ` Bob Feng [this message]
2019-05-21 15:06 ` Liming Gao
2019-05-21 15:44 ` Michael D Kinney
2019-05-22 1:05 ` Bob Feng
2019-05-22 22:30 ` Michael D Kinney
2019-05-23 1:54 ` Bob Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08650203BA1BD64D8AD9B6D5D74A85D16010A5F3@SHSMSX101.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox