From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: bob.c.feng@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Fri, 10 May 2019 00:34:20 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2019 00:34:19 -0700 X-ExtLoop1: 1 Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 10 May 2019 00:34:18 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 10 May 2019 00:34:18 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 10 May 2019 00:34:17 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.129]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.213]) with mapi id 14.03.0415.000; Fri, 10 May 2019 15:34:16 +0800 From: "Bob Feng" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Kinney, Michael D" Subject: Re: [Patch] BaseTools: Remove './SecMain' from 'run' target Thread-Topic: [Patch] BaseTools: Remove './SecMain' from 'run' target Thread-Index: AQHVBvpWjYakGzkbJEGDZvTEKnWOq6ZjbxaAgACG3tA= Date: Fri, 10 May 2019 07:34:15 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D16010A5F3@SHSMSX101.ccr.corp.intel.com> References: <20190510063336.27928-1-bob.c.feng@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4466B8@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4466B8@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I think NT32Pkg need a POSTBUILD scripts to execute its run command. -----Original Message----- From: Gao, Liming=20 Sent: Friday, May 10, 2019 3:26 PM To: Feng, Bob C ; devel@edk2.groups.io Cc: Kinney, Michael D Subject: RE: [Patch] BaseTools: Remove './SecMain' from 'run' target Bob: Please make sure run command still works on NT32 platform.=20 >-----Original Message----- >From: Feng, Bob C >Sent: Friday, May 10, 2019 2:34 PM >To: devel@edk2.groups.io >Cc: Feng, Bob C ; Gao, Liming=20 >; Kinney, Michael D >Subject: [Patch] BaseTools: Remove './SecMain' from 'run' target > >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1561 > >When a target of 'run' is passed into build.py, BaseTools=20 >unconditionally attempts to execute the application called './SecMain'=20 >in the build output directory. > >This behavior applies to the Nt32Pkg which is being replaced with=20 >features in the EmulatorPkg. > >Signed-off-by: Bob Feng >Cc: Liming Gao >Cc: Michael D Kinney >--- > BaseTools/Source/Python/build/build.py | 4 ---- > 1 file changed, 4 deletions(-) > >diff --git a/BaseTools/Source/Python/build/build.py >b/BaseTools/Source/Python/build/build.py >index 7271570d29..04f266abf5 100644 >--- a/BaseTools/Source/Python/build/build.py >+++ b/BaseTools/Source/Python/build/build.py >@@ -1225,14 +1225,10 @@ class Build(): > > makefile =3D >GenMake.BuildFile(AutoGenObject)._FILE_NAME_[GenMake.gMakeType] > > # run > if Target =3D=3D 'run': >- RunDir =3D os.path.normpath(os.path.join(AutoGenObject.BuildD= ir, >GlobalData.gGlobalDefines['ARCH'])) >- Command =3D '.\SecMain' >- os.chdir(RunDir) >- LaunchCommand(Command, RunDir) > return True > > # build modules > if BuildModule: > BuildCommand =3D BuildCommand + [Target] >-- >2.20.1.windows.1