From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: bob.c.feng@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Thu, 16 May 2019 18:16:20 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 May 2019 18:16:19 -0700 X-ExtLoop1: 1 Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 16 May 2019 18:16:19 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 16 May 2019 18:16:19 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 16 May 2019 18:16:18 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.129]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.10]) with mapi id 14.03.0415.000; Fri, 17 May 2019 09:16:16 +0800 From: "Bob Feng" To: "devel@edk2.groups.io" , "Gao, Liming" Subject: Re: [edk2-devel] [Patch 6/7] BaseTools: Add new CLANG8ELF tool chain for new LLVM/CLANG8 Thread-Topic: [edk2-devel] [Patch 6/7] BaseTools: Add new CLANG8ELF tool chain for new LLVM/CLANG8 Thread-Index: AQHU/D5mbkIihL6lTESi0xRjNwi0l6Zuos7w Date: Fri, 17 May 2019 01:16:16 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D16010F51B@SHSMSX101.ccr.corp.intel.com> References: <20190426144242.19024-1-liming.gao@intel.com> <20190426144242.19024-7-liming.gao@intel.com> In-Reply-To: <20190426144242.19024-7-liming.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The Basetools patch is good for me. For this single patch, Reviewed-by: Bob Feng -----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Limi= ng Gao Sent: Friday, April 26, 2019 10:43 PM To: devel@edk2.groups.io Subject: [edk2-devel] [Patch 6/7] BaseTools: Add new CLANG8ELF tool chain = for new LLVM/CLANG8 BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D1603 LLVM/CLANG8 formal release http://releases.llvm.org/download.html#8.0.0 It can be downloaded and installed in Windows/Linux/Mac OS. CLANG8ELF tool chain is added to generate ELF image, and convert to PE/COF= F. On Windows OS, set CLANG_HOST_BIN=3Dn, set CLANG8_BIN=3DLLVM installed dir= ectory For example: set CLANG_HOST_BIN=3Dn # use windows nmake set CLANG8_BIN=3DC:\Program Files\LLVM\bin\ On Linux/Mac, set CLANG8_BIN= = =3DLLVM installed directory This tool chain can be used to compile the firmware code. On windows OS, V= isual Studio is still required to compile BaseTools C tools and nmake.exe. On Linux/Mac OS, gcc is used to compile BaseTools C tools. make is used fo= r makefile. This tool chain is verified on OVMF Ia32, X64 and Ia32X64 to boot Shell. This tool chain is verified in Windows/Linux and Mac OS. Signed-off-by: Liming Gao --- BaseTools/Conf/tools_def.template | 105 +++++++++++++++++++++++++++++++++= +++++ 1 file changed, 105 insertions(+) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.= template index 29dc24774a..3d95a3a6a2 100755 --- a/BaseTools/Conf/tools_def.template +++ b/BaseTools/Conf/tools_def.template @@ -255,6 +255,13 @@ DEFINE DTC_BIN =3D ENV(DTC_PREFIX)dtc # Required to build platforms or ACPI tables: # Intel(r) ACPI Compiler from # https://acpica.org/downloads +# CLANG8ELF -Linux,Windows,Mac- Requires: +# LLVM 8.0.0 or above, https://llvm.org/ +# On Windows OS, Visual Studio is required to= be installed for nmake and compile BaseTools C tools. +# Optional: +# Required to build platforms or ACPI tables: +# Intel(r) ACPI Compiler from +# https://acpica.org/downloads # VS2008xASL -win32- Requires: # Microsoft Visual Studio 2008 Team Suite # Microsoft Windows Server 2003 Driver Develo= pment Kit (Microsoft WINDDK) version 3790.1830 @@ -3776,7 +3783,105 @@ DEFINE CLANG38_AARCH64_DLINK_FLAGS =3D DEF(CLANG3= 8_AARCH64_TARGET) DEF(GCC_AARCH6 RELEASE_CLANG38_AARCH64_CC_FLAGS =3D DEF(CLANG38_AARCH64_CC_FLAGS) $(A= RCHCC_FLAGS) $(PLATFORM_FLAGS) -flto -O3 RELEASE_CLANG38_AARCH64_DLINK_FLAGS =3D DEF(CLANG38_AARCH64_DLINK_FLAGS) = -flto -Wl,-O3 -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-aarch64 -Wl,-plugi= n-opt=3D-pass-through=3D-llto-aarch64 =20 +####################################################################### +############# +# +# Clang 8.0.0 - This configuration is used to compile under Windows,=20 +Linux, Mac to # produce ELF image, and convert to PE/COFF image using=20 +LLVM/CLANG 8.0 with LTO #=20 +#########################################################################= ########### +*_CLANG8ELF_*_*_FAMILY =3D GCC +*_CLANG8ELF_*_*_BUILDRULEFAMILY =3D CLANGGCC +*_CLANG8ELF_*_MAKE_PATH =3D ENV(CLANG_HOST_BIN)make +*_CLANG8ELF_*_*_DLL =3D ENV(CLANG8_DLL) +*_CLANG8ELF_*_ASL_PATH =3D DEF(UNIX_IASL_BIN) + +*_CLANG8ELF_*_APP_FLAGS =3D +*_CLANG8ELF_*_ASL_FLAGS =3D DEF(IASL_FLAGS) +*_CLANG8ELF_*_ASL_OUTFLAGS =3D DEF(IASL_OUTFLAGS) + +DEFINE CLANG8ELF_IA32_PREFIX =3D ENV(CLANG8_BIN) +DEFINE CLANG8ELF_X64_PREFIX =3D ENV(CLANG8_BIN) + +# LLVM/CLANG doesn't support -n link option. So, it can't share the same = IA32_X64_DLINK_COMMON flag. +# LLVM/CLANG doesn't support common page size. So, it can't share the sam= e GccBase.lds script. +DEFINE CLANG8ELF_IA32_X64_DLINK_COMMON =3D -nostdlib -Wl,-q,--gc-sectio= ns -z max-page-size=3D0x40 +DEFINE CLANG8ELF_DLINK2_FLAGS_COMMON =3D -Wl,--script=3D$(EDK_TOOLS_P= ATH)/Scripts/ClangBase.lds +DEFINE CLANG8ELF_IA32_X64_ASLDLINK_FLAGS =3D DEF(CLANG8ELF_IA32_X64_DLINK= _COMMON) -Wl,--defsym=3DPECOFF_HEADER_SIZE=3D0 DEF(CLANG8ELF_DLINK2_FLAGS_C= OMMON) -Wl,--entry,ReferenceAcpiTable -u ReferenceAcpiTable +DEFINE CLANG8ELF_IA32_X64_DLINK_FLAGS =3D DEF(CLANG8ELF_IA32_X64_DLINK= _COMMON) -Wl,--entry,$(IMAGE_ENTRY_POINT) -u $(IMAGE_ENTRY_POINT) -Wl,-Map,= $(DEST_DIR_DEBUG)/$(BASE_NAME).map,--whole-archive +DEFINE CLANG8ELF_IA32_DLINK2_FLAGS =3D -Wl,--defsym=3DPECOFF_HEADER= _SIZE=3D0x220 DEF(CLANG8ELF_DLINK2_FLAGS_COMMON) +DEFINE CLANG8ELF_X64_DLINK2_FLAGS =3D -Wl,--defsym=3DPECOFF_HEADER= _SIZE=3D0x228 DEF(CLANG8ELF_DLINK2_FLAGS_COMMON) + +########################### +# CLANG8ELF IA32 definitions +########################### +*_CLANG8ELF_IA32_CC_PATH =3D DEF(CLANG8ELF_IA32_PREFIX)clang +*_CLANG8ELF_IA32_SLINK_PATH =3D DEF(CLANG8ELF_IA32_PREFIX)llvm-= ar +*_CLANG8ELF_IA32_DLINK_PATH =3D DEF(CLANG8ELF_IA32_PREFIX)clang +*_CLANG8ELF_IA32_ASLDLINK_PATH =3D DEF(CLANG8ELF_IA32_PREFIX)clang +*_CLANG8ELF_IA32_ASM_PATH =3D DEF(CLANG8ELF_IA32_PREFIX)clang +*_CLANG8ELF_IA32_PP_PATH =3D DEF(CLANG8ELF_IA32_PREFIX)clang +*_CLANG8ELF_IA32_VFRPP_PATH =3D DEF(CLANG8ELF_IA32_PREFIX)clang +*_CLANG8ELF_IA32_ASLCC_PATH =3D DEF(CLANG8ELF_IA32_PREFIX)clang +*_CLANG8ELF_IA32_ASLPP_PATH =3D DEF(CLANG8ELF_IA32_PREFIX)clang +*_CLANG8ELF_IA32_RC_PATH =3D DEF(CLANG8ELF_IA32_PREFIX)llvm-= rc + +*_CLANG8ELF_IA32_ASLCC_FLAGS =3D DEF(GCC_ASLCC_FLAGS) -m32 -fno-= lto DEF(CLANG38_IA32_TARGET) +*_CLANG8ELF_IA32_ASLDLINK_FLAGS =3D DEF(CLANG8ELF_IA32_X64_ASLDLINK= _FLAGS) -Wl,-m,elf_i386 -fuse-ld=3Dlld +*_CLANG8ELF_IA32_ASM_FLAGS =3D DEF(GCC5_ASM_FLAGS) -m32 -march= = =3Di386 DEF(CLANG38_IA32_TARGET) +*_CLANG8ELF_IA32_RC_FLAGS =3D DEF(GCC_IA32_RC_FLAGS) +*_CLANG8ELF_IA32_OBJCOPY_FLAGS =3D +*_CLANG8ELF_IA32_NASM_FLAGS =3D -f elf32 +*_CLANG8ELF_IA32_PP_FLAGS =3D DEF(GCC_PP_FLAGS) DEF(CLANG38_I= A32_TARGET) +*_CLANG8ELF_IA32_ASLPP_FLAGS =3D DEF(GCC_ASLPP_FLAGS) DEF(CLANG3= 8_IA32_TARGET) +*_CLANG8ELF_IA32_VFRPP_FLAGS =3D DEF(GCC_VFRPP_FLAGS) DEF(CLANG3= 8_IA32_TARGET) + +DEBUG_CLANG8ELF_IA32_CC_FLAGS =3D DEF(CLANG38_ALL_CC_FLAGS) -m32 = -Oz -flto -march=3Di586 DEF(CLANG38_IA32_TARGET) -g +DEBUG_CLANG8ELF_IA32_DLINK_FLAGS =3D DEF(CLANG8ELF_IA32_X64_DLINK_FL= AGS) -flto -Wl,-O3 -Wl,-melf_i386 -Wl,--oformat,elf32-i386 +DEBUG_CLANG8ELF_IA32_DLINK2_FLAGS =3D DEF(CLANG8ELF_IA32_DLINK2_FLAGS= ) -O3 -fuse-ld=3Dlld + +RELEASE_CLANG8ELF_IA32_CC_FLAGS =3D DEF(CLANG38_ALL_CC_FLAGS) -m32 = -Oz -flto -march=3Di586 DEF(CLANG38_IA32_TARGET) +RELEASE_CLANG8ELF_IA32_DLINK_FLAGS =3D DEF(CLANG8ELF_IA32_X64_DLINK_FL= AGS) -flto -Wl,-O3 -Wl,-melf_i386 -Wl,--oformat,elf32-i386 +RELEASE_CLANG8ELF_IA32_DLINK2_FLAGS =3D DEF(CLANG8ELF_IA32_DLINK2_FLAGS= ) -O3 -fuse-ld=3Dlld + +NOOPT_CLANG8ELF_IA32_CC_FLAGS =3D DEF(CLANG38_ALL_CC_FLAGS) -m32 = -O0 -march=3Di586 DEF(CLANG38_IA32_TARGET) -g +NOOPT_CLANG8ELF_IA32_DLINK_FLAGS =3D DEF(CLANG8ELF_IA32_X64_DLINK_FL= AGS) -Wl,-O0 -Wl,-melf_i386 -Wl,--oformat,elf32-i386 +NOOPT_CLANG8ELF_IA32_DLINK2_FLAGS =3D DEF(CLANG8ELF_IA32_DLINK2_FLAGS= ) -O0 -fuse-ld=3Dlld =20 +########################## +# CLANG8ELF X64 definitions +########################## +*_CLANG8ELF_X64_CC_PATH =3D DEF(CLANG8ELF_X64_PREFIX)clang +*_CLANG8ELF_X64_SLINK_PATH =3D DEF(CLANG8ELF_X64_PREFIX)llvm-ar +*_CLANG8ELF_X64_DLINK_PATH =3D DEF(CLANG8ELF_X64_PREFIX)clang +*_CLANG8ELF_X64_ASLDLINK_PATH =3D DEF(CLANG8ELF_X64_PREFIX)clang +*_CLANG8ELF_X64_ASM_PATH =3D DEF(CLANG8ELF_X64_PREFIX)clang +*_CLANG8ELF_X64_PP_PATH =3D DEF(CLANG8ELF_X64_PREFIX)clang +*_CLANG8ELF_X64_VFRPP_PATH =3D DEF(CLANG8ELF_X64_PREFIX)clang +*_CLANG8ELF_X64_ASLCC_PATH =3D DEF(CLANG8ELF_X64_PREFIX)clang +*_CLANG8ELF_X64_ASLPP_PATH =3D DEF(CLANG8ELF_X64_PREFIX)clang +*_CLANG8ELF_X64_RC_PATH =3D DEF(CLANG8ELF_X64_PREFIX)llvm-rc + +*_CLANG8ELF_X64_ASLCC_FLAGS =3D DEF(GCC_ASLCC_FLAGS) -m64 -fno-l= to DEF(CLANG38_X64_TARGET) +*_CLANG8ELF_X64_ASLDLINK_FLAGS =3D DEF(CLANG8ELF_IA32_X64_ASLDLINK_= FLAGS) -Wl,-m,elf_x86_64 -fuse-ld=3Dlld +*_CLANG8ELF_X64_ASM_FLAGS =3D DEF(GCC5_ASM_FLAGS) -m64 DEF(CLA= NG38_X64_TARGET) +*_CLANG8ELF_X64_RC_FLAGS =3D DEF(GCC_X64_RC_FLAGS) +*_CLANG8ELF_X64_OBJCOPY_FLAGS =3D +*_CLANG8ELF_X64_NASM_FLAGS =3D -f elf64 +*_CLANG8ELF_X64_PP_FLAGS =3D DEF(GCC_PP_FLAGS) DEF(CLANG38_X6= 4_TARGET) +*_CLANG8ELF_X64_ASLPP_FLAGS =3D DEF(GCC_ASLPP_FLAGS) DEF(CLANG38= _X64_TARGET) +*_CLANG8ELF_X64_VFRPP_FLAGS =3D DEF(GCC_VFRPP_FLAGS) DEF(CLANG38= _X64_TARGET) + +DEBUG_CLANG8ELF_X64_CC_FLAGS =3D DEF(CLANG38_ALL_CC_FLAGS) -m64 "= -DEFIAPI=3D__attribute__((ms_abi))" -mno-red-zone -mcmodel=3Dsmall -fpie -O= z -flto DEF(CLANG38_X64_TARGET) -g +DEBUG_CLANG8ELF_X64_DLINK_FLAGS =3D DEF(CLANG8ELF_IA32_X64_DLINK_FLA= GS) -flto -Wl,-O3 -Wl,-melf_x86_64 -Wl,--oformat,elf64-x86-64 -Wl,-pie -mcm= odel=3Dsmall -Wl,--apply-dynamic-relocs +DEBUG_CLANG8ELF_X64_DLINK2_FLAGS =3D DEF(CLANG8ELF_X64_DLINK2_FLAGS) = -O3 -fuse-ld=3Dlld + +RELEASE_CLANG8ELF_X64_CC_FLAGS =3D DEF(CLANG38_ALL_CC_FLAGS) -m64 "= -DEFIAPI=3D__attribute__((ms_abi))" -mno-red-zone -mcmodel=3Dsmall -fpie -O= z -flto DEF(CLANG38_X64_TARGET) +RELEASE_CLANG8ELF_X64_DLINK_FLAGS =3D DEF(CLANG8ELF_IA32_X64_DLINK_FLA= GS) -flto -Wl,-O3 -Wl,-melf_x86_64 -Wl,--oformat,elf64-x86-64 -Wl,-pie -mcm= odel=3Dsmall -Wl,--apply-dynamic-relocs +RELEASE_CLANG8ELF_X64_DLINK2_FLAGS =3D DEF(CLANG8ELF_X64_DLINK2_FLAGS) = -O3 -fuse-ld=3Dlld + +NOOPT_CLANG8ELF_X64_CC_FLAGS =3D DEF(CLANG38_ALL_CC_FLAGS) -m64 "= -DEFIAPI=3D__attribute__((ms_abi))" -mno-red-zone -mcmodel=3Dsmall -fpie -O= 0 DEF(CLANG38_X64_TARGET) -g +NOOPT_CLANG8ELF_X64_DLINK_FLAGS =3D DEF(CLANG8ELF_IA32_X64_DLINK_FLA= GS) -Wl,-O0 -Wl,-melf_x86_64 -Wl,--oformat,elf64-x86-64 -Wl,-pie -mcmodel= =3Dsmall -Wl,--apply-dynamic-relocs +NOOPT_CLANG8ELF_X64_DLINK2_FLAGS =3D DEF(CLANG8ELF_X64_DLINK2_FLAGS) = -O0 -fuse-ld=3Dlld =20 # # -- 2.13.0.windows.1