From: "Bob Feng" <bob.c.feng@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-devel] [FdfSpecification Patch] FDF spec: Fix the issue in Rule section for RAW Type File
Date: Wed, 29 May 2019 07:20:57 +0000 [thread overview]
Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D16011773F@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20190528152426.17988-1-liming.gao@intel.com>
Patch looks fine.
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming Gao
Sent: Tuesday, May 28, 2019 11:24 PM
To: devel@edk2.groups.io
Subject: [edk2-devel] [FdfSpecification Patch] FDF spec: Fix the issue in Rule section for RAW Type File
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1765
FV File Statement clarifies RAW File type with file name only.
But, FFS Rule section doesn't support this syntax. This is an issue in FDF spec. Per PI spec, RAW File has no section. It directly includes file data. So, FFS Rule section should support this usage.
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
3_edk_ii_fdf_file_format/39_[rule]_sections.md | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/3_edk_ii_fdf_file_format/39_[rule]_sections.md b/3_edk_ii_fdf_file_format/39_[rule]_sections.md
index 34e767f..d5ec895 100644
--- a/3_edk_ii_fdf_file_format/39_[rule]_sections.md
+++ b/3_edk_ii_fdf_file_format/39_[rule]_sections.md
@@ -125,7 +125,8 @@ Conditional statements may be used anywhere within this section.
<FileOpts> ::= ["Fixed" <MTS>] ["Checksum" <MTS>]
[<FfsAlignment>]
<FfsAlignment> ::= "Align" <Eq> <FfsAlignmentValues> <MTS>
-<FileSpec> ::= {<SimpleFile>} {<ComplexFile>} {<SbtGuid>}
+<FileSpec> ::= {<SimpleFile>} {<ComplexFile>} {<SbtGuid>} {<DataFile>}
+<DataFile> ::= "{" <VarFile> "}"
<SimpleFile> ::= <LeafSecType> [<FileOpts>] <VarFile> <EOL>
<LeafSecType> ::= {"COMPAT16"} {"PE32"} {"PIC"} {"TE"}
{"FV_IMAGE"} {"RAW"} {"DXE_DEPEX"} {"UI"}
--
2.13.0.windows.1
prev parent reply other threads:[~2019-05-29 7:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 15:24 [FdfSpecification Patch] FDF spec: Fix the issue in Rule section for RAW Type File Liming Gao
2019-05-29 7:20 ` Bob Feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08650203BA1BD64D8AD9B6D5D74A85D16011773F@SHSMSX101.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox