From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: bob.c.feng@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Wed, 29 May 2019 19:18:45 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 May 2019 19:18:44 -0700 X-ExtLoop1: 1 Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 29 May 2019 19:18:44 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 29 May 2019 19:18:43 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 29 May 2019 19:18:43 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.10]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.187]) with mapi id 14.03.0415.000; Thu, 30 May 2019 10:18:41 +0800 From: "Bob Feng" To: "devel@edk2.groups.io" , "Shi, Steven" CC: "Gao, Liming" , "Rodriguez, Christian" , "Fan, ZhijuX" Subject: Re: [edk2-devel] [PATCH] BaseTools:Update binary cache restore time to current time Thread-Topic: [edk2-devel] [PATCH] BaseTools:Update binary cache restore time to current time Thread-Index: AQHVFTBV+AfZEtq1Pk+3LX6TldhExaaC8TFQ Date: Thu, 30 May 2019 02:18:40 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D1601260C0@SHSMSX101.ccr.corp.intel.com> References: <20190528083514.22636-1-steven.shi@intel.com> In-Reply-To: <20190528083514.22636-1-steven.shi@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Stev= en Shi Sent: Tuesday, May 28, 2019 4:35 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C = ; Rodriguez, Christian ; Fan, ZhijuX Subject: [edk2-devel] [PATCH] BaseTools:Update binary cache restore time t= o current time https://bugzilla.tianocore.org/show_bug.cgi?id=3D1742 Current Binary Cache doesn't update the restored file creation and modific= ation times to the current time. Preserve the new restored file creation time as old cached time might has = potential issue to block the make to build updated files based on the time = stamp. Enhance to update the restored file creation time to current time. Cc: Liming Gao Cc: Bob Feng Cc: Zhiju Fan Signed-off-by: Steven Shi --- BaseTools/Source/Python/AutoGen/AutoGen.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source= /Python/AutoGen/AutoGen.py index a5bef4f7c6..57ca67f692 100644 --- a/BaseTools/Source/Python/AutoGen/AutoGen.py +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py @@ -3941,14 +3941,14 @@ class ModuleAutoGen(AutoGen): for root, dir, files in os.walk(FileDir): for f in files: if self.Name + '.hash' in f: - shutil.copy2(HashFile, self.BuildDir) + shutil.copy(HashFile, self.BuildDir) else: File =3D path.join(root, f) sub_dir =3D os.path.relpath(File, FileDir= ) destination_file =3D os.path.join(self.Ou= tputDir, sub_dir) destination_dir =3D os.path.dirname(desti= nation_file) CreateDirectory(destination_dir) - shutil.copy2(File, destination_dir) + shutil.copy(File, destination_dir) if self.Name =3D=3D "PcdPeim" or self.Name =3D=3D "Pc= dDxe": CreatePcdDatabaseCode(self, TemplateString(), Tem= plateString()) return True -- 2.17.1.windows.2