From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: bob.c.feng@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Wed, 29 May 2019 19:44:26 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 May 2019 19:44:25 -0700 X-ExtLoop1: 1 Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 29 May 2019 19:44:25 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 29 May 2019 19:44:25 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.10]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.137]) with mapi id 14.03.0415.000; Thu, 30 May 2019 10:44:22 +0800 From: "Bob Feng" To: "devel@edk2.groups.io" , "Shi, Steven" CC: "Gao, Liming" , "Rodriguez, Christian" , "Fan, ZhijuX" Subject: Re: [edk2-devel] [PATCH v3 1/1] BaseTools:Extend the binary cache to support library cache Thread-Topic: [edk2-devel] [PATCH v3 1/1] BaseTools:Extend the binary cache to support library cache Thread-Index: AQHVFo/aejTzv1YSk0WROrd4YZawiqaC9KKg Date: Thu, 30 May 2019 02:44:21 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D16012613D@SHSMSX101.ccr.corp.intel.com> References: <20190530023127.23228-1-steven.shi@intel.com> <20190530023127.23228-2-steven.shi@intel.com> In-Reply-To: <20190530023127.23228-2-steven.shi@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The "entend" should be "extend", right? I can fix it when I push this patch= . Reviewed-by: Bob Feng -----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Stev= en Shi Sent: Thursday, May 30, 2019 10:31 AM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C = ; Rodriguez, Christian ; Fan, ZhijuX Subject: [edk2-devel] [PATCH v3 1/1] BaseTools:Extend the binary cache to = support library cache https://bugzilla.tianocore.org/show_bug.cgi?id=3D1797 Current binary cache doesn't support to save and restore the library modul= e. If a driver module cache miss happen, all its dependency library modules= need rebuild which is very time-consuming. This patch is to entend the bin= ary cache to support library. Cc: Liming Gao Cc: Bob Feng Cc: Christian Rodriguez Signed-off-by: Steven Shi --- BaseTools/Source/Python/AutoGen/AutoGen.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source= /Python/AutoGen/AutoGen.py index a5bef4f7c6..7b35f837f5 100644 --- a/BaseTools/Source/Python/AutoGen/AutoGen.py +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py @@ -3906,6 +3906,12 @@ class ModuleAutoGen(AutoGen): ModuleFile =3D path.join(self.OutputDir, self.Name + '.inf') if os.path.exists(ModuleFile): shutil.copy2(ModuleFile, FileDir) + else: + OutputDir =3D self.OutputDir.replace('\\', '/').strip('/') + DebugDir =3D self.DebugDir.replace('\\', '/').strip('/') + for Item in self.CodaTargetList: + File =3D Item.Target.Path.replace('\\', '/').strip('/').r= eplace(DebugDir, '').replace(OutputDir, '').strip('/') + self.OutputFile.add(File) if not self.OutputFile: Ma =3D self.BuildDatabase[self.MetaFile, self.Arch, self.Buil= dTarget, self.ToolChain] self.OutputFile =3D Ma.Binaries -- 2.17.1.windows.2