Re: Edk2 BaseTools Patches.

["Bob Feng" <bob.c.feng@intel.com>]

Thanks Christian. I add some short description for the patches.

These 5 patches are all for binary cache feature.

 [Patch V4 2/2] BaseTools: Refactor hash tracking after checking for Sources section
 [Patch V4 1/2] BaseTools: Add a checking for Sources section in INF file

The above 2 patches is to fix the issue that
The  build tool uses the files list under [sources] section of INF file as a input to calculate a module's hash value. But in some INF files, [sources] does not list all the "source" files, missing some .h files. Path 2/2 use another method to get all source files for a module and patch 1/2 do a check whether [sources] list all the "source" files.

[PATCH v3 1/1] BaseTools:Extend the binary cache to support library cache
This patch is to resolve the problem that
Build tool dose not cache the library binaries now. Whiteout this patch, there is 25% extra time cost to rebuild the all module dependency libraries if cache miss happen.

[PATCH] BaseTools:Update binary cache restore time to current time
This patch is to make the restored binary file have the current time stamp not the binary file original time stamp. 

[PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE
This patch is to support the raw ffs file rule. Now build tool does not correctly handle this case:
[Rule.Common.USER_DEFINED.MicroCode]
  FILE RAW = $(NAMED_GUID) {
                 $(INF_OUTPUT)/$(MODULE_NAME).bin
  }


Thanks,
Bob

-----Original Message-----
From: Rodriguez, Christian 
Sent: Thursday, May 30, 2019 10:26 PM
To: Leif Lindholm <leif.lindholm@linaro.org>; Feng, Bob C <bob.c.feng@intel.com>
Cc: Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Shi, Steven <steven.shi@intel.com>; Fan, ZhijuX <zhijux.fan@intel.com>
Subject: RE: Edk2 BaseTools Patches.

Hey Leif,

I thought I'd help Bob and gather those BZs for each thread:

[Patch V4 1/2] BaseTools: Add a checking for Sources section in INF file [Patch V4 2/2] BaseTools: Refactor hash tracking after checking for Sources section
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1804

[PATCH v3 1/1] BaseTools:Extend the binary cache to support library cache
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1797

[PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1765

[PATCH] BaseTools:Update binary cache restore time to current time
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1742

Thanks,
Christian

>-----Original Message-----
>From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
>Sent: Thursday, May 30, 2019 2:28 AM
>To: Feng, Bob C <bob.c.feng@intel.com>
>Cc: Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; 
>Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io; 
>Gao, Liming <liming.gao@intel.com>; Shi, Steven <steven.shi@intel.com>; 
>Rodriguez, Christian <christian.rodriguez@intel.com>; Fan, ZhijuX 
><zhijux.fan@intel.com>
>Subject: Re: Edk2 BaseTools Patches.
>
>Hi Bob,
>
>On Thu, May 30, 2019 at 06:39:59AM +0000, Feng, Bob C wrote:
>> Hi,
>>
>> Currently, we have 5 Basetools patches which are ready to push. Since 
>> we are in the soft-freeze phase, I'd like to ask for your opinions if 
>> those patches can be pushed to edk2 master.
>
>To save me the time of reading through all the threads and getting to 
>grips with all the code, could you summarise the problem these solve 
>and the impact of not including these?
>
>Is there a BZ?
>
>Regards,
>
>Leif
>
>>
>> These 5 patches are to fix the issues for the build cache feature.
>>
>> [Patch V4 2/2] BaseTools: Refactor hash tracking after checking for 
>> Sources section
>> https://edk2.groups.io/g/devel/topic/31835556#41642
>>
>> [Patch V4 1/2] BaseTools: Add a checking for Sources section in INF 
>> file
>> https://edk2.groups.io/g/devel/topic/31835555#41641
>>
>> [PATCH v3 1/1] BaseTools:Extend the binary cache to support library 
>> cache
>> https://edk2.groups.io/g/devel/topic/31843505#41655
>>
>> [PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW 
>> FFS FILE
>> https://edk2.groups.io/g/devel/topic/31830807#41571
>>
>> [PATCH] BaseTools:Update binary cache restore time to current time
>> https://edk2.groups.io/g/devel/topic/31819590#41468
>>
>>
>> Thanks,
>> Bob