From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: bob.c.feng@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Thu, 30 May 2019 08:06:52 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 May 2019 08:06:51 -0700 X-ExtLoop1: 1 Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 30 May 2019 08:06:51 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 30 May 2019 08:06:51 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 30 May 2019 08:06:50 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.10]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.153]) with mapi id 14.03.0415.000; Thu, 30 May 2019 23:06:49 +0800 From: "Bob Feng" To: "Rodriguez, Christian" , Leif Lindholm CC: Andrew Fish , Laszlo Ersek , "Kinney, Michael D" , "devel@edk2.groups.io" , "Gao, Liming" , "Shi, Steven" , "Fan, ZhijuX" Subject: Re: Edk2 BaseTools Patches. Thread-Topic: Edk2 BaseTools Patches. Thread-Index: AdUWjQt6T2cDiXJSSJG3vQ9oXBf1If//88EAgABTOQD//3BK4A== Date: Thu, 30 May 2019 15:06:48 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D1601296DA@SHSMSX101.ccr.corp.intel.com> References: <08650203BA1BD64D8AD9B6D5D74A85D160128393@SHSMSX101.ccr.corp.intel.com> <20190530092802.7belyzgxdd76ps2v@bivouac.eciton.net> <3A7DCC9A944C6149BF832E1C9B718ABC01F24E6B@ORSMSX112.amr.corp.intel.com> In-Reply-To: <3A7DCC9A944C6149BF832E1C9B718ABC01F24E6B@ORSMSX112.amr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGQ0Y2E5ODYtNzk1Ny00MzQwLTk3YzYtNjQ3MzcyNzAzMjEwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSWxpdWlpUHhtaU53clwvQkpBWnk2Vk54cFN3b2tQRlF6NHZyWDFYQ3pxaUoxNlY1M3phQTFLekR2OFwvNnorT3B1In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Christian. I add some short description for the patches. These 5 patches are all for binary cache feature. [Patch V4 2/2] BaseTools: Refactor hash tracking after checking for Source= s section [Patch V4 1/2] BaseTools: Add a checking for Sources section in INF file The above 2 patches is to fix the issue that The build tool uses the files list under [sources] section of INF file as = a input to calculate a module's hash value. But in some INF files, [sources= ] does not list all the "source" files, missing some .h files. Path 2/2 use= another method to get all source files for a module and patch 1/2 do a che= ck whether [sources] list all the "source" files. [PATCH v3 1/1] BaseTools:Extend the binary cache to support library cache This patch is to resolve the problem that Build tool dose not cache the library binaries now. Whiteout this patch, th= ere is 25% extra time cost to rebuild the all module dependency libraries i= f cache miss happen. [PATCH] BaseTools:Update binary cache restore time to current time This patch is to make the restored binary file have the current time stamp = not the binary file original time stamp.=20 [PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW FFS F= ILE This patch is to support the raw ffs file rule. Now build tool does not cor= rectly handle this case: [Rule.Common.USER_DEFINED.MicroCode] FILE RAW =3D $(NAMED_GUID) { $(INF_OUTPUT)/$(MODULE_NAME).bin } Thanks, Bob -----Original Message----- From: Rodriguez, Christian=20 Sent: Thursday, May 30, 2019 10:26 PM To: Leif Lindholm ; Feng, Bob C Cc: Andrew Fish ; Laszlo Ersek ; Kinney= , Michael D ; devel@edk2.groups.io; Gao, Liming= ; Shi, Steven ; Fan, ZhijuX Subject: RE: Edk2 BaseTools Patches. Hey Leif, I thought I'd help Bob and gather those BZs for each thread: [Patch V4 1/2] BaseTools: Add a checking for Sources section in INF file [P= atch V4 2/2] BaseTools: Refactor hash tracking after checking for Sources s= ection BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1804 [PATCH v3 1/1] BaseTools:Extend the binary cache to support library cache BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1797 [PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW FFS F= ILE BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1765 [PATCH] BaseTools:Update binary cache restore time to current time BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1742 Thanks, Christian >-----Original Message----- >From: Leif Lindholm [mailto:leif.lindholm@linaro.org] >Sent: Thursday, May 30, 2019 2:28 AM >To: Feng, Bob C >Cc: Andrew Fish ; Laszlo Ersek ;=20 >Kinney, Michael D ; devel@edk2.groups.io;=20 >Gao, Liming ; Shi, Steven ;=20 >Rodriguez, Christian ; Fan, ZhijuX=20 > >Subject: Re: Edk2 BaseTools Patches. > >Hi Bob, > >On Thu, May 30, 2019 at 06:39:59AM +0000, Feng, Bob C wrote: >> Hi, >> >> Currently, we have 5 Basetools patches which are ready to push. Since=20 >> we are in the soft-freeze phase, I'd like to ask for your opinions if=20 >> those patches can be pushed to edk2 master. > >To save me the time of reading through all the threads and getting to=20 >grips with all the code, could you summarise the problem these solve=20 >and the impact of not including these? > >Is there a BZ? > >Regards, > >Leif > >> >> These 5 patches are to fix the issues for the build cache feature. >> >> [Patch V4 2/2] BaseTools: Refactor hash tracking after checking for=20 >> Sources section >> https://edk2.groups.io/g/devel/topic/31835556#41642 >> >> [Patch V4 1/2] BaseTools: Add a checking for Sources section in INF=20 >> file >> https://edk2.groups.io/g/devel/topic/31835555#41641 >> >> [PATCH v3 1/1] BaseTools:Extend the binary cache to support library=20 >> cache >> https://edk2.groups.io/g/devel/topic/31843505#41655 >> >> [PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW=20 >> FFS FILE >> https://edk2.groups.io/g/devel/topic/31830807#41571 >> >> [PATCH] BaseTools:Update binary cache restore time to current time >> https://edk2.groups.io/g/devel/topic/31819590#41468 >> >> >> Thanks, >> Bob