From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: bob.c.feng@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Mon, 10 Jun 2019 04:44:48 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jun 2019 04:44:47 -0700 X-ExtLoop1: 1 Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 10 Jun 2019 04:44:47 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 10 Jun 2019 04:44:47 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 10 Jun 2019 04:44:46 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.10]) by shsmsx102.ccr.corp.intel.com ([169.254.2.134]) with mapi id 14.03.0415.000; Mon, 10 Jun 2019 19:44:45 +0800 From: "Bob Feng" To: "Fan, ZhijuX" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Shi, Steven" Subject: Re: [PATCH] BaseTools:Build cache support the cache files for library package Thread-Topic: [PATCH] BaseTools:Build cache support the cache files for library package Thread-Index: AdUcBtIcM5qmY8ljSiOuZFVytmt18QDer8JQ Date: Mon, 10 Jun 2019 11:44:43 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D160134EB7@SHSMSX101.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Zhiju, There is no error handle for self.CopyModuleToCache(), please don't "pass" = in except block. Thanks, Bob -----Original Message----- From: Fan, ZhijuX=20 Sent: Thursday, June 6, 2019 9:26 AM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C ;= Shi, Steven Subject: [PATCH] BaseTools:Build cache support the cache files for library = package BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D1867 Current build cache cannot store the cache for library package. build -p MdePkg\MdePkg.dsc -a IA32 -b DEBUG -t VS2015x86 --hash --binary-de= stination=3DBinCache After build, the expected result is the BinCache folde= r is generated and the MdePkg build cache files (e.g. .hash and .lib) are s= tored in the BinCache folder. But the BinCache folder is not generated at a= ll. This patch is going to fix that issue. Cc: Liming Gao Cc: Bob Feng Cc: Steven Shi Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/AutoGen/AutoGen.py | 4 ++++ 1 files changed, 4 insertions(+) diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/= Python/AutoGen/AutoGen.py index a879b6259f..b8ecf3826f 100644 --- a/BaseTools/Source/Python/AutoGen/AutoGen.py +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py @@ -3571,6 +3571,10 @@ class ModuleAutoGen(AutoGen): =20 # Skip the following code for libraries if self.IsLibrary: + try: + self.CopyModuleToCache() + except: + pass return =20 # Skip the following code for modules with no source files -- 2.14.1.windows.1