Re: [PATCH 1/2] BaseTools: add centralized location for git config files

["Bob Feng" <bob.c.feng@intel.com>]

OK. I will add the header when I do push.

Reviewed-by: Bob Feng <bob.c.feng@intel.com>

-----Original Message-----
From: Leif Lindholm [mailto:leif.lindholm@linaro.org] 
Sent: Tuesday, June 11, 2019 5:35 PM
To: Feng, Bob C <bob.c.feng@intel.com>
Cc: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong <yonghong.zhu@intel.com>; Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: Re: [PATCH 1/2] BaseTools: add centralized location for git config files

Right, I tend to think of configuration files as not-really-copyrightable.

Would you like me to send a v2, or would you be OK with me adding # # Copyright (c) 2019, Linaro Ltd. All rights reserved.
#
# SPDX-License-Identifier: BSD-2-Clause-Patent # to both files and pushing the series?

Regards

Leif

On Tue, Jun 11, 2019 at 05:25:58AM +0000, Feng, Bob C wrote:
> Hi Leif,
> 
> These 2 new file have no license header, need to add?
> 
> Thanks,
> Bob
> 
> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Monday, June 10, 2019 7:54 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming 
> <liming.gao@intel.com>; Zhu, Yonghong <yonghong.zhu@intel.com>; Andrew 
> Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Kinney, 
> Michael D <michael.d.kinney@intel.com>
> Subject: [PATCH 1/2] BaseTools: add centralized location for git 
> config files
> 
> Before adding the git environment initialization script, add the following files that will be pointed to after running said script:
> 
> - BaseTools/Conf/diff.order
> - BaseTools/Conf/gitattributes
> 
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  BaseTools/Conf/diff.order    |  8 ++++++++
>  BaseTools/Conf/gitattributes | 14 ++++++++++++++
>  2 files changed, 22 insertions(+)
>  create mode 100644 BaseTools/Conf/diff.order  create mode 100644 
> BaseTools/Conf/gitattributes
> 
> diff --git a/BaseTools/Conf/diff.order b/BaseTools/Conf/diff.order new 
> file mode 100644 index 0000000000..1d578ac28c
> --- /dev/null
> +++ b/BaseTools/Conf/diff.order
> @@ -0,0 +1,8 @@
> +*.dec
> +*.dsc.inc
> +*.dsc
> +*.fdf
> +*.inf
> +*.h
> +*.vfr
> +*.c
> diff --git a/BaseTools/Conf/gitattributes 
> b/BaseTools/Conf/gitattributes new file mode 100644 index 
> 0000000000..a8f923fd8a
> --- /dev/null
> +++ b/BaseTools/Conf/gitattributes
> @@ -0,0 +1,14 @@
> +*.efi     -diff
> +*.EFI     -diff
> +*.bin     -diff
> +*.BIN     -diff
> +*.raw     -diff
> +*.RAW     -diff
> +*.bmp     -diff
> +*.BMP     -diff
> +*.dec     diff=ini
> +*.dsc     diff=ini
> +*.dsc.inc diff=ini
> +*.fdf     diff=ini
> +*.fdf.inc diff=ini
> +*.inf     diff=ini
> --
> 2.11.0
>