From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: bob.c.feng@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Tue, 11 Jun 2019 18:07:17 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jun 2019 18:07:16 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga007.jf.intel.com with ESMTP; 11 Jun 2019 18:07:16 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 11 Jun 2019 18:07:16 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 11 Jun 2019 18:07:16 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.104]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.225]) with mapi id 14.03.0439.000; Wed, 12 Jun 2019 09:07:14 +0800 From: "Bob Feng" To: Leif Lindholm CC: "devel@edk2.groups.io" , "Gao, Liming" , "Zhu, Yonghong" , Andrew Fish , Laszlo Ersek , "Kinney, Michael D" Subject: Re: [PATCH 1/2] BaseTools: add centralized location for git config files Thread-Topic: [PATCH 1/2] BaseTools: add centralized location for git config files Thread-Index: AQHVH4M9pmoJEXKRvk2AyODmjrto5aaV67Ng///BLACAAYg/wA== Date: Wed, 12 Jun 2019 01:07:13 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D160145B82@SHSMSX101.ccr.corp.intel.com> References: <20190610115410.13458-2-leif.lindholm@linaro.org> <08650203BA1BD64D8AD9B6D5D74A85D160135675@SHSMSX101.ccr.corp.intel.com> <20190611093528.55qrapessgyocmbc@bivouac.eciton.net> In-Reply-To: <20190611093528.55qrapessgyocmbc@bivouac.eciton.net> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable OK. I will add the header when I do push. Reviewed-by: Bob Feng -----Original Message----- From: Leif Lindholm [mailto:leif.lindholm@linaro.org]=20 Sent: Tuesday, June 11, 2019 5:35 PM To: Feng, Bob C Cc: devel@edk2.groups.io; Gao, Liming ; Zhu, Yonghong= ; Andrew Fish ; Laszlo Ersek ; Kinney, Michael D Subject: Re: [PATCH 1/2] BaseTools: add centralized location for git config= files Right, I tend to think of configuration files as not-really-copyrightable. Would you like me to send a v2, or would you be OK with me adding # # Copyr= ight (c) 2019, Linaro Ltd. All rights reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent # to both files and pushing = the series? Regards Leif On Tue, Jun 11, 2019 at 05:25:58AM +0000, Feng, Bob C wrote: > Hi Leif, >=20 > These 2 new file have no license header, need to add? >=20 > Thanks, > Bob >=20 > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Monday, June 10, 2019 7:54 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming=20 > ; Zhu, Yonghong ; Andrew=20 > Fish ; Laszlo Ersek ; Kinney,=20 > Michael D > Subject: [PATCH 1/2] BaseTools: add centralized location for git=20 > config files >=20 > Before adding the git environment initialization script, add the followin= g files that will be pointed to after running said script: >=20 > - BaseTools/Conf/diff.order > - BaseTools/Conf/gitattributes >=20 > Signed-off-by: Leif Lindholm > Reviewed-by: Laszlo Ersek > --- > BaseTools/Conf/diff.order | 8 ++++++++ > BaseTools/Conf/gitattributes | 14 ++++++++++++++ > 2 files changed, 22 insertions(+) > create mode 100644 BaseTools/Conf/diff.order create mode 100644=20 > BaseTools/Conf/gitattributes >=20 > diff --git a/BaseTools/Conf/diff.order b/BaseTools/Conf/diff.order new=20 > file mode 100644 index 0000000000..1d578ac28c > --- /dev/null > +++ b/BaseTools/Conf/diff.order > @@ -0,0 +1,8 @@ > +*.dec > +*.dsc.inc > +*.dsc > +*.fdf > +*.inf > +*.h > +*.vfr > +*.c > diff --git a/BaseTools/Conf/gitattributes=20 > b/BaseTools/Conf/gitattributes new file mode 100644 index=20 > 0000000000..a8f923fd8a > --- /dev/null > +++ b/BaseTools/Conf/gitattributes > @@ -0,0 +1,14 @@ > +*.efi -diff > +*.EFI -diff > +*.bin -diff > +*.BIN -diff > +*.raw -diff > +*.RAW -diff > +*.bmp -diff > +*.BMP -diff > +*.dec diff=3Dini > +*.dsc diff=3Dini > +*.dsc.inc diff=3Dini > +*.fdf diff=3Dini > +*.fdf.inc diff=3Dini > +*.inf diff=3Dini > -- > 2.11.0 >=20