From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: bob.c.feng@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Sun, 16 Jun 2019 20:27:50 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jun 2019 20:27:49 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 16 Jun 2019 20:27:49 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 16 Jun 2019 20:27:49 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 16 Jun 2019 20:27:48 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.104]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.173]) with mapi id 14.03.0439.000; Mon, 17 Jun 2019 11:27:47 +0800 From: "Bob Feng" To: "Shi, Steven" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Rodriguez, Christian" , "Fan, ZhijuX" Subject: Re: [PATCH v2 1/1] BaseTools:Build Cache output notification message Thread-Topic: [PATCH v2 1/1] BaseTools:Build Cache output notification message Thread-Index: AQHVIqaXQs1WRsVawkWFT0KJpez3+qafM+lg Date: Mon, 17 Jun 2019 03:27:46 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D16015249F@SHSMSX101.ccr.corp.intel.com> References: <20190614114441.25468-1-steven.shi@intel.com> <20190614114441.25468-2-steven.shi@intel.com> In-Reply-To: <20190614114441.25468-2-steven.shi@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: Shi, Steven=20 Sent: Friday, June 14, 2019 7:45 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C ;= Rodriguez, Christian ; Fan, ZhijuX Subject: [PATCH v2 1/1] BaseTools:Build Cache output notification message BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D1868 Build need output the cache miss or hit notification message when consume t= he build cache. Current build does not output any message which is not clea= r for user to know whether the module built result is from cache or not. This patch adds message about the cache miss or hit when build consumes the= cache. Cc: Liming Gao Cc: Bob Feng Cc: Zhiju.Fan Signed-off-by: Steven Shi --- BaseTools/Source/Python/build/build.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Pyth= on/build/build.py index 0855d4561c..2dca3c7b34 100644 --- a/BaseTools/Source/Python/build/build.py +++ b/BaseTools/Source/Python/build/build.py @@ -1815,7 +1815,12 @@ class Build(): MaList.append(Ma) if Ma.CanSkipbyHash(): self.HashSkipModules.append(Ma) + if GlobalData.gBinCacheSource: + EdkLogger.quiet("cache hit: %s[%s]"=20 + % (Ma.MetaFile.Path, Ma.Arch)) continue + else: + if GlobalData.gBinCacheSource: + EdkLogger.quiet("cache miss:=20 + %s[%s]" % (Ma.MetaFile.Path, Ma.Arch)) # Not to auto-gen for targets 'clean', 'cleanl= ib', 'cleanall', 'run', 'fds' if self.Target not in ['clean', 'cleanlib', 'c= leanall', 'run', 'fds']: # for target which must generate AutoGen c= ode and makefile @@ -2004,7 +2009,12 @@ class Build(): continue if Ma.CanSkipbyHash(): self.HashSkipModules.append(Ma) + if GlobalData.gBinCacheSource: + EdkLogger.quiet("cache hit: %s[%s]" %=20 + (Ma.MetaFile.Path, Ma.Arch)) continue + else: + if GlobalData.gBinCacheSource: + EdkLogger.quiet("cache miss: %s[%s]" %=20 + (Ma.MetaFile.Path, Ma.Arch)) =20 # Not to auto-gen for targets 'clean', 'cleanlib',= 'cleanall', 'run', 'fds' if self.Target not in ['clean', 'cleanlib', 'clean= all', 'run', 'fds']: -- 2.17.1.windows.2