From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: bob.c.feng@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Sun, 16 Jun 2019 22:55:55 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jun 2019 22:55:55 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 16 Jun 2019 22:55:55 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 16 Jun 2019 22:55:55 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.104]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.72]) with mapi id 14.03.0439.000; Mon, 17 Jun 2019 13:55:52 +0800 From: "Bob Feng" To: "devel@edk2.groups.io" , "Shi, Steven" CC: "Gao, Liming" , "Rodriguez, Christian" , "Fan, ZhijuX" Subject: Re: [edk2-devel] [PATCH v2 1/1] BaseTools:Build cache cannot store the cache files for library package Thread-Topic: [edk2-devel] [PATCH v2 1/1] BaseTools:Build cache cannot store the cache files for library package Thread-Index: AQHVIB+ZVNgZ/tWgq0mvifkDJBRMAqafYkbw Date: Mon, 17 Jun 2019 05:55:52 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D16015259A@SHSMSX101.ccr.corp.intel.com> References: <20190611063316.16284-1-steven.shi@intel.com> <20190611063316.16284-2-steven.shi@intel.com> In-Reply-To: <20190611063316.16284-2-steven.shi@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Stev= en Shi Sent: Tuesday, June 11, 2019 2:33 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C = ; Rodriguez, Christian ; Fan, ZhijuX Subject: [edk2-devel] [PATCH v2 1/1] BaseTools:Build cache cannot store th= e cache files for library package BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1867 Current build cache cannot store the cache for library package. build -p MdePkg\MdePkg.dsc -a IA32 -b DEBUG -t VS2015x86 --hash --binary-d= estination=3DBinCache After build, the expected result is the BinCache fold= er is generated and the MdePkg build cache files (e.g. .hash and .lib) are = stored in the BinCache folder. But the BinCache folder is not generated at = all. This patch is going to fix that issue. Cc: Liming Gao Cc: Bob Feng Cc: Zhiju.Fan Signed-off-by: Steven Shi --- BaseTools/Source/Python/AutoGen/AutoGen.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source= /Python/AutoGen/AutoGen.py index 3f41fbb507..f59a8038d5 100644 --- a/BaseTools/Source/Python/AutoGen/AutoGen.py +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py @@ -3569,8 +3569,11 @@ class ModuleAutoGen(AutoGen): if self.IsAsBuiltInfCreated: return =20 - # Skip the following code for libraries + # Skip INF file generation for libraries if self.IsLibrary: + # Only store the library cache if needed + if GlobalData.gBinCacheDest: + self.CopyModuleToCache() return =20 # Skip the following code for modules with no source files -- 2.17.1.windows.2