From: "Bob Feng" <bob.c.feng@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH 0/3] BaseTools: Move FCE & FMMT tools to edk2 repo
Date: Mon, 17 Jun 2019 09:34:32 +0000 [thread overview]
Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D16015281E@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20190611052240.17152-1-shenglei.zhang@intel.com>
Adding FMMT, FCE to BaseTools is fine for me.
The patch is good to me.
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: Zhang, Shenglei
Sent: Tuesday, June 11, 2019 1:23 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [PATCH 0/3] BaseTools: Move FCE & FMMT tools to edk2 repo
REF:FMMT(https://bugzilla.tianocore.org/show_bug.cgi?id=1847)
FCE(https://bugzilla.tianocore.org/show_bug.cgi?id=1848)
Changes are committed in forked repository:
https://github.com/shenglei10/edk2/commits/movetool
FCE & FMMT tools are in https://firmware.intel.com/develop
Intel UEFI tools and utilities. Now, this patch moves them to edk2 repo BaseTools directory. Besides, this patch updates their license header to BSD-2-Clause-Patent, and does some bug fixes.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Shenglei Zhang (3):
BaseTools/BfmLib: Add BfmLib to edk2/master
BaseTools/FCE: Add FCE tool to edk2/master
BaseTools/FMMT: Add a new tool FMMT
BaseTools/Source/C/BfmLib/BfmLib.c | 4355 +++++++++++
BaseTools/Source/C/BfmLib/BinFileManager.c | 1024 +++
BaseTools/Source/C/FCE/BinaryCreate.c | 216 +
BaseTools/Source/C/FCE/BinaryParse.c | 1326 ++++
BaseTools/Source/C/FCE/Common.c | 2183 ++++++
BaseTools/Source/C/FCE/Expression.c | 2367 ++++++
BaseTools/Source/C/FCE/Fce.c | 6449 +++++++++++++++++
BaseTools/Source/C/FCE/IfrParse.c | 4836 ++++++++++++
.../Source/C/FCE/MonotonicBasedVariable.c | 874 +++
BaseTools/Source/C/FCE/TimeBasedVariable.c | 878 +++
BaseTools/Source/C/FCE/Variable.c | 1091 +++
.../Source/C/FMMT/FirmwareModuleManagement.c | 2559 +++++++
BaseTools/Source/C/FMMT/FmmtLib.c | 5051 +++++++++++++
BaseTools/Source/C/FMMT/Rebase.c | 846 +++
BaseTools/BinWrappers/PosixLike/BfmLib | 29 +
BaseTools/BinWrappers/PosixLike/FCE | 29 +
BaseTools/BinWrappers/PosixLike/FMMT | 29 +
BaseTools/Source/C/BfmLib/BinFileManager.h | 439 ++
BaseTools/Source/C/BfmLib/GNUmakefile | 15 +
BaseTools/Source/C/BfmLib/Makefile | 17 +
BaseTools/Source/C/FCE/BinaryCreate.h | 157 +
BaseTools/Source/C/FCE/BinaryParse.h | 187 +
BaseTools/Source/C/FCE/Common.h | 999 +++
BaseTools/Source/C/FCE/Fce.h | 447 ++
BaseTools/Source/C/FCE/GNUmakefile | 55 +
BaseTools/Source/C/FCE/IfrParse.h | 789 ++
BaseTools/Source/C/FCE/Makefile | 19 +
.../Source/C/FCE/MonotonicBasedVariable.h | 162 +
BaseTools/Source/C/FCE/TimeBasedVariable.h | 166 +
BaseTools/Source/C/FCE/Variable.h | 154 +
BaseTools/Source/C/FCE/VariableCommon.h | 55 +
.../Source/C/FMMT/FirmwareModuleManagement.h | 479 ++
BaseTools/Source/C/FMMT/FmmtConf.ini | 6 +
BaseTools/Source/C/FMMT/GNUmakefile | 16 +
BaseTools/Source/C/FMMT/Makefile | 17 +
BaseTools/Source/C/FMMT/Rebase.h | 31 +
BaseTools/Source/C/GNUmakefile | 5 +-
BaseTools/Source/C/Makefile | 5 +-
38 files changed, 38360 insertions(+), 2 deletions(-) create mode 100644 BaseTools/Source/C/BfmLib/BfmLib.c
create mode 100644 BaseTools/Source/C/BfmLib/BinFileManager.c
create mode 100644 BaseTools/Source/C/FCE/BinaryCreate.c
create mode 100644 BaseTools/Source/C/FCE/BinaryParse.c
create mode 100644 BaseTools/Source/C/FCE/Common.c create mode 100644 BaseTools/Source/C/FCE/Expression.c
create mode 100644 BaseTools/Source/C/FCE/Fce.c create mode 100644 BaseTools/Source/C/FCE/IfrParse.c create mode 100644 BaseTools/Source/C/FCE/MonotonicBasedVariable.c
create mode 100644 BaseTools/Source/C/FCE/TimeBasedVariable.c
create mode 100644 BaseTools/Source/C/FCE/Variable.c create mode 100644 BaseTools/Source/C/FMMT/FirmwareModuleManagement.c
create mode 100644 BaseTools/Source/C/FMMT/FmmtLib.c create mode 100644 BaseTools/Source/C/FMMT/Rebase.c create mode 100755 BaseTools/BinWrappers/PosixLike/BfmLib
create mode 100755 BaseTools/BinWrappers/PosixLike/FCE
create mode 100755 BaseTools/BinWrappers/PosixLike/FMMT
create mode 100644 BaseTools/Source/C/BfmLib/BinFileManager.h
create mode 100644 BaseTools/Source/C/BfmLib/GNUmakefile
create mode 100644 BaseTools/Source/C/BfmLib/Makefile
create mode 100644 BaseTools/Source/C/FCE/BinaryCreate.h
create mode 100644 BaseTools/Source/C/FCE/BinaryParse.h
create mode 100644 BaseTools/Source/C/FCE/Common.h create mode 100644 BaseTools/Source/C/FCE/Fce.h create mode 100644 BaseTools/Source/C/FCE/GNUmakefile
create mode 100644 BaseTools/Source/C/FCE/IfrParse.h create mode 100644 BaseTools/Source/C/FCE/Makefile create mode 100644 BaseTools/Source/C/FCE/MonotonicBasedVariable.h
create mode 100644 BaseTools/Source/C/FCE/TimeBasedVariable.h
create mode 100644 BaseTools/Source/C/FCE/Variable.h create mode 100644 BaseTools/Source/C/FCE/VariableCommon.h
create mode 100644 BaseTools/Source/C/FMMT/FirmwareModuleManagement.h
create mode 100644 BaseTools/Source/C/FMMT/FmmtConf.ini
create mode 100644 BaseTools/Source/C/FMMT/GNUmakefile
create mode 100644 BaseTools/Source/C/FMMT/Makefile create mode 100644 BaseTools/Source/C/FMMT/Rebase.h
--
2.18.0.windows.1
next prev parent reply other threads:[~2019-06-17 9:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 5:22 [PATCH 0/3] BaseTools: Move FCE & FMMT tools to edk2 repo Zhang, Shenglei
2019-06-17 9:34 ` Bob Feng [this message]
2019-06-18 14:06 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08650203BA1BD64D8AD9B6D5D74A85D16015281E@SHSMSX101.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox