From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: bob.c.feng@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Mon, 17 Jun 2019 02:34:36 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jun 2019 02:34:35 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga008.jf.intel.com with ESMTP; 17 Jun 2019 02:34:35 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 17 Jun 2019 02:34:35 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 17 Jun 2019 02:34:35 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.104]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.225]) with mapi id 14.03.0439.000; Mon, 17 Jun 2019 17:34:33 +0800 From: "Bob Feng" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [PATCH 0/3] BaseTools: Move FCE & FMMT tools to edk2 repo Thread-Topic: [PATCH 0/3] BaseTools: Move FCE & FMMT tools to edk2 repo Thread-Index: AQHVIBW0J8r7WyWI4kCwZflAsIqeRqafnweQ Date: Mon, 17 Jun 2019 09:34:32 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D16015281E@SHSMSX101.ccr.corp.intel.com> References: <20190611052240.17152-1-shenglei.zhang@intel.com> In-Reply-To: <20190611052240.17152-1-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Adding FMMT, FCE to BaseTools is fine for me. The patch is good to me. Reviewed-by: Bob Feng -----Original Message----- From: Zhang, Shenglei=20 Sent: Tuesday, June 11, 2019 1:23 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [PATCH 0/3] BaseTools: Move FCE & FMMT tools to edk2 repo REF:FMMT(https://bugzilla.tianocore.org/show_bug.cgi?id=3D1847) FCE(https://bugzilla.tianocore.org/show_bug.cgi?id=3D1848) Changes are committed in forked repository: https://github.com/shenglei10/edk2/commits/movetool FCE & FMMT tools are in https://firmware.intel.com/develop Intel UEFI tools and utilities. Now, this patch moves them to edk2 repo Bas= eTools directory. Besides, this patch updates their license header to BSD-2= -Clause-Patent, and does some bug fixes. Cc: Bob Feng Cc: Liming Gao Shenglei Zhang (3): BaseTools/BfmLib: Add BfmLib to edk2/master BaseTools/FCE: Add FCE tool to edk2/master BaseTools/FMMT: Add a new tool FMMT BaseTools/Source/C/BfmLib/BfmLib.c | 4355 +++++++++++ BaseTools/Source/C/BfmLib/BinFileManager.c | 1024 +++ BaseTools/Source/C/FCE/BinaryCreate.c | 216 + BaseTools/Source/C/FCE/BinaryParse.c | 1326 ++++ BaseTools/Source/C/FCE/Common.c | 2183 ++++++ BaseTools/Source/C/FCE/Expression.c | 2367 ++++++ BaseTools/Source/C/FCE/Fce.c | 6449 +++++++++++++++++ BaseTools/Source/C/FCE/IfrParse.c | 4836 ++++++++++++ .../Source/C/FCE/MonotonicBasedVariable.c | 874 +++ BaseTools/Source/C/FCE/TimeBasedVariable.c | 878 +++ BaseTools/Source/C/FCE/Variable.c | 1091 +++ .../Source/C/FMMT/FirmwareModuleManagement.c | 2559 +++++++ BaseTools/Source/C/FMMT/FmmtLib.c | 5051 +++++++++++++ BaseTools/Source/C/FMMT/Rebase.c | 846 +++ BaseTools/BinWrappers/PosixLike/BfmLib | 29 + BaseTools/BinWrappers/PosixLike/FCE | 29 + BaseTools/BinWrappers/PosixLike/FMMT | 29 + BaseTools/Source/C/BfmLib/BinFileManager.h | 439 ++ BaseTools/Source/C/BfmLib/GNUmakefile | 15 + BaseTools/Source/C/BfmLib/Makefile | 17 + BaseTools/Source/C/FCE/BinaryCreate.h | 157 + BaseTools/Source/C/FCE/BinaryParse.h | 187 + BaseTools/Source/C/FCE/Common.h | 999 +++ BaseTools/Source/C/FCE/Fce.h | 447 ++ BaseTools/Source/C/FCE/GNUmakefile | 55 + BaseTools/Source/C/FCE/IfrParse.h | 789 ++ BaseTools/Source/C/FCE/Makefile | 19 + .../Source/C/FCE/MonotonicBasedVariable.h | 162 + BaseTools/Source/C/FCE/TimeBasedVariable.h | 166 + BaseTools/Source/C/FCE/Variable.h | 154 + BaseTools/Source/C/FCE/VariableCommon.h | 55 + .../Source/C/FMMT/FirmwareModuleManagement.h | 479 ++ BaseTools/Source/C/FMMT/FmmtConf.ini | 6 + BaseTools/Source/C/FMMT/GNUmakefile | 16 + BaseTools/Source/C/FMMT/Makefile | 17 + BaseTools/Source/C/FMMT/Rebase.h | 31 + BaseTools/Source/C/GNUmakefile | 5 +- BaseTools/Source/C/Makefile | 5 +- 38 files changed, 38360 insertions(+), 2 deletions(-) create mode 100644 = BaseTools/Source/C/BfmLib/BfmLib.c create mode 100644 BaseTools/Source/C/BfmLib/BinFileManager.c create mode 100644 BaseTools/Source/C/FCE/BinaryCreate.c create mode 100644 BaseTools/Source/C/FCE/BinaryParse.c create mode 100644 BaseTools/Source/C/FCE/Common.c create mode 100644 Bas= eTools/Source/C/FCE/Expression.c create mode 100644 BaseTools/Source/C/FCE/Fce.c create mode 100644 BaseTo= ols/Source/C/FCE/IfrParse.c create mode 100644 BaseTools/Source/C/FCE/Mono= tonicBasedVariable.c create mode 100644 BaseTools/Source/C/FCE/TimeBasedVariable.c create mode 100644 BaseTools/Source/C/FCE/Variable.c create mode 100644 B= aseTools/Source/C/FMMT/FirmwareModuleManagement.c create mode 100644 BaseTools/Source/C/FMMT/FmmtLib.c create mode 100644 B= aseTools/Source/C/FMMT/Rebase.c create mode 100755 BaseTools/BinWrappers/P= osixLike/BfmLib create mode 100755 BaseTools/BinWrappers/PosixLike/FCE create mode 100755 BaseTools/BinWrappers/PosixLike/FMMT create mode 100644 BaseTools/Source/C/BfmLib/BinFileManager.h create mode 100644 BaseTools/Source/C/BfmLib/GNUmakefile create mode 100644 BaseTools/Source/C/BfmLib/Makefile create mode 100644 BaseTools/Source/C/FCE/BinaryCreate.h create mode 100644 BaseTools/Source/C/FCE/BinaryParse.h create mode 100644 BaseTools/Source/C/FCE/Common.h create mode 100644 Bas= eTools/Source/C/FCE/Fce.h create mode 100644 BaseTools/Source/C/FCE/GNUmak= efile create mode 100644 BaseTools/Source/C/FCE/IfrParse.h create mode 100644 B= aseTools/Source/C/FCE/Makefile create mode 100644 BaseTools/Source/C/FCE/M= onotonicBasedVariable.h create mode 100644 BaseTools/Source/C/FCE/TimeBasedVariable.h create mode 100644 BaseTools/Source/C/FCE/Variable.h create mode 100644 B= aseTools/Source/C/FCE/VariableCommon.h create mode 100644 BaseTools/Source/C/FMMT/FirmwareModuleManagement.h create mode 100644 BaseTools/Source/C/FMMT/FmmtConf.ini create mode 100644 BaseTools/Source/C/FMMT/GNUmakefile create mode 100644 BaseTools/Source/C/FMMT/Makefile create mode 100644 Ba= seTools/Source/C/FMMT/Rebase.h -- 2.18.0.windows.1