Re: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files

["Bob Feng" <bob.c.feng@intel.com>]

The patches look good.

I think removing --nt32 option is incompatible change. What about keep the --nt32 ?

For the Patch 2 setup for different VS tool chains.
Reviewed-by: Bob Feng <bob.c.feng@intel.com>

Thanks,
Bob

-----Original Message-----
From: Bi, Dandan 
Sent: Sunday, June 23, 2019 9:59 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693

Patch 1 remove nt32 related flags in bat files.
Patch 2 setup for different VS tool chains.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Dandan Bi (2):
  Edk2: Remove nt32 related flag in bat files
  Edk2Setup: Support different VS tool chain setup

 BaseTools/get_vsvars.bat        | 42 +++++++++++++++++++++----
 BaseTools/set_vsprefix_envs.bat | 47 +++++++++++++++++++++++++---
 BaseTools/toolsetup.bat         | 68 ++++++++++++++++++++++++++++++++++-------
 edksetup.bat                    | 32 ++++++-------------
 4 files changed, 145 insertions(+), 44 deletions(-)

-- 
1.9.5.msysgit.1