* [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
@ 2019-06-23 13:58 Dandan Bi
2019-06-23 13:58 ` [patch 1/2] Edk2Setup: Remove nt32 related flag in bat files Dandan Bi
` (3 more replies)
0 siblings, 4 replies; 14+ messages in thread
From: Dandan Bi @ 2019-06-23 13:58 UTC (permalink / raw)
To: devel; +Cc: Bob Feng, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693
Patch 1 remove nt32 related flags in bat files.
Patch 2 setup for different VS tool chains.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Dandan Bi (2):
Edk2: Remove nt32 related flag in bat files
Edk2Setup: Support different VS tool chain setup
BaseTools/get_vsvars.bat | 42 +++++++++++++++++++++----
BaseTools/set_vsprefix_envs.bat | 47 +++++++++++++++++++++++++---
BaseTools/toolsetup.bat | 68 ++++++++++++++++++++++++++++++++++-------
edksetup.bat | 32 ++++++-------------
4 files changed, 145 insertions(+), 44 deletions(-)
--
1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* [patch 1/2] Edk2Setup: Remove nt32 related flag in bat files
2019-06-23 13:58 [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Dandan Bi
@ 2019-06-23 13:58 ` Dandan Bi
2019-06-23 13:58 ` [patch 2/2] Edk2Setup: Support different VS tool chain setup Dandan Bi
` (2 subsequent siblings)
3 siblings, 0 replies; 14+ messages in thread
From: Dandan Bi @ 2019-06-23 13:58 UTC (permalink / raw)
To: devel; +Cc: Bob Feng, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693
NT32Pkg has been removed, remove nt32 related
flags in bat files.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
BaseTools/toolsetup.bat | 8 --------
edksetup.bat | 23 +----------------------
2 files changed, 1 insertion(+), 30 deletions(-)
diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat
index 23dae40..999f3b3 100755
--- a/BaseTools/toolsetup.bat
+++ b/BaseTools/toolsetup.bat
@@ -24,18 +24,10 @@ if /I "%1"=="/help" goto Usage
if /I "%1"=="/?" goto Usage
:loop
if "%1"=="" goto setup_workspace
- if /I "%1"=="--nt32" (
- if /I "%2" == "X64" (
- shift
- )
- @REM Ignore --nt32 flag
- shift
- goto loop
- )
if /I "%1"=="Reconfig" (
shift
set RECONFIG=TRUE
goto loop
)
diff --git a/edksetup.bat b/edksetup.bat
index 662ffc0..d607e2e 100755
--- a/edksetup.bat
+++ b/edksetup.bat
@@ -81,22 +81,10 @@ if exist %EDK_BASETOOLS% (
)
:checkNt32Flag
if exist %EDK_TOOLS_PATH%\Source set BASE_TOOLS_PATH=%EDK_TOOLS_PATH%
-@REM The Nt32 Emulation Platform requires Microsoft Libraries
-@REM and headers to interface with Windows.
-if /I "%1"=="--nt32" (
- if /I "%2"=="X64" (
- shift
- call "%BASE_TOOLS_PATH%\Scripts\SetVisualStudio.bat"
- ) else (
- call "%BASE_TOOLS_PATH%\get_vsvars.bat"
- )
- shift
-)
-
:checkBaseTools
IF NOT EXIST "%EDK_TOOLS_PATH%\toolsetup.bat" goto BadBaseTools
call %EDK_TOOLS_PATH%\toolsetup.bat %*
if /I "%1"=="Reconfig" shift
goto check_NASM
@@ -147,20 +135,11 @@ if /I "%1"=="Rebuild" shift
if /I "%1"=="ForceRebuild" shift
if "%1"=="" goto end
:Usage
@echo.
- @echo Usage: "%0 [-h | -help | --help | /h | /help | /?] [--nt32 [X64]] [Reconfig] [Rebuild] [ForceRebuild]"
- @echo --nt32 [X64] If a compiler tool chain is not available in the
- @echo environment, call a script to attempt to set one up.
- @echo This flag is only required if building the
- @echo Nt32Pkg/Nt32Pkg.dsc system emulator.
- @echo If the X64 argument is set, and a compiler tool chain is
- @echo not available, attempt to set up a tool chain that will
- @echo create X64 binaries. Setting these two options have the
- @echo potential side effect of changing tool chains used for a
- @echo rebuild.
+ @echo Usage: "%0 [-h | -help | --help | /h | /help | /?] [Reconfig] [Rebuild] [ForceRebuild]"
@echo.
@echo Reconfig Reinstall target.txt, tools_def.txt and build_rule.txt.
@echo Rebuild Perform incremental rebuild of BaseTools binaries.
@echo ForceRebuild Force a full rebuild of BaseTools binaries.
@echo.
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [patch 2/2] Edk2Setup: Support different VS tool chain setup
2019-06-23 13:58 [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Dandan Bi
2019-06-23 13:58 ` [patch 1/2] Edk2Setup: Remove nt32 related flag in bat files Dandan Bi
@ 2019-06-23 13:58 ` Dandan Bi
2019-06-27 9:38 ` [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Liming Gao
2019-06-27 11:56 ` Bob Feng
3 siblings, 0 replies; 14+ messages in thread
From: Dandan Bi @ 2019-06-23 13:58 UTC (permalink / raw)
To: devel; +Cc: Bob Feng, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693
This patch is to update edksetup with additional option:
VS2017 VS2015 VS2013 VS2012 to setup different VS environment.
And will report error if the specified VS tool is not installed.
For VS2017, also consider the case that only VS2017 build tool
is installed.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
BaseTools/get_vsvars.bat | 42 ++++++++++++++++++++++++-----
BaseTools/set_vsprefix_envs.bat | 47 ++++++++++++++++++++++++++++----
BaseTools/toolsetup.bat | 60 ++++++++++++++++++++++++++++++++++++++---
edksetup.bat | 11 +++++++-
4 files changed, 145 insertions(+), 15 deletions(-)
diff --git a/BaseTools/get_vsvars.bat b/BaseTools/get_vsvars.bat
index 9b5e9d2..9f3759b 100644
--- a/BaseTools/get_vsvars.bat
+++ b/BaseTools/get_vsvars.bat
@@ -6,11 +6,16 @@
@REM SPDX-License-Identifier: BSD-2-Clause-Patent
@REM
@echo off
-goto :main
+set SCRIPT_ERROR=0
+if "%1"=="" goto main
+if /I "%1"=="VS2017" goto VS2017Vars
+if /I "%1"=="VS2015" goto VS2015Vars
+if /I "%1"=="VS2013" goto VS2013Vars
+if /I "%1"=="VS2012" goto VS2012Vars
:set_vsvars
for /f "usebackq tokens=1* delims=: " %%i in (`%*`) do (
if /i "%%i"=="installationPath" call "%%j\VC\Auxiliary\Build\vcvars32.bat"
)
@@ -24,22 +29,47 @@ if defined VCINSTALLDIR goto :EOF
if exist "%GET_VSVARS_BAT_CHECK_DIR%\vsvars32.bat" call "%GET_VSVARS_BAT_CHECK_DIR%\vsvars32.bat"
:vsvars_done
goto :EOF
+:ToolNotInstall
+set SCRIPT_ERROR=1
+goto :EOF
+
REM NOTE: This file will find the most recent Visual Studio installation
REM apparent from the environment.
REM To use an older version, modify your environment set up.
REM (Or invoke the relevant vsvars32 file beforehand).
:main
if defined VCINSTALLDIR goto :done
- if exist "%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe" call :set_vsvars "%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe"
- if exist "%ProgramFiles%\Microsoft Visual Studio\Installer\vswhere.exe" call :set_vsvars "%ProgramFiles%\Microsoft Visual Studio\Installer\vswhere.exe"
- if defined VS140COMNTOOLS call :read_vsvars "%VS140COMNTOOLS%"
- if defined VS120COMNTOOLS call :read_vsvars "%VS120COMNTOOLS%"
- if defined VS110COMNTOOLS call :read_vsvars "%VS110COMNTOOLS%"
+ :VS2017Vars
+ if exist "%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe" (
+ if exist "%ProgramFiles(x86)%\Microsoft Visual Studio\2017\BuildTools" (
+ call :set_vsvars "%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe" -products Microsoft.VisualStudio.Product.BuildTools
+ ) else (
+ call :set_vsvars "%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe"
+ )
+ )
+ if exist "%ProgramFiles%\Microsoft Visual Studio\Installer\vswhere.exe" (
+ if exist "%ProgramFiles%\Microsoft Visual Studio\2017\BuildTools" (
+ call :set_vsvars "%ProgramFiles%\Microsoft Visual Studio\Installer\vswhere.exe" -products Microsoft.VisualStudio.Product.BuildTools
+ ) else (
+ call :set_vsvars "%ProgramFiles%\Microsoft Visual Studio\Installer\vswhere.exe"
+ )
+ )
+ if /I "%1"=="VS2017" goto ToolNotInstall
+
+ :VS2015Vars
+ if defined VS140COMNTOOLS (call :read_vsvars "%VS140COMNTOOLS%") else (if /I "%1"=="VS2015" goto ToolNotInstall)
+
+ :VS2013Vars
+ if defined VS120COMNTOOLS ( call :read_vsvars "%VS120COMNTOOLS%") else (if /I "%1"=="VS2013" goto ToolNotInstall)
+
+ :VS2012Vars
+ if defined VS110COMNTOOLS (call :read_vsvars "%VS110COMNTOOLS%") else (if /I "%1"=="VS2012" goto ToolNotInstall)
+
if defined VS100COMNTOOLS call :read_vsvars "%VS100COMNTOOLS%"
if defined VS90COMNTOOLS call :read_vsvars "%VS90COMNTOOLS%"
if defined VS80COMNTOOLS call :read_vsvars "%VS80COMNTOOLS%"
if defined VS71COMNTOOLS call :read_vsvars "%VS71COMNTOOLS%"
diff --git a/BaseTools/set_vsprefix_envs.bat b/BaseTools/set_vsprefix_envs.bat
index 95f30f7..81686f5 100644
--- a/BaseTools/set_vsprefix_envs.bat
+++ b/BaseTools/set_vsprefix_envs.bat
@@ -8,10 +8,22 @@
@REM SPDX-License-Identifier: BSD-2-Clause-Patent
@REM
@echo off
pushd .
+set SCRIPT_ERROR=0
+goto main
+
+:ToolNotInstall
+set SCRIPT_ERROR=1
+goto :EOF
+
+:main
+if /I "%1"=="VS2017" goto SetVS2017
+if /I "%1"=="VS2015" goto SetVS2015
+if /I "%1"=="VS2013" goto SetVS2013
+if /I "%1"=="VS2012" goto SetVS2012
if defined VS71COMNTOOLS (
if not defined VS2003_PREFIX (
set "VS2003_PREFIX=%VS71COMNTOOLS:~0,-14%"
)
@@ -45,57 +57,82 @@ if defined VS100COMNTOOLS (
if not defined WINSDK7x86_PREFIX (
set "WINSDK7x86_PREFIX=c:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\Bin\"
)
)
+:SetVS2012
if defined VS110COMNTOOLS (
if not defined VS2012_PREFIX (
set "VS2012_PREFIX=%VS110COMNTOOLS:~0,-14%"
)
if not defined WINSDK71_PREFIX (
set "WINSDK71_PREFIX=c:\Program Files\Microsoft SDKs\Windows\v7.1A\Bin\"
)
if not defined WINSDK71x86_PREFIX (
set "WINSDK71x86_PREFIX=c:\Program Files (x86)\Microsoft SDKs\Windows\v7.1A\Bin\"
)
+) else (
+ if /I "%1"=="VS2012" goto ToolNotInstall
)
+if /I "%1"=="VS2012" goto SetWinDDK
+:SetVS2013
if defined VS120COMNTOOLS (
if not defined VS2013_PREFIX (
set "VS2013_PREFIX=%VS120COMNTOOLS:~0,-14%"
)
if not defined WINSDK8_PREFIX (
set "WINSDK8_PREFIX=c:\Program Files\Windows Kits\8.0\bin\"
)
if not defined WINSDK8x86_PREFIX (
set "WINSDK8x86_PREFIX=c:\Program Files (x86)\Windows Kits\8.0\bin\"
)
+) else (
+ if /I "%1"=="VS2013" goto ToolNotInstall
)
+if /I "%1"=="VS2013" goto SetWinDDK
+:SetVS2015
if defined VS140COMNTOOLS (
if not defined VS2015_PREFIX (
set "VS2015_PREFIX=%VS140COMNTOOLS:~0,-14%"
)
if not defined WINSDK81_PREFIX (
set "WINSDK81_PREFIX=c:\Program Files\Windows Kits\8.1\bin\"
)
if not defined WINSDK81x86_PREFIX (
set "WINSDK81x86_PREFIX=c:\Program Files (x86)\Windows Kits\8.1\bin\"
)
+) else (
+ if /I "%1"=="VS2015" goto ToolNotInstall
)
+if /I "%1"=="VS2015" goto SetWinDDK
-@REM set VS2017
+:SetVS2017
if not defined VS150COMNTOOLS (
if exist "%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe" (
- for /f "usebackq tokens=1* delims=: " %%i in (`"%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe"`) do (
- if /i "%%i"=="installationPath" call "%%j\VC\Auxiliary\Build\vcvars32.bat"
+ if exist "%ProgramFiles(x86)%\Microsoft Visual Studio\2017\BuildTools" (
+ for /f "usebackq tokens=1* delims=: " %%i in (`"%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe" -products Microsoft.VisualStudio.Product.BuildTools`) do (
+ if /i "%%i"=="installationPath" call "%%j\VC\Auxiliary\Build\vcvars32.bat"
+ )
+ ) else (
+ for /f "usebackq tokens=1* delims=: " %%i in (`"%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe"`) do (
+ if /i "%%i"=="installationPath" call "%%j\VC\Auxiliary\Build\vcvars32.bat"
+ )
)
) else if exist "%ProgramFiles%\Microsoft Visual Studio\Installer\vswhere.exe" (
- for /f "usebackq tokens=1* delims=: " %%i in (`"%ProgramFiles%\Microsoft Visual Studio\Installer\vswhere.exe"`) do (
- if /i "%%i"=="installationPath" call "%%j\VC\Auxiliary\Build\vcvars32.bat"
+ if exist "%ProgramFiles%\Microsoft Visual Studio\2017\BuildTools" (
+ for /f "usebackq tokens=1* delims=: " %%i in (`"%ProgramFiles%\Microsoft Visual Studio\Installer\vswhere.exe" -products Microsoft.VisualStudio.Product.BuildTools`) do (
+ if /i "%%i"=="installationPath" call "%%j\VC\Auxiliary\Build\vcvars32.bat"
+ )
+ ) else (
+ for /f "usebackq tokens=1* delims=: " %%i in (`"%ProgramFiles%\Microsoft Visual Studio\Installer\vswhere.exe"`) do (
+ if /i "%%i"=="installationPath" call "%%j\VC\Auxiliary\Build\vcvars32.bat"
+ )
)
) else (
+ if /I "%1"=="VS2017" goto ToolNotInstall
goto SetWinDDK
)
)
if defined VCToolsInstallDir (
diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat
index 999f3b3..395694f 100755
--- a/BaseTools/toolsetup.bat
+++ b/BaseTools/toolsetup.bat
@@ -9,10 +9,11 @@
@REM SPDX-License-Identifier: BSD-2-Clause-Patent
@REM
@echo off
pushd .
+set SCRIPT_ERROR=0
@REM ##############################################################
@REM # You should not have to modify anything below this line
@REM #
@@ -39,10 +40,34 @@ if /I "%1"=="/?" goto Usage
if /I "%1"=="ForceRebuild" (
shift
set FORCE_REBUILD=TRUE
goto loop
)
+ if /I "%1"=="VS2017" (
+ shift
+ set VS2017=TRUE
+ set VSTool=VS2017
+ goto loop
+ )
+ if /I "%1"=="VS2015" (
+ shift
+ set VS2015=TRUE
+ set VSTool=VS2015
+ goto loop
+ )
+ if /I "%1"=="VS2013" (
+ shift
+ set VS2013=TRUE
+ set VSTool=VS2013
+ goto loop
+ )
+ if /I "%1"=="VS2012" (
+ shift
+ set VS2012=TRUE
+ set VSTool=VS2012
+ goto loop
+ )
if "%1"=="" goto setup_workspace
if exist %1 (
if not defined BASE_TOOLS_PATH (
if exist %1\Source set BASE_TOOLS_PATH=%1
shift
@@ -149,11 +174,31 @@ IF NOT exist "%EDK_TOOLS_PATH%\set_vsprefix_envs.bat" (
@echo.
@echo !!! ERROR !!! The set_vsprefix_envs.bat was not found !!!
@echo.
goto end
)
-call %EDK_TOOLS_PATH%\set_vsprefix_envs.bat
+if defined VS2017 (
+ call %EDK_TOOLS_PATH%\set_vsprefix_envs.bat VS2017
+) else if defined VS2015 (
+ call %EDK_TOOLS_PATH%\set_vsprefix_envs.bat VS2015
+ call %EDK_TOOLS_PATH%\get_vsvars.bat VS2015
+) else if defined VS2013 (
+ call %EDK_TOOLS_PATH%\set_vsprefix_envs.bat VS2013
+ call %EDK_TOOLS_PATH%\get_vsvars.bat VS2013
+) else if defined VS2012 (
+ call %EDK_TOOLS_PATH%\set_vsprefix_envs.bat VS2012
+ call %EDK_TOOLS_PATH%\get_vsvars.bat VS2012
+) else (
+ call %EDK_TOOLS_PATH%\set_vsprefix_envs.bat
+ call %EDK_TOOLS_PATH%\get_vsvars.bat
+)
+if %SCRIPT_ERROR% NEQ 0 (
+ @echo.
+ @echo !!! ERROR !!! %VSTool% is not installed !!!
+ @echo.
+ goto end
+)
if not defined CONF_PATH (
set CONF_PATH=%WORKSPACE%\Conf
)
@@ -363,11 +408,11 @@ goto end
if not defined FORCE_REBUILD (
if not defined REBUILD (
goto end
)
)
- call "%EDK_TOOLS_PATH%\get_vsvars.bat"
+
if not defined VCINSTALLDIR (
@echo.
@echo !!! ERROR !!!! Cannot find Visual Studio, required to build C tools !!!
@echo.
goto end
@@ -397,22 +442,31 @@ goto end
echo.
goto end
:Usage
@echo.
- echo Usage: "%0 [-h | -help | --help | /h | /help | /?] [ Rebuild | ForceRebuild ] [Reconfig] [base_tools_path [edk_tools_path]]"
+ echo Usage: "%0 [-h | -help | --help | /h | /help | /?] [ Rebuild | ForceRebuild ] [Reconfig] [base_tools_path [edk_tools_path]] [VS2017] [VS2015] [VS2013] [VS2012]"
@echo.
@echo base_tools_path BaseTools project path, BASE_TOOLS_PATH will be set to this path.
@echo edk_tools_path EDK_TOOLS_PATH will be set to this path.
@echo Rebuild If sources are available perform an Incremental build, only
@echo build those updated tools.
@echo ForceRebuild If sources are available, rebuild all tools regardless of
@echo whether they have been updated or not.
@echo Reconfig Reinstall target.txt, tools_def.txt and build_rule.txt.
+ @echo VS2012 Set the env for VS2012 build.
+ @echo VS2013 Set the env for VS2013 build.
+ @echo VS2015 Set the env for VS2015 build.
+ @echo VS2017 Set the env for VS2017 build.
@echo.
:end
set REBUILD=
set FORCE_REBUILD=
set RECONFIG=
+set VS2017=
+set VS2015=
+set VS2013=
+set VS2012=
+set VSTool=
popd
diff --git a/edksetup.bat b/edksetup.bat
index d607e2e..ed46945 100755
--- a/edksetup.bat
+++ b/edksetup.bat
@@ -131,19 +131,28 @@ if defined CYGWIN_HOME (
)
:cygwin_done
if /I "%1"=="Rebuild" shift
if /I "%1"=="ForceRebuild" shift
+if /I "%1"=="VS2017" shift
+if /I "%1"=="VS2015" shift
+if /I "%1"=="VS2013" shift
+if /I "%1"=="VS2012" shift
if "%1"=="" goto end
:Usage
@echo.
- @echo Usage: "%0 [-h | -help | --help | /h | /help | /?] [Reconfig] [Rebuild] [ForceRebuild]"
+ @echo Usage: "%0 [-h | -help | --help | /h | /help | /?] [Reconfig] [Rebuild] [ForceRebuild] [VS2017] [VS2015] [VS2013] [VS2012]"
@echo.
@echo Reconfig Reinstall target.txt, tools_def.txt and build_rule.txt.
@echo Rebuild Perform incremental rebuild of BaseTools binaries.
@echo ForceRebuild Force a full rebuild of BaseTools binaries.
+ @echo ForceRebuild Force a full rebuild of BaseTools binaries.
+ @echo VS2012 Set the env for VS2012 build.
+ @echo VS2013 Set the env for VS2013 build.
+ @echo VS2015 Set the env for VS2015 build.
+ @echo VS2017 Set the env for VS2017 build.
@echo.
@echo Note that target.template, tools_def.template and build_rules.template
@echo will only be copied to target.txt, tools_def.txt and build_rule.txt
@echo respectively if they do not exist. Use option [Reconfig] to force the copy.
@echo.
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
2019-06-23 13:58 [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Dandan Bi
2019-06-23 13:58 ` [patch 1/2] Edk2Setup: Remove nt32 related flag in bat files Dandan Bi
2019-06-23 13:58 ` [patch 2/2] Edk2Setup: Support different VS tool chain setup Dandan Bi
@ 2019-06-27 9:38 ` Liming Gao
2019-06-27 11:56 ` Bob Feng
3 siblings, 0 replies; 14+ messages in thread
From: Liming Gao @ 2019-06-27 9:38 UTC (permalink / raw)
To: Bi, Dandan, devel@edk2.groups.io; +Cc: Feng, Bob C
Dandan:
One minor comment. Help message shows two ForceRebuild options. Please remove one. And, this change retire --nt32 option. Please update wiki page on edksetup usage in https://github.com/tianocore/tianocore.github.io/wiki/Getting-Started-Writing-Simple-Application. With those change, Reviewed-by: Liming Gao <liming.gao@intel.com>
Reconfig Reinstall target.txt, tools_def.txt and build_rule.txt.
Rebuild Perform incremental rebuild of BaseTools binaries.
ForceRebuild Force a full rebuild of BaseTools binaries.
ForceRebuild Force a full rebuild of BaseTools binaries.
Thanks
Liming
> -----Original Message-----
> From: Bi, Dandan
> Sent: Sunday, June 23, 2019 9:59 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693
>
> Patch 1 remove nt32 related flags in bat files.
> Patch 2 setup for different VS tool chains.
>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Dandan Bi (2):
> Edk2: Remove nt32 related flag in bat files
> Edk2Setup: Support different VS tool chain setup
>
> BaseTools/get_vsvars.bat | 42 +++++++++++++++++++++----
> BaseTools/set_vsprefix_envs.bat | 47 +++++++++++++++++++++++++---
> BaseTools/toolsetup.bat | 68 ++++++++++++++++++++++++++++++++++-------
> edksetup.bat | 32 ++++++-------------
> 4 files changed, 145 insertions(+), 44 deletions(-)
>
> --
> 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
2019-06-23 13:58 [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Dandan Bi
` (2 preceding siblings ...)
2019-06-27 9:38 ` [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Liming Gao
@ 2019-06-27 11:56 ` Bob Feng
2019-06-27 14:47 ` Liming Gao
3 siblings, 1 reply; 14+ messages in thread
From: Bob Feng @ 2019-06-27 11:56 UTC (permalink / raw)
To: Bi, Dandan, devel@edk2.groups.io; +Cc: Gao, Liming
The patches look good.
I think removing --nt32 option is incompatible change. What about keep the --nt32 ?
For the Patch 2 setup for different VS tool chains.
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
Thanks,
Bob
-----Original Message-----
From: Bi, Dandan
Sent: Sunday, June 23, 2019 9:59 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693
Patch 1 remove nt32 related flags in bat files.
Patch 2 setup for different VS tool chains.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Dandan Bi (2):
Edk2: Remove nt32 related flag in bat files
Edk2Setup: Support different VS tool chain setup
BaseTools/get_vsvars.bat | 42 +++++++++++++++++++++----
BaseTools/set_vsprefix_envs.bat | 47 +++++++++++++++++++++++++---
BaseTools/toolsetup.bat | 68 ++++++++++++++++++++++++++++++++++-------
edksetup.bat | 32 ++++++-------------
4 files changed, 145 insertions(+), 44 deletions(-)
--
1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
2019-06-27 11:56 ` Bob Feng
@ 2019-06-27 14:47 ` Liming Gao
2019-06-27 15:14 ` Bob Feng
0 siblings, 1 reply; 14+ messages in thread
From: Liming Gao @ 2019-06-27 14:47 UTC (permalink / raw)
To: Feng, Bob C, Bi, Dandan, devel@edk2.groups.io
Bob:
--nt32 option is added for Nt32Pkg. Now, Nt32Pkg has been removed. So, I think it is fine to remove --nt32 option.
> -----Original Message-----
> From: Feng, Bob C
> Sent: Thursday, June 27, 2019 7:56 PM
> To: Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>
> The patches look good.
>
> I think removing --nt32 option is incompatible change. What about keep the --nt32 ?
>
> For the Patch 2 setup for different VS tool chains.
> Reviewed-by: Bob Feng <bob.c.feng@intel.com>
>
> Thanks,
> Bob
>
> -----Original Message-----
> From: Bi, Dandan
> Sent: Sunday, June 23, 2019 9:59 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693
>
> Patch 1 remove nt32 related flags in bat files.
> Patch 2 setup for different VS tool chains.
>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Dandan Bi (2):
> Edk2: Remove nt32 related flag in bat files
> Edk2Setup: Support different VS tool chain setup
>
> BaseTools/get_vsvars.bat | 42 +++++++++++++++++++++----
> BaseTools/set_vsprefix_envs.bat | 47 +++++++++++++++++++++++++---
> BaseTools/toolsetup.bat | 68 ++++++++++++++++++++++++++++++++++-------
> edksetup.bat | 32 ++++++-------------
> 4 files changed, 145 insertions(+), 44 deletions(-)
>
> --
> 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
2019-06-27 14:47 ` Liming Gao
@ 2019-06-27 15:14 ` Bob Feng
2019-06-27 15:16 ` Liming Gao
0 siblings, 1 reply; 14+ messages in thread
From: Bob Feng @ 2019-06-27 15:14 UTC (permalink / raw)
To: Gao, Liming, Bi, Dandan, devel@edk2.groups.io
OK. I think it may break some pre-build script if the pre-build script have "edksetup --nt32"...
-----Original Message-----
From: Gao, Liming
Sent: Thursday, June 27, 2019 10:48 PM
To: Feng, Bob C <bob.c.feng@intel.com>; Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io
Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
Bob:
--nt32 option is added for Nt32Pkg. Now, Nt32Pkg has been removed. So, I think it is fine to remove --nt32 option.
> -----Original Message-----
> From: Feng, Bob C
> Sent: Thursday, June 27, 2019 7:56 PM
> To: Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>
> The patches look good.
>
> I think removing --nt32 option is incompatible change. What about keep the --nt32 ?
>
> For the Patch 2 setup for different VS tool chains.
> Reviewed-by: Bob Feng <bob.c.feng@intel.com>
>
> Thanks,
> Bob
>
> -----Original Message-----
> From: Bi, Dandan
> Sent: Sunday, June 23, 2019 9:59 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693
>
> Patch 1 remove nt32 related flags in bat files.
> Patch 2 setup for different VS tool chains.
>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Dandan Bi (2):
> Edk2: Remove nt32 related flag in bat files
> Edk2Setup: Support different VS tool chain setup
>
> BaseTools/get_vsvars.bat | 42 +++++++++++++++++++++----
> BaseTools/set_vsprefix_envs.bat | 47 +++++++++++++++++++++++++---
> BaseTools/toolsetup.bat | 68 ++++++++++++++++++++++++++++++++++-------
> edksetup.bat | 32 ++++++-------------
> 4 files changed, 145 insertions(+), 44 deletions(-)
>
> --
> 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
2019-06-27 15:14 ` Bob Feng
@ 2019-06-27 15:16 ` Liming Gao
2019-06-28 1:10 ` Dandan Bi
0 siblings, 1 reply; 14+ messages in thread
From: Liming Gao @ 2019-06-27 15:16 UTC (permalink / raw)
To: Feng, Bob C, Bi, Dandan, devel@edk2.groups.io
Yes. Those script needs to be updated together.
> -----Original Message-----
> From: Feng, Bob C
> Sent: Thursday, June 27, 2019 11:14 PM
> To: Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io
> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>
> OK. I think it may break some pre-build script if the pre-build script have "edksetup --nt32"...
>
> -----Original Message-----
> From: Gao, Liming
> Sent: Thursday, June 27, 2019 10:48 PM
> To: Feng, Bob C <bob.c.feng@intel.com>; Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io
> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>
> Bob:
> --nt32 option is added for Nt32Pkg. Now, Nt32Pkg has been removed. So, I think it is fine to remove --nt32 option.
>
> > -----Original Message-----
> > From: Feng, Bob C
> > Sent: Thursday, June 27, 2019 7:56 PM
> > To: Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io
> > Cc: Gao, Liming <liming.gao@intel.com>
> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >
> > The patches look good.
> >
> > I think removing --nt32 option is incompatible change. What about keep the --nt32 ?
> >
> > For the Patch 2 setup for different VS tool chains.
> > Reviewed-by: Bob Feng <bob.c.feng@intel.com>
> >
> > Thanks,
> > Bob
> >
> > -----Original Message-----
> > From: Bi, Dandan
> > Sent: Sunday, June 23, 2019 9:59 PM
> > To: devel@edk2.groups.io
> > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
> > Subject: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693
> >
> > Patch 1 remove nt32 related flags in bat files.
> > Patch 2 setup for different VS tool chains.
> >
> > Cc: Bob Feng <bob.c.feng@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Dandan Bi (2):
> > Edk2: Remove nt32 related flag in bat files
> > Edk2Setup: Support different VS tool chain setup
> >
> > BaseTools/get_vsvars.bat | 42 +++++++++++++++++++++----
> > BaseTools/set_vsprefix_envs.bat | 47 +++++++++++++++++++++++++---
> > BaseTools/toolsetup.bat | 68 ++++++++++++++++++++++++++++++++++-------
> > edksetup.bat | 32 ++++++-------------
> > 4 files changed, 145 insertions(+), 44 deletions(-)
> >
> > --
> > 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
2019-06-27 15:16 ` Liming Gao
@ 2019-06-28 1:10 ` Dandan Bi
2019-06-28 1:11 ` Liming Gao
[not found] ` <15AC379CC0BB042B.14856@groups.io>
0 siblings, 2 replies; 14+ messages in thread
From: Dandan Bi @ 2019-06-28 1:10 UTC (permalink / raw)
To: Gao, Liming, Feng, Bob C, devel@edk2.groups.io
Hi Liming and Bob,
Thanks for the review. So we reach the agreement that remove the --nt32 flag, right? If so, I will address Liming's comments and then push these two patches.
Thanks,
Dandan
> -----Original Message-----
> From: Gao, Liming
> Sent: Thursday, June 27, 2019 11:17 PM
> To: Feng, Bob C <bob.c.feng@intel.com>; Bi, Dandan
> <dandan.bi@intel.com>; devel@edk2.groups.io
> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>
> Yes. Those script needs to be updated together.
>
> > -----Original Message-----
> > From: Feng, Bob C
> > Sent: Thursday, June 27, 2019 11:14 PM
> > To: Gao, Liming <liming.gao@intel.com>; Bi, Dandan
> > <dandan.bi@intel.com>; devel@edk2.groups.io
> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >
> > OK. I think it may break some pre-build script if the pre-build script have
> "edksetup --nt32"...
> >
> > -----Original Message-----
> > From: Gao, Liming
> > Sent: Thursday, June 27, 2019 10:48 PM
> > To: Feng, Bob C <bob.c.feng@intel.com>; Bi, Dandan
> > <dandan.bi@intel.com>; devel@edk2.groups.io
> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >
> > Bob:
> > --nt32 option is added for Nt32Pkg. Now, Nt32Pkg has been removed. So,
> I think it is fine to remove --nt32 option.
> >
> > > -----Original Message-----
> > > From: Feng, Bob C
> > > Sent: Thursday, June 27, 2019 7:56 PM
> > > To: Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io
> > > Cc: Gao, Liming <liming.gao@intel.com>
> > > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> > >
> > > The patches look good.
> > >
> > > I think removing --nt32 option is incompatible change. What about keep
> the --nt32 ?
> > >
> > > For the Patch 2 setup for different VS tool chains.
> > > Reviewed-by: Bob Feng <bob.c.feng@intel.com>
> > >
> > > Thanks,
> > > Bob
> > >
> > > -----Original Message-----
> > > From: Bi, Dandan
> > > Sent: Sunday, June 23, 2019 9:59 PM
> > > To: devel@edk2.groups.io
> > > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> > > <liming.gao@intel.com>
> > > Subject: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693
> > >
> > > Patch 1 remove nt32 related flags in bat files.
> > > Patch 2 setup for different VS tool chains.
> > >
> > > Cc: Bob Feng <bob.c.feng@intel.com>
> > > Cc: Liming Gao <liming.gao@intel.com> Dandan Bi (2):
> > > Edk2: Remove nt32 related flag in bat files
> > > Edk2Setup: Support different VS tool chain setup
> > >
> > > BaseTools/get_vsvars.bat | 42 +++++++++++++++++++++----
> > > BaseTools/set_vsprefix_envs.bat | 47 +++++++++++++++++++++++++--
> -
> > > BaseTools/toolsetup.bat | 68
> ++++++++++++++++++++++++++++++++++-------
> > > edksetup.bat | 32 ++++++-------------
> > > 4 files changed, 145 insertions(+), 44 deletions(-)
> > >
> > > --
> > > 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
2019-06-28 1:10 ` Dandan Bi
@ 2019-06-28 1:11 ` Liming Gao
2019-07-03 12:23 ` Bob Feng
[not found] ` <15AC379CC0BB042B.14856@groups.io>
1 sibling, 1 reply; 14+ messages in thread
From: Liming Gao @ 2019-06-28 1:11 UTC (permalink / raw)
To: Bi, Dandan, Feng, Bob C, devel@edk2.groups.io
Dandan:
If you find any pre script to use --nt32 option, please remove them first, then do this change.
>-----Original Message-----
>From: Bi, Dandan
>Sent: Friday, June 28, 2019 9:11 AM
>To: Gao, Liming <liming.gao@intel.com>; Feng, Bob C
><bob.c.feng@intel.com>; devel@edk2.groups.io
>Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>
>Hi Liming and Bob,
>
>Thanks for the review. So we reach the agreement that remove the --nt32
>flag, right? If so, I will address Liming's comments and then push these two
>patches.
>
>
>Thanks,
>Dandan
>
>> -----Original Message-----
>> From: Gao, Liming
>> Sent: Thursday, June 27, 2019 11:17 PM
>> To: Feng, Bob C <bob.c.feng@intel.com>; Bi, Dandan
>> <dandan.bi@intel.com>; devel@edk2.groups.io
>> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>>
>> Yes. Those script needs to be updated together.
>>
>> > -----Original Message-----
>> > From: Feng, Bob C
>> > Sent: Thursday, June 27, 2019 11:14 PM
>> > To: Gao, Liming <liming.gao@intel.com>; Bi, Dandan
>> > <dandan.bi@intel.com>; devel@edk2.groups.io
>> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>> >
>> > OK. I think it may break some pre-build script if the pre-build script have
>> "edksetup --nt32"...
>> >
>> > -----Original Message-----
>> > From: Gao, Liming
>> > Sent: Thursday, June 27, 2019 10:48 PM
>> > To: Feng, Bob C <bob.c.feng@intel.com>; Bi, Dandan
>> > <dandan.bi@intel.com>; devel@edk2.groups.io
>> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>> >
>> > Bob:
>> > --nt32 option is added for Nt32Pkg. Now, Nt32Pkg has been removed. So,
>> I think it is fine to remove --nt32 option.
>> >
>> > > -----Original Message-----
>> > > From: Feng, Bob C
>> > > Sent: Thursday, June 27, 2019 7:56 PM
>> > > To: Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io
>> > > Cc: Gao, Liming <liming.gao@intel.com>
>> > > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>> > >
>> > > The patches look good.
>> > >
>> > > I think removing --nt32 option is incompatible change. What about keep
>> the --nt32 ?
>> > >
>> > > For the Patch 2 setup for different VS tool chains.
>> > > Reviewed-by: Bob Feng <bob.c.feng@intel.com>
>> > >
>> > > Thanks,
>> > > Bob
>> > >
>> > > -----Original Message-----
>> > > From: Bi, Dandan
>> > > Sent: Sunday, June 23, 2019 9:59 PM
>> > > To: devel@edk2.groups.io
>> > > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
>> > > <liming.gao@intel.com>
>> > > Subject: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>> > >
>> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693
>> > >
>> > > Patch 1 remove nt32 related flags in bat files.
>> > > Patch 2 setup for different VS tool chains.
>> > >
>> > > Cc: Bob Feng <bob.c.feng@intel.com>
>> > > Cc: Liming Gao <liming.gao@intel.com> Dandan Bi (2):
>> > > Edk2: Remove nt32 related flag in bat files
>> > > Edk2Setup: Support different VS tool chain setup
>> > >
>> > > BaseTools/get_vsvars.bat | 42 +++++++++++++++++++++----
>> > > BaseTools/set_vsprefix_envs.bat | 47 +++++++++++++++++++++++++-
>-
>> -
>> > > BaseTools/toolsetup.bat | 68
>> ++++++++++++++++++++++++++++++++++-------
>> > > edksetup.bat | 32 ++++++-------------
>> > > 4 files changed, 145 insertions(+), 44 deletions(-)
>> > >
>> > > --
>> > > 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
[not found] ` <15AC379CC0BB042B.14856@groups.io>
@ 2019-06-28 7:09 ` Liming Gao
0 siblings, 0 replies; 14+ messages in thread
From: Liming Gao @ 2019-06-28 7:09 UTC (permalink / raw)
To: devel@edk2.groups.io, Gao, Liming, Bi, Dandan, Feng, Bob C
Push @d31666211873086c058285f4a4f1933bc3c3428c..6759212fa69d5d266c2854ea6de44bfd3f7e370b
>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Liming Gao
>Sent: Friday, June 28, 2019 9:12 AM
>To: Bi, Dandan <dandan.bi@intel.com>; Feng, Bob C <bob.c.feng@intel.com>;
>devel@edk2.groups.io
>Subject: Re: [edk2-devel] [patch 0/2] Edk2Setup: Enahnce edk2setup batch
>files
>
>Dandan:
>
> If you find any pre script to use --nt32 option, please remove them first, then
>do this change.
>
>>-----Original Message-----
>>From: Bi, Dandan
>>Sent: Friday, June 28, 2019 9:11 AM
>>To: Gao, Liming <liming.gao@intel.com>; Feng, Bob C
>><bob.c.feng@intel.com>; devel@edk2.groups.io
>>Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>>
>>Hi Liming and Bob,
>>
>>Thanks for the review. So we reach the agreement that remove the --nt32
>>flag, right? If so, I will address Liming's comments and then push these two
>>patches.
>>
>>
>>Thanks,
>>Dandan
>>
>>> -----Original Message-----
>>> From: Gao, Liming
>>> Sent: Thursday, June 27, 2019 11:17 PM
>>> To: Feng, Bob C <bob.c.feng@intel.com>; Bi, Dandan
>>> <dandan.bi@intel.com>; devel@edk2.groups.io
>>> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>>>
>>> Yes. Those script needs to be updated together.
>>>
>>> > -----Original Message-----
>>> > From: Feng, Bob C
>>> > Sent: Thursday, June 27, 2019 11:14 PM
>>> > To: Gao, Liming <liming.gao@intel.com>; Bi, Dandan
>>> > <dandan.bi@intel.com>; devel@edk2.groups.io
>>> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>>> >
>>> > OK. I think it may break some pre-build script if the pre-build script have
>>> "edksetup --nt32"...
>>> >
>>> > -----Original Message-----
>>> > From: Gao, Liming
>>> > Sent: Thursday, June 27, 2019 10:48 PM
>>> > To: Feng, Bob C <bob.c.feng@intel.com>; Bi, Dandan
>>> > <dandan.bi@intel.com>; devel@edk2.groups.io
>>> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>>> >
>>> > Bob:
>>> > --nt32 option is added for Nt32Pkg. Now, Nt32Pkg has been removed.
>So,
>>> I think it is fine to remove --nt32 option.
>>> >
>>> > > -----Original Message-----
>>> > > From: Feng, Bob C
>>> > > Sent: Thursday, June 27, 2019 7:56 PM
>>> > > To: Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io
>>> > > Cc: Gao, Liming <liming.gao@intel.com>
>>> > > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>>> > >
>>> > > The patches look good.
>>> > >
>>> > > I think removing --nt32 option is incompatible change. What about
>keep
>>> the --nt32 ?
>>> > >
>>> > > For the Patch 2 setup for different VS tool chains.
>>> > > Reviewed-by: Bob Feng <bob.c.feng@intel.com>
>>> > >
>>> > > Thanks,
>>> > > Bob
>>> > >
>>> > > -----Original Message-----
>>> > > From: Bi, Dandan
>>> > > Sent: Sunday, June 23, 2019 9:59 PM
>>> > > To: devel@edk2.groups.io
>>> > > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
>>> > > <liming.gao@intel.com>
>>> > > Subject: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>>> > >
>>> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693
>>> > >
>>> > > Patch 1 remove nt32 related flags in bat files.
>>> > > Patch 2 setup for different VS tool chains.
>>> > >
>>> > > Cc: Bob Feng <bob.c.feng@intel.com>
>>> > > Cc: Liming Gao <liming.gao@intel.com> Dandan Bi (2):
>>> > > Edk2: Remove nt32 related flag in bat files
>>> > > Edk2Setup: Support different VS tool chain setup
>>> > >
>>> > > BaseTools/get_vsvars.bat | 42 +++++++++++++++++++++----
>>> > > BaseTools/set_vsprefix_envs.bat | 47
>+++++++++++++++++++++++++-
>>-
>>> -
>>> > > BaseTools/toolsetup.bat | 68
>>> ++++++++++++++++++++++++++++++++++-------
>>> > > edksetup.bat | 32 ++++++-------------
>>> > > 4 files changed, 145 insertions(+), 44 deletions(-)
>>> > >
>>> > > --
>>> > > 1.9.5.msysgit.1
>
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
2019-06-28 1:11 ` Liming Gao
@ 2019-07-03 12:23 ` Bob Feng
2019-07-04 0:54 ` Dandan Bi
0 siblings, 1 reply; 14+ messages in thread
From: Bob Feng @ 2019-07-03 12:23 UTC (permalink / raw)
To: Gao, Liming, Bi, Dandan, devel@edk2.groups.io
Hi Dandan,
I found the GitEdk2MinMtOlympus.bat for minpurely and GitEdk2MinKabylake.bat for minkabylake need to update. Would you update it?
Thanks,
Bob
-----Original Message-----
From: Gao, Liming
Sent: Friday, June 28, 2019 9:12 AM
To: Bi, Dandan <dandan.bi@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; devel@edk2.groups.io
Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
Dandan:
If you find any pre script to use --nt32 option, please remove them first, then do this change.
>-----Original Message-----
>From: Bi, Dandan
>Sent: Friday, June 28, 2019 9:11 AM
>To: Gao, Liming <liming.gao@intel.com>; Feng, Bob C
><bob.c.feng@intel.com>; devel@edk2.groups.io
>Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>
>Hi Liming and Bob,
>
>Thanks for the review. So we reach the agreement that remove the --nt32
>flag, right? If so, I will address Liming's comments and then push
>these two patches.
>
>
>Thanks,
>Dandan
>
>> -----Original Message-----
>> From: Gao, Liming
>> Sent: Thursday, June 27, 2019 11:17 PM
>> To: Feng, Bob C <bob.c.feng@intel.com>; Bi, Dandan
>> <dandan.bi@intel.com>; devel@edk2.groups.io
>> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>>
>> Yes. Those script needs to be updated together.
>>
>> > -----Original Message-----
>> > From: Feng, Bob C
>> > Sent: Thursday, June 27, 2019 11:14 PM
>> > To: Gao, Liming <liming.gao@intel.com>; Bi, Dandan
>> > <dandan.bi@intel.com>; devel@edk2.groups.io
>> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>> >
>> > OK. I think it may break some pre-build script if the pre-build
>> > script have
>> "edksetup --nt32"...
>> >
>> > -----Original Message-----
>> > From: Gao, Liming
>> > Sent: Thursday, June 27, 2019 10:48 PM
>> > To: Feng, Bob C <bob.c.feng@intel.com>; Bi, Dandan
>> > <dandan.bi@intel.com>; devel@edk2.groups.io
>> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>> >
>> > Bob:
>> > --nt32 option is added for Nt32Pkg. Now, Nt32Pkg has been
>> > removed. So,
>> I think it is fine to remove --nt32 option.
>> >
>> > > -----Original Message-----
>> > > From: Feng, Bob C
>> > > Sent: Thursday, June 27, 2019 7:56 PM
>> > > To: Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io
>> > > Cc: Gao, Liming <liming.gao@intel.com>
>> > > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>> > >
>> > > The patches look good.
>> > >
>> > > I think removing --nt32 option is incompatible change. What about
>> > > keep
>> the --nt32 ?
>> > >
>> > > For the Patch 2 setup for different VS tool chains.
>> > > Reviewed-by: Bob Feng <bob.c.feng@intel.com>
>> > >
>> > > Thanks,
>> > > Bob
>> > >
>> > > -----Original Message-----
>> > > From: Bi, Dandan
>> > > Sent: Sunday, June 23, 2019 9:59 PM
>> > > To: devel@edk2.groups.io
>> > > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
>> > > <liming.gao@intel.com>
>> > > Subject: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>> > >
>> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693
>> > >
>> > > Patch 1 remove nt32 related flags in bat files.
>> > > Patch 2 setup for different VS tool chains.
>> > >
>> > > Cc: Bob Feng <bob.c.feng@intel.com>
>> > > Cc: Liming Gao <liming.gao@intel.com> Dandan Bi (2):
>> > > Edk2: Remove nt32 related flag in bat files
>> > > Edk2Setup: Support different VS tool chain setup
>> > >
>> > > BaseTools/get_vsvars.bat | 42 +++++++++++++++++++++----
>> > > BaseTools/set_vsprefix_envs.bat | 47 +++++++++++++++++++++++++-
>-
>> -
>> > > BaseTools/toolsetup.bat | 68
>> ++++++++++++++++++++++++++++++++++-------
>> > > edksetup.bat | 32 ++++++-------------
>> > > 4 files changed, 145 insertions(+), 44 deletions(-)
>> > >
>> > > --
>> > > 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
2019-07-03 12:23 ` Bob Feng
@ 2019-07-04 0:54 ` Dandan Bi
2019-07-04 1:07 ` Bob Feng
0 siblings, 1 reply; 14+ messages in thread
From: Dandan Bi @ 2019-07-04 0:54 UTC (permalink / raw)
To: Feng, Bob C, Gao, Liming, devel@edk2.groups.io
Hi Bob,
I have updated GitEdk2MinMtOlympus.bat for minpurely via https://github.com/tianocore/edk2-platforms/commit/e7fc97a3f9045c35a077ab0151c696aeba722417
And GitEdk2MinKabylake.bat for minkabylake has been removed via https://github.com/tianocore/edk2-platforms/commit/acbd81a92de1b4213f272a2fa66cc97af30c835c
Both of the platforms should build ok now.
Thanks,
Dandan
> -----Original Message-----
> From: Feng, Bob C
> Sent: Wednesday, July 3, 2019 8:23 PM
> To: Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>;
> devel@edk2.groups.io
> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>
> Hi Dandan,
>
> I found the GitEdk2MinMtOlympus.bat for minpurely and
> GitEdk2MinKabylake.bat for minkabylake need to update. Would you update
> it?
>
> Thanks,
> Bob
>
> -----Original Message-----
> From: Gao, Liming
> Sent: Friday, June 28, 2019 9:12 AM
> To: Bi, Dandan <dandan.bi@intel.com>; Feng, Bob C
> <bob.c.feng@intel.com>; devel@edk2.groups.io
> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>
> Dandan:
>
> If you find any pre script to use --nt32 option, please remove them first,
> then do this change.
>
> >-----Original Message-----
> >From: Bi, Dandan
> >Sent: Friday, June 28, 2019 9:11 AM
> >To: Gao, Liming <liming.gao@intel.com>; Feng, Bob C
> ><bob.c.feng@intel.com>; devel@edk2.groups.io
> >Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >
> >Hi Liming and Bob,
> >
> >Thanks for the review. So we reach the agreement that remove the --nt32
> >flag, right? If so, I will address Liming's comments and then push
> >these two patches.
> >
> >
> >Thanks,
> >Dandan
> >
> >> -----Original Message-----
> >> From: Gao, Liming
> >> Sent: Thursday, June 27, 2019 11:17 PM
> >> To: Feng, Bob C <bob.c.feng@intel.com>; Bi, Dandan
> >> <dandan.bi@intel.com>; devel@edk2.groups.io
> >> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >>
> >> Yes. Those script needs to be updated together.
> >>
> >> > -----Original Message-----
> >> > From: Feng, Bob C
> >> > Sent: Thursday, June 27, 2019 11:14 PM
> >> > To: Gao, Liming <liming.gao@intel.com>; Bi, Dandan
> >> > <dandan.bi@intel.com>; devel@edk2.groups.io
> >> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >> >
> >> > OK. I think it may break some pre-build script if the pre-build
> >> > script have
> >> "edksetup --nt32"...
> >> >
> >> > -----Original Message-----
> >> > From: Gao, Liming
> >> > Sent: Thursday, June 27, 2019 10:48 PM
> >> > To: Feng, Bob C <bob.c.feng@intel.com>; Bi, Dandan
> >> > <dandan.bi@intel.com>; devel@edk2.groups.io
> >> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >> >
> >> > Bob:
> >> > --nt32 option is added for Nt32Pkg. Now, Nt32Pkg has been
> >> > removed. So,
> >> I think it is fine to remove --nt32 option.
> >> >
> >> > > -----Original Message-----
> >> > > From: Feng, Bob C
> >> > > Sent: Thursday, June 27, 2019 7:56 PM
> >> > > To: Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io
> >> > > Cc: Gao, Liming <liming.gao@intel.com>
> >> > > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >> > >
> >> > > The patches look good.
> >> > >
> >> > > I think removing --nt32 option is incompatible change. What about
> >> > > keep
> >> the --nt32 ?
> >> > >
> >> > > For the Patch 2 setup for different VS tool chains.
> >> > > Reviewed-by: Bob Feng <bob.c.feng@intel.com>
> >> > >
> >> > > Thanks,
> >> > > Bob
> >> > >
> >> > > -----Original Message-----
> >> > > From: Bi, Dandan
> >> > > Sent: Sunday, June 23, 2019 9:59 PM
> >> > > To: devel@edk2.groups.io
> >> > > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> >> > > <liming.gao@intel.com>
> >> > > Subject: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >> > >
> >> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693
> >> > >
> >> > > Patch 1 remove nt32 related flags in bat files.
> >> > > Patch 2 setup for different VS tool chains.
> >> > >
> >> > > Cc: Bob Feng <bob.c.feng@intel.com>
> >> > > Cc: Liming Gao <liming.gao@intel.com> Dandan Bi (2):
> >> > > Edk2: Remove nt32 related flag in bat files
> >> > > Edk2Setup: Support different VS tool chain setup
> >> > >
> >> > > BaseTools/get_vsvars.bat | 42 +++++++++++++++++++++----
> >> > > BaseTools/set_vsprefix_envs.bat | 47
> +++++++++++++++++++++++++-
> >-
> >> -
> >> > > BaseTools/toolsetup.bat | 68
> >> ++++++++++++++++++++++++++++++++++-------
> >> > > edksetup.bat | 32 ++++++-------------
> >> > > 4 files changed, 145 insertions(+), 44 deletions(-)
> >> > >
> >> > > --
> >> > > 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
2019-07-04 0:54 ` Dandan Bi
@ 2019-07-04 1:07 ` Bob Feng
0 siblings, 0 replies; 14+ messages in thread
From: Bob Feng @ 2019-07-04 1:07 UTC (permalink / raw)
To: Bi, Dandan, Gao, Liming, devel@edk2.groups.io
OK. Thanks.
I just noticed my local repo is still in devel-minplatform branch.
Thanks,
Bob
-----Original Message-----
From: Bi, Dandan
Sent: Thursday, July 4, 2019 8:55 AM
To: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io
Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
Hi Bob,
I have updated GitEdk2MinMtOlympus.bat for minpurely via https://github.com/tianocore/edk2-platforms/commit/e7fc97a3f9045c35a077ab0151c696aeba722417
And GitEdk2MinKabylake.bat for minkabylake has been removed via https://github.com/tianocore/edk2-platforms/commit/acbd81a92de1b4213f272a2fa66cc97af30c835c
Both of the platforms should build ok now.
Thanks,
Dandan
> -----Original Message-----
> From: Feng, Bob C
> Sent: Wednesday, July 3, 2019 8:23 PM
> To: Gao, Liming <liming.gao@intel.com>; Bi, Dandan
> <dandan.bi@intel.com>; devel@edk2.groups.io
> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>
> Hi Dandan,
>
> I found the GitEdk2MinMtOlympus.bat for minpurely and
> GitEdk2MinKabylake.bat for minkabylake need to update. Would you
> update it?
>
> Thanks,
> Bob
>
> -----Original Message-----
> From: Gao, Liming
> Sent: Friday, June 28, 2019 9:12 AM
> To: Bi, Dandan <dandan.bi@intel.com>; Feng, Bob C
> <bob.c.feng@intel.com>; devel@edk2.groups.io
> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>
> Dandan:
>
> If you find any pre script to use --nt32 option, please remove them
> first, then do this change.
>
> >-----Original Message-----
> >From: Bi, Dandan
> >Sent: Friday, June 28, 2019 9:11 AM
> >To: Gao, Liming <liming.gao@intel.com>; Feng, Bob C
> ><bob.c.feng@intel.com>; devel@edk2.groups.io
> >Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >
> >Hi Liming and Bob,
> >
> >Thanks for the review. So we reach the agreement that remove the
> >--nt32 flag, right? If so, I will address Liming's comments and then
> >push these two patches.
> >
> >
> >Thanks,
> >Dandan
> >
> >> -----Original Message-----
> >> From: Gao, Liming
> >> Sent: Thursday, June 27, 2019 11:17 PM
> >> To: Feng, Bob C <bob.c.feng@intel.com>; Bi, Dandan
> >> <dandan.bi@intel.com>; devel@edk2.groups.io
> >> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >>
> >> Yes. Those script needs to be updated together.
> >>
> >> > -----Original Message-----
> >> > From: Feng, Bob C
> >> > Sent: Thursday, June 27, 2019 11:14 PM
> >> > To: Gao, Liming <liming.gao@intel.com>; Bi, Dandan
> >> > <dandan.bi@intel.com>; devel@edk2.groups.io
> >> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >> >
> >> > OK. I think it may break some pre-build script if the pre-build
> >> > script have
> >> "edksetup --nt32"...
> >> >
> >> > -----Original Message-----
> >> > From: Gao, Liming
> >> > Sent: Thursday, June 27, 2019 10:48 PM
> >> > To: Feng, Bob C <bob.c.feng@intel.com>; Bi, Dandan
> >> > <dandan.bi@intel.com>; devel@edk2.groups.io
> >> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >> >
> >> > Bob:
> >> > --nt32 option is added for Nt32Pkg. Now, Nt32Pkg has been
> >> > removed. So,
> >> I think it is fine to remove --nt32 option.
> >> >
> >> > > -----Original Message-----
> >> > > From: Feng, Bob C
> >> > > Sent: Thursday, June 27, 2019 7:56 PM
> >> > > To: Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io
> >> > > Cc: Gao, Liming <liming.gao@intel.com>
> >> > > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch
> >> > > files
> >> > >
> >> > > The patches look good.
> >> > >
> >> > > I think removing --nt32 option is incompatible change. What
> >> > > about keep
> >> the --nt32 ?
> >> > >
> >> > > For the Patch 2 setup for different VS tool chains.
> >> > > Reviewed-by: Bob Feng <bob.c.feng@intel.com>
> >> > >
> >> > > Thanks,
> >> > > Bob
> >> > >
> >> > > -----Original Message-----
> >> > > From: Bi, Dandan
> >> > > Sent: Sunday, June 23, 2019 9:59 PM
> >> > > To: devel@edk2.groups.io
> >> > > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> >> > > <liming.gao@intel.com>
> >> > > Subject: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >> > >
> >> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693
> >> > >
> >> > > Patch 1 remove nt32 related flags in bat files.
> >> > > Patch 2 setup for different VS tool chains.
> >> > >
> >> > > Cc: Bob Feng <bob.c.feng@intel.com>
> >> > > Cc: Liming Gao <liming.gao@intel.com> Dandan Bi (2):
> >> > > Edk2: Remove nt32 related flag in bat files
> >> > > Edk2Setup: Support different VS tool chain setup
> >> > >
> >> > > BaseTools/get_vsvars.bat | 42 +++++++++++++++++++++----
> >> > > BaseTools/set_vsprefix_envs.bat | 47
> +++++++++++++++++++++++++-
> >-
> >> -
> >> > > BaseTools/toolsetup.bat | 68
> >> ++++++++++++++++++++++++++++++++++-------
> >> > > edksetup.bat | 32 ++++++-------------
> >> > > 4 files changed, 145 insertions(+), 44 deletions(-)
> >> > >
> >> > > --
> >> > > 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-07-04 1:07 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-23 13:58 [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Dandan Bi
2019-06-23 13:58 ` [patch 1/2] Edk2Setup: Remove nt32 related flag in bat files Dandan Bi
2019-06-23 13:58 ` [patch 2/2] Edk2Setup: Support different VS tool chain setup Dandan Bi
2019-06-27 9:38 ` [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Liming Gao
2019-06-27 11:56 ` Bob Feng
2019-06-27 14:47 ` Liming Gao
2019-06-27 15:14 ` Bob Feng
2019-06-27 15:16 ` Liming Gao
2019-06-28 1:10 ` Dandan Bi
2019-06-28 1:11 ` Liming Gao
2019-07-03 12:23 ` Bob Feng
2019-07-04 0:54 ` Dandan Bi
2019-07-04 1:07 ` Bob Feng
[not found] ` <15AC379CC0BB042B.14856@groups.io>
2019-06-28 7:09 ` [edk2-devel] " Liming Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox