From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: bob.c.feng@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Thu, 27 Jun 2019 04:56:06 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2019 04:56:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,423,1557212400"; d="scan'208";a="313769043" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga004.jf.intel.com with ESMTP; 27 Jun 2019 04:56:05 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Jun 2019 04:56:05 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Jun 2019 04:56:05 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.72]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.83]) with mapi id 14.03.0439.000; Thu, 27 Jun 2019 19:56:03 +0800 From: "Bob Feng" To: "Bi, Dandan" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Thread-Topic: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Thread-Index: AQHVKcvGaqDF5rusEUCQvK8MhybDSqavZ/5g Date: Thu, 27 Jun 2019 11:56:02 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D160B33E03@SHSMSX105.ccr.corp.intel.com> References: <20190623135832.48300-1-dandan.bi@intel.com> In-Reply-To: <20190623135832.48300-1-dandan.bi@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWE5Yjc4NzMtNWZjOS00YWQwLWE5ZGUtZTc4NjdhNTg1NTY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaXJNSmd3UnhCNmY1VFVlS2paeVRFdDZaSzNDdzNzNTQxdko5eFZGcHhpeXgrRXZBZCtINjY2bno5eU5PMWtnVyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The patches look good. I think removing --nt32 option is incompatible change. What about keep the = --nt32 ? For the Patch 2 setup for different VS tool chains. Reviewed-by: Bob Feng Thanks, Bob -----Original Message----- From: Bi, Dandan=20 Sent: Sunday, June 23, 2019 9:59 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1693 Patch 1 remove nt32 related flags in bat files. Patch 2 setup for different VS tool chains. Cc: Bob Feng Cc: Liming Gao Dandan Bi (2): Edk2: Remove nt32 related flag in bat files Edk2Setup: Support different VS tool chain setup BaseTools/get_vsvars.bat | 42 +++++++++++++++++++++---- BaseTools/set_vsprefix_envs.bat | 47 +++++++++++++++++++++++++--- BaseTools/toolsetup.bat | 68 ++++++++++++++++++++++++++++++++++---= ---- edksetup.bat | 32 ++++++------------- 4 files changed, 145 insertions(+), 44 deletions(-) --=20 1.9.5.msysgit.1