From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: bob.c.feng@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Thu, 27 Jun 2019 08:14:05 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2019 08:14:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,424,1557212400"; d="scan'208";a="164366394" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga007.fm.intel.com with ESMTP; 27 Jun 2019 08:14:04 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Jun 2019 08:14:04 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Jun 2019 08:14:04 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.72]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.185]) with mapi id 14.03.0439.000; Thu, 27 Jun 2019 23:14:02 +0800 From: "Bob Feng" To: "Gao, Liming" , "Bi, Dandan" , "devel@edk2.groups.io" Subject: Re: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Thread-Topic: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Thread-Index: AQHVKcvGaqDF5rusEUCQvK8MhybDSqavZ/5g//+s1wCAAIxgIA== Date: Thu, 27 Jun 2019 15:14:01 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D160B33EE3@SHSMSX105.ccr.corp.intel.com> References: <20190623135832.48300-1-dandan.bi@intel.com> <08650203BA1BD64D8AD9B6D5D74A85D160B33E03@SHSMSX105.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E48E80C@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E48E80C@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWE5Yjc4NzMtNWZjOS00YWQwLWE5ZGUtZTc4NjdhNTg1NTY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaXJNSmd3UnhCNmY1VFVlS2paeVRFdDZaSzNDdzNzNTQxdko5eFZGcHhpeXgrRXZBZCtINjY2bno5eU5PMWtnVyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable OK. I think it may break some pre-build script if the pre-build script hav= e "edksetup --nt32"... -----Original Message----- From: Gao, Liming=20 Sent: Thursday, June 27, 2019 10:48 PM To: Feng, Bob C ; Bi, Dandan ; d= evel@edk2.groups.io Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Bob: --nt32 option is added for Nt32Pkg. Now, Nt32Pkg has been removed. So, I = think it is fine to remove --nt32 option.=20 > -----Original Message----- > From: Feng, Bob C > Sent: Thursday, June 27, 2019 7:56 PM > To: Bi, Dandan ; devel@edk2.groups.io > Cc: Gao, Liming > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files >=20 > The patches look good. >=20 > I think removing --nt32 option is incompatible change. What about keep th= e --nt32 ? >=20 > For the Patch 2 setup for different VS tool chains. > Reviewed-by: Bob Feng >=20 > Thanks, > Bob >=20 > -----Original Message----- > From: Bi, Dandan > Sent: Sunday, June 23, 2019 9:59 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1693 >=20 > Patch 1 remove nt32 related flags in bat files. > Patch 2 setup for different VS tool chains. >=20 > Cc: Bob Feng > Cc: Liming Gao > Dandan Bi (2): > Edk2: Remove nt32 related flag in bat files > Edk2Setup: Support different VS tool chain setup >=20 > BaseTools/get_vsvars.bat | 42 +++++++++++++++++++++---- > BaseTools/set_vsprefix_envs.bat | 47 +++++++++++++++++++++++++--- > BaseTools/toolsetup.bat | 68 ++++++++++++++++++++++++++++++++++-= ------ > edksetup.bat | 32 ++++++------------- > 4 files changed, 145 insertions(+), 44 deletions(-) >=20 > -- > 1.9.5.msysgit.1