From: "Bob Feng" <bob.c.feng@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
Date: Thu, 4 Jul 2019 01:07:41 +0000 [thread overview]
Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D160B39E63@SHSMSX105.ccr.corp.intel.com> (raw)
In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB40C1C61F@SHSMSX104.ccr.corp.intel.com>
OK. Thanks.
I just noticed my local repo is still in devel-minplatform branch.
Thanks,
Bob
-----Original Message-----
From: Bi, Dandan
Sent: Thursday, July 4, 2019 8:55 AM
To: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io
Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
Hi Bob,
I have updated GitEdk2MinMtOlympus.bat for minpurely via https://github.com/tianocore/edk2-platforms/commit/e7fc97a3f9045c35a077ab0151c696aeba722417
And GitEdk2MinKabylake.bat for minkabylake has been removed via https://github.com/tianocore/edk2-platforms/commit/acbd81a92de1b4213f272a2fa66cc97af30c835c
Both of the platforms should build ok now.
Thanks,
Dandan
> -----Original Message-----
> From: Feng, Bob C
> Sent: Wednesday, July 3, 2019 8:23 PM
> To: Gao, Liming <liming.gao@intel.com>; Bi, Dandan
> <dandan.bi@intel.com>; devel@edk2.groups.io
> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>
> Hi Dandan,
>
> I found the GitEdk2MinMtOlympus.bat for minpurely and
> GitEdk2MinKabylake.bat for minkabylake need to update. Would you
> update it?
>
> Thanks,
> Bob
>
> -----Original Message-----
> From: Gao, Liming
> Sent: Friday, June 28, 2019 9:12 AM
> To: Bi, Dandan <dandan.bi@intel.com>; Feng, Bob C
> <bob.c.feng@intel.com>; devel@edk2.groups.io
> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>
> Dandan:
>
> If you find any pre script to use --nt32 option, please remove them
> first, then do this change.
>
> >-----Original Message-----
> >From: Bi, Dandan
> >Sent: Friday, June 28, 2019 9:11 AM
> >To: Gao, Liming <liming.gao@intel.com>; Feng, Bob C
> ><bob.c.feng@intel.com>; devel@edk2.groups.io
> >Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >
> >Hi Liming and Bob,
> >
> >Thanks for the review. So we reach the agreement that remove the
> >--nt32 flag, right? If so, I will address Liming's comments and then
> >push these two patches.
> >
> >
> >Thanks,
> >Dandan
> >
> >> -----Original Message-----
> >> From: Gao, Liming
> >> Sent: Thursday, June 27, 2019 11:17 PM
> >> To: Feng, Bob C <bob.c.feng@intel.com>; Bi, Dandan
> >> <dandan.bi@intel.com>; devel@edk2.groups.io
> >> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >>
> >> Yes. Those script needs to be updated together.
> >>
> >> > -----Original Message-----
> >> > From: Feng, Bob C
> >> > Sent: Thursday, June 27, 2019 11:14 PM
> >> > To: Gao, Liming <liming.gao@intel.com>; Bi, Dandan
> >> > <dandan.bi@intel.com>; devel@edk2.groups.io
> >> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >> >
> >> > OK. I think it may break some pre-build script if the pre-build
> >> > script have
> >> "edksetup --nt32"...
> >> >
> >> > -----Original Message-----
> >> > From: Gao, Liming
> >> > Sent: Thursday, June 27, 2019 10:48 PM
> >> > To: Feng, Bob C <bob.c.feng@intel.com>; Bi, Dandan
> >> > <dandan.bi@intel.com>; devel@edk2.groups.io
> >> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >> >
> >> > Bob:
> >> > --nt32 option is added for Nt32Pkg. Now, Nt32Pkg has been
> >> > removed. So,
> >> I think it is fine to remove --nt32 option.
> >> >
> >> > > -----Original Message-----
> >> > > From: Feng, Bob C
> >> > > Sent: Thursday, June 27, 2019 7:56 PM
> >> > > To: Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io
> >> > > Cc: Gao, Liming <liming.gao@intel.com>
> >> > > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch
> >> > > files
> >> > >
> >> > > The patches look good.
> >> > >
> >> > > I think removing --nt32 option is incompatible change. What
> >> > > about keep
> >> the --nt32 ?
> >> > >
> >> > > For the Patch 2 setup for different VS tool chains.
> >> > > Reviewed-by: Bob Feng <bob.c.feng@intel.com>
> >> > >
> >> > > Thanks,
> >> > > Bob
> >> > >
> >> > > -----Original Message-----
> >> > > From: Bi, Dandan
> >> > > Sent: Sunday, June 23, 2019 9:59 PM
> >> > > To: devel@edk2.groups.io
> >> > > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> >> > > <liming.gao@intel.com>
> >> > > Subject: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >> > >
> >> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693
> >> > >
> >> > > Patch 1 remove nt32 related flags in bat files.
> >> > > Patch 2 setup for different VS tool chains.
> >> > >
> >> > > Cc: Bob Feng <bob.c.feng@intel.com>
> >> > > Cc: Liming Gao <liming.gao@intel.com> Dandan Bi (2):
> >> > > Edk2: Remove nt32 related flag in bat files
> >> > > Edk2Setup: Support different VS tool chain setup
> >> > >
> >> > > BaseTools/get_vsvars.bat | 42 +++++++++++++++++++++----
> >> > > BaseTools/set_vsprefix_envs.bat | 47
> +++++++++++++++++++++++++-
> >-
> >> -
> >> > > BaseTools/toolsetup.bat | 68
> >> ++++++++++++++++++++++++++++++++++-------
> >> > > edksetup.bat | 32 ++++++-------------
> >> > > 4 files changed, 145 insertions(+), 44 deletions(-)
> >> > >
> >> > > --
> >> > > 1.9.5.msysgit.1
next prev parent reply other threads:[~2019-07-04 1:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 13:58 [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Dandan Bi
2019-06-23 13:58 ` [patch 1/2] Edk2Setup: Remove nt32 related flag in bat files Dandan Bi
2019-06-23 13:58 ` [patch 2/2] Edk2Setup: Support different VS tool chain setup Dandan Bi
2019-06-27 9:38 ` [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Liming Gao
2019-06-27 11:56 ` Bob Feng
2019-06-27 14:47 ` Liming Gao
2019-06-27 15:14 ` Bob Feng
2019-06-27 15:16 ` Liming Gao
2019-06-28 1:10 ` Dandan Bi
2019-06-28 1:11 ` Liming Gao
2019-07-03 12:23 ` Bob Feng
2019-07-04 0:54 ` Dandan Bi
2019-07-04 1:07 ` Bob Feng [this message]
[not found] ` <15AC379CC0BB042B.14856@groups.io>
2019-06-28 7:09 ` [edk2-devel] " Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08650203BA1BD64D8AD9B6D5D74A85D160B39E63@SHSMSX105.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox