From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: bob.c.feng@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Wed, 03 Jul 2019 18:07:45 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2019 18:07:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,449,1557212400"; d="scan'208";a="175106946" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 03 Jul 2019 18:07:44 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 3 Jul 2019 18:07:44 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 3 Jul 2019 18:07:43 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.232]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.109]) with mapi id 14.03.0439.000; Thu, 4 Jul 2019 09:07:42 +0800 From: "Bob Feng" To: "Bi, Dandan" , "Gao, Liming" , "devel@edk2.groups.io" Subject: Re: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Thread-Topic: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Thread-Index: AQHVKcvGaqDF5rusEUCQvK8MhybDSqavZ/5g//+s1wCAAIxgIP//e76AgACl+gCAAABRAIAJHPIAgABMOYCAAIh88A== Date: Thu, 4 Jul 2019 01:07:41 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D160B39E63@SHSMSX105.ccr.corp.intel.com> References: <20190623135832.48300-1-dandan.bi@intel.com> <08650203BA1BD64D8AD9B6D5D74A85D160B33E03@SHSMSX105.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E48E80C@SHSMSX104.ccr.corp.intel.com> <08650203BA1BD64D8AD9B6D5D74A85D160B33EE3@SHSMSX105.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E48E8A0@SHSMSX104.ccr.corp.intel.com> <3C0D5C461C9E904E8F62152F6274C0BB40C08679@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E48EC4D@SHSMSX104.ccr.corp.intel.com> <08650203BA1BD64D8AD9B6D5D74A85D160B39B2B@SHSMSX105.ccr.corp.intel.com> <3C0D5C461C9E904E8F62152F6274C0BB40C1C61F@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB40C1C61F@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable OK. Thanks.=20 I just noticed my local repo is still in devel-minplatform branch. Thanks, Bob -----Original Message----- From: Bi, Dandan=20 Sent: Thursday, July 4, 2019 8:55 AM To: Feng, Bob C ; Gao, Liming ;= devel@edk2.groups.io Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files Hi Bob, I have updated GitEdk2MinMtOlympus.bat for minpurely via https://github.com= /tianocore/edk2-platforms/commit/e7fc97a3f9045c35a077ab0151c696aeba722417 And GitEdk2MinKabylake.bat for minkabylake has been removed via https://gi= thub.com/tianocore/edk2-platforms/commit/acbd81a92de1b4213f272a2fa66cc97af3= 0c835c Both of the platforms should build ok now.=20 Thanks, Dandan > -----Original Message----- > From: Feng, Bob C > Sent: Wednesday, July 3, 2019 8:23 PM > To: Gao, Liming ; Bi, Dandan=20 > ; devel@edk2.groups.io > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files >=20 > Hi Dandan, >=20 > I found the GitEdk2MinMtOlympus.bat for minpurely and=20 > GitEdk2MinKabylake.bat for minkabylake need to update. Would you=20 > update it? >=20 > Thanks, > Bob >=20 > -----Original Message----- > From: Gao, Liming > Sent: Friday, June 28, 2019 9:12 AM > To: Bi, Dandan ; Feng, Bob C=20 > ; devel@edk2.groups.io > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files >=20 > Dandan: >=20 > If you find any pre script to use --nt32 option, please remove them=20 > first, then do this change. >=20 > >-----Original Message----- > >From: Bi, Dandan > >Sent: Friday, June 28, 2019 9:11 AM > >To: Gao, Liming ; Feng, Bob C=20 > >; devel@edk2.groups.io > >Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files > > > >Hi Liming and Bob, > > > >Thanks for the review. So we reach the agreement that remove the=20 > >--nt32 flag, right? If so, I will address Liming's comments and then=20 > >push these two patches. > > > > > >Thanks, > >Dandan > > > >> -----Original Message----- > >> From: Gao, Liming > >> Sent: Thursday, June 27, 2019 11:17 PM > >> To: Feng, Bob C ; Bi, Dandan=20 > >> ; devel@edk2.groups.io > >> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files > >> > >> Yes. Those script needs to be updated together. > >> > >> > -----Original Message----- > >> > From: Feng, Bob C > >> > Sent: Thursday, June 27, 2019 11:14 PM > >> > To: Gao, Liming ; Bi, Dandan=20 > >> > ; devel@edk2.groups.io > >> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files > >> > > >> > OK. I think it may break some pre-build script if the pre-build=20 > >> > script have > >> "edksetup --nt32"... > >> > > >> > -----Original Message----- > >> > From: Gao, Liming > >> > Sent: Thursday, June 27, 2019 10:48 PM > >> > To: Feng, Bob C ; Bi, Dandan=20 > >> > ; devel@edk2.groups.io > >> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files > >> > > >> > Bob: > >> > --nt32 option is added for Nt32Pkg. Now, Nt32Pkg has been=20 > >> > removed. So, > >> I think it is fine to remove --nt32 option. > >> > > >> > > -----Original Message----- > >> > > From: Feng, Bob C > >> > > Sent: Thursday, June 27, 2019 7:56 PM > >> > > To: Bi, Dandan ; devel@edk2.groups.io > >> > > Cc: Gao, Liming > >> > > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch=20 > >> > > files > >> > > > >> > > The patches look good. > >> > > > >> > > I think removing --nt32 option is incompatible change. What=20 > >> > > about keep > >> the --nt32 ? > >> > > > >> > > For the Patch 2 setup for different VS tool chains. > >> > > Reviewed-by: Bob Feng > >> > > > >> > > Thanks, > >> > > Bob > >> > > > >> > > -----Original Message----- > >> > > From: Bi, Dandan > >> > > Sent: Sunday, June 23, 2019 9:59 PM > >> > > To: devel@edk2.groups.io > >> > > Cc: Feng, Bob C ; Gao, Liming=20 > >> > > > >> > > Subject: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files > >> > > > >> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1693 > >> > > > >> > > Patch 1 remove nt32 related flags in bat files. > >> > > Patch 2 setup for different VS tool chains. > >> > > > >> > > Cc: Bob Feng > >> > > Cc: Liming Gao Dandan Bi (2): > >> > > Edk2: Remove nt32 related flag in bat files > >> > > Edk2Setup: Support different VS tool chain setup > >> > > > >> > > BaseTools/get_vsvars.bat | 42 +++++++++++++++++++++---- > >> > > BaseTools/set_vsprefix_envs.bat | 47 > +++++++++++++++++++++++++- > >- > >> - > >> > > BaseTools/toolsetup.bat | 68 > >> ++++++++++++++++++++++++++++++++++------- > >> > > edksetup.bat | 32 ++++++------------- > >> > > 4 files changed, 145 insertions(+), 44 deletions(-) > >> > > > >> > > -- > >> > > 1.9.5.msysgit.1